From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAF62314B78 for ; Tue, 20 Jan 2026 03:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768878477; cv=fail; b=EmA2TTyO8H6rUEQu62bg1zbifbF59JG9PqI8kaXS07U0qEN5xVVfHPlXZCBW9GmsKqxH7M0EH6WwtJD0TGbEYg5D2qRkikVodDoB5vhFeljfBAWgpTPYT7CnpL33BflOOyv0SLxjHZCIK4p0pj0815Ejyqzhh4wda0U3t8PmjIY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768878477; c=relaxed/simple; bh=EwKujA35mjjnpmq8xf82FLt2hLhwXhm8bc2XN256Sng=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=MvQJO+pA4nEKuWKcUjIzIxeVNG53PFyRSrhGHH1ZCTYn64QBtF3wg8ob6npUjQBe96n59q/BV5OJLTlv498bPTcBS3Yr/iZVQ619vhxWXUScxLVoSdkXOOMDuYf0RGqwvUmkr5VTEwjBIfyVBHqABPcMV13fGajd23pUCjxXUz4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WoMLmwfG; arc=fail smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WoMLmwfG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768878476; x=1800414476; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=EwKujA35mjjnpmq8xf82FLt2hLhwXhm8bc2XN256Sng=; b=WoMLmwfGhFRZIRsW1NmXOKFigG74iKvSY74518DjIAJ+YbyBqk9+IYFu qS63MwUspsF7D/qJFSZ72MTMKy0/rhn0qVM/Ioj5j+Ceql9NJLuusP4Ik YWUNntdYHvabhXNHlYW6+/wYQQ+xCE/z3suMqH2PLQfNIx3aXXvTjYc2X z0fOl8N3Oak+/bSn+bIGoMPfmPWjSrNQCRdr58iZQeCndD4zw9zPYcf3k 5oUm7yvusDBAnBqkPrs6LXlXRHxgr/0SC6jm8W+PgzD0DrGRVQL1R32Lw uJC/XOFOehGTtZxdEeLj4NFxJIttx7QEOFh1eVkYFSVnWToYCuYiEKVSt A==; X-CSE-ConnectionGUID: 9G/kA7UsS6OkT9a5dgBHSA== X-CSE-MsgGUID: 2oveTHm8TKKUO/mMVUQaOQ== X-IronPort-AV: E=McAfee;i="6800,10657,11676"; a="70169885" X-IronPort-AV: E=Sophos;i="6.21,239,1763452800"; d="scan'208";a="70169885" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2026 19:07:55 -0800 X-CSE-ConnectionGUID: Xp9bhzgATsuUbE0idNYGsQ== X-CSE-MsgGUID: KlFK17r/SJi72xeo1i8xxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,239,1763452800"; d="scan'208";a="228928667" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2026 19:07:55 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Mon, 19 Jan 2026 19:07:54 -0800 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Mon, 19 Jan 2026 19:07:54 -0800 Received: from CY3PR05CU001.outbound.protection.outlook.com (40.93.201.63) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Mon, 19 Jan 2026 19:07:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UGXbdPtB5DnEFZTLq4RlElXP12lNx6hj0STXeaZ6Kya2/oC5c3+UBWNzucGyzZuDrqz3KO7otqIHFg10E2Z1zR+ELLJF2RyORMEF1poi2xWaJFddewamCUIjAye6lCf8hBVS8tWKwcxN8n9m4O7Pe/lbjRzLHa6Ke7Nlmuei+MAjKPv1qmHiolVmNKzYuMcsmkHd1u4dsx+GyfoQDYLVBoSoPG1qMUavPqIvDMdwW01x115y68Kbo+FgCjQCRm5176CDWh8+22BaFf2NxrAupztZiwPlmZFsPwPuqZZd+pVF1J6Fo7b+BIqe2RxwoE8z9jf8TBprjeNih03lEtIMBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=09GWeD7k8eE+mDW+/mKz1Bzl302hp5l3KvalZjvVIek=; b=PZnI6eZjB9J6OQj0CiTyHBJQdMTqVEZxPUs0QBiuqpbtca/FeZ0+G6g5ByvzM/taGceite9M/YXlHKIcPAlTAItu4dZJebFQ7/5gjZ54LoG5gLCh7sua1JgQZ3ocamcVYULEBJUnxi7fQ3uaLa42Ji2djh2cV24QDXKTCIhGG3YaFT5H5mevINxiDxgQleNP1nGK9/D7OHz40mToqGKcknxqUxX2wrYP2AVlhHcU1PO5XzPoom8h4XHfZMD27LHmlL5Hk92ck1YY0KmGhfzrW1diTwOP2UffPcgllP9mSfI7a24nnSJQgfn2QznfSI5wXM0Kk7PdhSG6V2DOh+uM4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CH3PR11MB8660.namprd11.prod.outlook.com (2603:10b6:610:1ce::13) by CY5PR11MB6209.namprd11.prod.outlook.com (2603:10b6:930:27::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.12; Tue, 20 Jan 2026 03:07:46 +0000 Received: from CH3PR11MB8660.namprd11.prod.outlook.com ([fe80::fdc2:40ba:101d:40bf]) by CH3PR11MB8660.namprd11.prod.outlook.com ([fe80::fdc2:40ba:101d:40bf%6]) with mapi id 15.20.9520.011; Tue, 20 Jan 2026 03:07:46 +0000 Date: Tue, 20 Jan 2026 11:07:35 +0800 From: Chao Gao To: Dave Hansen CC: , , Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Jon Kohler , Pawan Gupta , "Peter Zijlstra (Intel)" , Thomas Gleixner , Tony Luck , Subject: Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper Message-ID: References: <20260119195047.86E3C696@davehans-spike.ostc.intel.com> <20260119195053.E0850F99@davehans-spike.ostc.intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260119195053.E0850F99@davehans-spike.ostc.intel.com> X-ClientProxiedBy: SI2PR04CA0002.apcprd04.prod.outlook.com (2603:1096:4:197::17) To CH3PR11MB8660.namprd11.prod.outlook.com (2603:10b6:610:1ce::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR11MB8660:EE_|CY5PR11MB6209:EE_ X-MS-Office365-Filtering-Correlation-Id: c1379279-2fe3-4768-66eb-08de57d115c4 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?sc75cxKKRqolxbh+ytzTWUjjJ0g4/QT8YJrmJO6JQxfNw4754TOPr2QXWprn?= =?us-ascii?Q?vWoVrWE0PVTU5SgIm2GPLZYnxxbhytwLL5iI+02KkIXEjVbFS6rthljElsET?= =?us-ascii?Q?8BhEemc9o/R+rfoyELAKiV168LTCdmk0xh4MlOPNcKB03WA7fOzHespPUtFU?= =?us-ascii?Q?Bt2M4/pNhWqLQf6LrZ7meTFuf9Y6BMTUCDqYcE6MTSreOMO/cYNKPPVTkHih?= =?us-ascii?Q?tLakZeCboqt0noXpdjNUk9idqN5XcYCPfRY00sABbZx5Q09W89Zesl5oqge7?= =?us-ascii?Q?3hEYRdJ/OmiQeCEEHiNaHDsJiYaP9zQiMfqjkf8qIUs7BFXXKjQlb8VLc4t8?= =?us-ascii?Q?ZwmqMF9mCHbCaqLnV7UJIjtQKTgRV7c2jcKP3m+GhJwDEUTBlaCheROz/3/C?= =?us-ascii?Q?eWZx1ynAsj6MMI9dMZTEegs6aVgn9AcCApZg90p6b+qjZcFSyGOhWjQjtaqp?= =?us-ascii?Q?0TW5xvC+tocNS68iRsZrSwJJA4MhszufEak2XYuhoI9CDVj8UixHFfR5VsUe?= =?us-ascii?Q?WmnkdpJKBoW8bIsC5uEuVdvznK8GqSHPZ2pOU+0G+bjGwCSZSSFCtxCnIbL4?= =?us-ascii?Q?YUQIdODSoDncWz7SJqMe5pw53c0CDUneuwM3hH/5hISCxQiNhHp4MGY2zRNh?= =?us-ascii?Q?mQ2IFMc4AsmX9rilHhmSWU4PGYHHDSLNd2JPkI07bkIeHh+i3ivkaOcm/3gO?= =?us-ascii?Q?Qh6bi0oCXzhpFEnnzscfaIBRYvA9ZDIvUGv33tXG+gR+stqsfnl6QVeraZQS?= =?us-ascii?Q?AxtaQ8+riAY1ErbxTpbd9PfdwnttsURJ+dDte404sZPi3W/OUaPBxpMp4hg7?= =?us-ascii?Q?f7HTvR+dzY2Ja6yGPCRh03I+NfVFwitEVtxDSbAOwDpdMreljvmKx3VI09Ho?= =?us-ascii?Q?WUe0dl/Hpa5peNo9IZCUlMOTPrJEU2IyWvRC4dVMcLEf0IH2OCWg8B8yRSOs?= =?us-ascii?Q?XSLCFSlg0yYHACdQY2kUnVNyzXdeute06lQV/4ojSBxDODdYknIoilKg3h5c?= =?us-ascii?Q?r0DEPu/JTfVC6veKaVrUcsAcVunR4CZYyeGw5RUgzC9BwPecNqH9XdyOBvrf?= =?us-ascii?Q?rEPWdqgbB3HSHiukgaYgD+Oe2nqU9f43An43xwQyssykPIN4L9KPtMf+dupG?= =?us-ascii?Q?gU9Qn0Elp/2Ahmt4Gnvew7isJED2AzGjmv13r618Sm82EJzc4MVsFaD/JpAf?= =?us-ascii?Q?GCtC4isZnjJF0RsMi5247MyaX7Lw3y8tWcdXY2ELFQ6+Hje/lJINVIFlQiqw?= =?us-ascii?Q?MF+iOmbLCPsQt+Gf8MteYBstxwyHcBh+mD8cMfFDBJ0z+CGU1DBdMxWtZdDs?= =?us-ascii?Q?631/3vHQPVceQx0zZvHcV9SKuGD3w7J4338p9sprNXdwzDIBCuOVH5sEMQs0?= =?us-ascii?Q?4VVtYzXIsQthvJYmNaf6dT2iOLzfFyDYwZP1Iul7iI9uc+APvu8X9hoFH1xa?= =?us-ascii?Q?M8L1nGc15zX5+meujE/MXKIoO32ckcKNzQmyU5GpvvNkjh7XQ/JEsXLm7TnU?= =?us-ascii?Q?BGRmgPcQ8sZ7VreVSm1ZWPHGcPwr36/B17ZR1yc45I3kGEH0y9Y9i4vjkgXN?= =?us-ascii?Q?bHZAysTsHxEflpMugoA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR11MB8660.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?21IdE6Hd0J14C9Nq6+Byz4/yYt8R5JpjSX219b1lXavpoehmpnSCzWSyDYwo?= =?us-ascii?Q?Lk35v29ZwDJ8s3HPjj1OasfpA0o56ndKnWEUhXUC15ImRwCwHkI9ZfLPaHkG?= =?us-ascii?Q?/+r6tYkf6htdSjjBD0AfxktCIRwkpeCjPbpAPAeBAcDvT6viIuAPRW7C+R9M?= =?us-ascii?Q?eiefJgT2THcx3KrYJxYpGYeVsBNPZZsJW9sCnACsebKjlAPLRZeGbIJbMVIa?= =?us-ascii?Q?566j2/OfPkEtTz8dw9669aENRGblB9R2Ph9jEFjtJZkCxxvyMpZejY6ni7Bd?= =?us-ascii?Q?vjdiRbrICRVhcq8Le2/ZcKLx2Xg5ChJm6DVh49ggTvSlJFzIGvvGnGUO5RoE?= =?us-ascii?Q?aZo1Cy1oy/CrQmRvhlzVHidGCn05bs8SUvMmRgz3Qt6B3Ajdi8MBtdsaK8PT?= =?us-ascii?Q?jqFxSY3y385GgeQXNkJfnBIoe7+yS6pgCm3eQ7jX1PF3BE8QHIGd2pgrMFZg?= =?us-ascii?Q?cBlyEXWhtwO/duOCSdLDOHSHGexKCxRUYB7Tb6fC+M/jQCxeg4p3QO/oCGsz?= =?us-ascii?Q?+u5mig4g6KKQ9dBsEGZzIHhjiys++x6mg7e3BcdJriv6FCbyUTKSn0reuU4/?= =?us-ascii?Q?wovgnytMsiy4zV3V06JPernAHGgbcDNUZktUbc5PcpmTb6f7BNMCpYwHj4DV?= =?us-ascii?Q?QxQCxVrOC1iEfTOpzwm52Voqs3CXrQ3KAsg1BS9zLu/hjgYtfmDAEauEAI+H?= =?us-ascii?Q?FvyEAbrW/64ez1q85ytStCodUy2GVirxOHmW0NY9QVZTqFhRDeTpw8NTK8o3?= =?us-ascii?Q?ar71UC0wSkTeFHpOcJzGlYr2eEHZXSzLFDh6cg0oUMfaQTOS0vtOZRLHIkju?= =?us-ascii?Q?yxeKCs6yK/AnpsiKwKv/xRQBQd/trC76YpU0/Zkt6mko9JazleansgRdf06E?= =?us-ascii?Q?JXE5KfNuKmx6GgeyppjI8wcJVklMXDh5twnk7fglrKzScHnbx+A7dO3bUI2c?= =?us-ascii?Q?rLjNl2l32qkaBH3pIr4DHrlOx91UUCL4hl5TeQ5f1LzgP+KOcSM1H6pIxUhy?= =?us-ascii?Q?DyCym0ERyLTWn9oY0jb2gh7gpTc+UNrWvnXmYCpvm/nFgLxt0M5S90yFqaKq?= =?us-ascii?Q?yyn9WZpa3E9Mf6AEaX9t9uM2oC0irvMdtNgHDccb8u8d0FsOOHXaWTisLvcz?= =?us-ascii?Q?IbFEZGmqRRB5KGDTOBJiek304BZ2CD+5hufFjVUzpdMwTl3ytcWRFCVcSRFM?= =?us-ascii?Q?iBSntp5vUj0DfMa88J63PAwvkf5eWgy2zRzkdMOpH+MCKDEJ8CzADJ9ybKG7?= =?us-ascii?Q?0zkY5pAVQpJie9mWa+xebYzixbgADjSJbt/V6V53P6OQvN6fanOE+0gpO4uk?= =?us-ascii?Q?m/Kci1ARY/AybuG1qTEFa/ijXCBGJM3m92Gm18jMCxNKsUE+wOgiT+FEF0fv?= =?us-ascii?Q?8KboYqurL3NLcsQPRumvbNwDf72d+4go7krWSm8fQJlWwG4QSFKiXhW+mLYo?= =?us-ascii?Q?elWQcJ1ipEiOXvNqCkTOc8tKC2NQ4qvFqCLjaSx4Vp3s6RT9oO/LBcdcdkK4?= =?us-ascii?Q?uyWS/K0lJWl0ZNAbcNMsVCRJHSxLgZB6kFlcbn2eT/RzlzZQtBbPKzlh0WTv?= =?us-ascii?Q?e8whWNElZGyMg3pBaqggpyOarOXkS1BBQabg0pk8OReg8zd3MR5P28ZgY5bb?= =?us-ascii?Q?+DZu6JPshsFrMgMaDG7s03cbM6y2ssWyDscYaly/WY0o5vPRPpYklMXNmrTZ?= =?us-ascii?Q?jsELCgzTQxW2QLfroE5UzNzJTHyhBYy5wns6aLTXDJSKHqBOYLy+nmDUR4DB?= =?us-ascii?Q?UBqvUu7uAg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c1379279-2fe3-4768-66eb-08de57d115c4 X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2026 03:07:46.1853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NmwYK6m21BYbmboiQCDsAkPeunwEwyFhhZMQuXc7UBCFWwHWYLhRcTvXbhpynajojYrBoA675gMY9oCHmp4xNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6209 X-OriginatorOrg: intel.com On Mon, Jan 19, 2026 at 11:50:53AM -0800, Dave Hansen wrote: > >From: Dave Hansen > >The only code that cares about the platform ID is the microcode update >code itself. To facilitate storing the platform ID in a more generic >place and using it outside of the microcode update itself, put the >enumeration into a helper function in a header. Mirror >intel_get_microcode_revision()'s naming and location. > >But, moving away from intel_collect_cpu_info() means that the model >and family information in CPUID is not readily available. Just call >CPUID again. > >Signed-off-by: Dave Hansen >Cc: Thomas Gleixner >Cc: Ingo Molnar >Cc: Borislav Petkov >Cc: Dave Hansen >Cc: "H. Peter Anvin" >Cc: Tony Luck >Cc: Pawan Gupta >Cc: "Peter Zijlstra (Intel)" >Cc: x86@kernel.org >Cc: Jon Kohler >--- > > b/arch/x86/include/asm/microcode.h | 31 +++++++++++++++++++++++++++++++ > b/arch/x86/kernel/cpu/microcode/intel.c | 10 +--------- > 2 files changed, 32 insertions(+), 9 deletions(-) > >diff -puN arch/x86/include/asm/microcode.h~refactor-get-processor-flags arch/x86/include/asm/microcode.h >--- a/arch/x86/include/asm/microcode.h~refactor-get-processor-flags 2026-01-19 11:38:08.775892390 -0800 >+++ b/arch/x86/include/asm/microcode.h 2026-01-19 11:38:08.783892696 -0800 >@@ -2,7 +2,9 @@ > #ifndef _ASM_X86_MICROCODE_H > #define _ASM_X86_MICROCODE_H > >+#include > #include >+#include nit: You may want to sort the header files alphabetically.