From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08FC73D6489 for ; Tue, 20 Jan 2026 08:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768897091; cv=none; b=aC1NexkjV+ICrx/djYBMlqfE9lnQfxWcO2CFaHoVrEkUoDjX3SxSr6qpmMG1Yv2Rq791ixXf2ZgTxlAGi3Lu+e/xyQnh7N0pwER15OP5c8YWfEagxiYD8brpmo31OgFIBPSM4HnN5fK8b23QXTjvOU8eebAGxf6dcnoijEZzmQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768897091; c=relaxed/simple; bh=V/Kq3GM7CdWxPmjGGXhopMN4k/ZB4/Fsz8cCFlNNsd8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GqTqqEsbvlCA3mAiDN9IYnL2nVq6bWy/wNrmQk52ouHE6xOw53J24noqN8h35edN1zazUp4xk2NQgV7C8OJf/DY/+jWbLd3eleSkmGrSdm3Z50CXXDGOjEdt8zYFr4Xwx2kl1eI/4z32jLQwjcvOnZudmA+eIru+BZUYD7nWKpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bragcW9m; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bragcW9m" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4801c314c84so31121325e9.0 for ; Tue, 20 Jan 2026 00:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768897088; x=1769501888; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=dvxdF1yW3erVUZtptDE7+oEUIWOlSFR799M0RZyknHo=; b=bragcW9m0iOSGuycHdBq3b6x5jDMNUawHUzwVNA18tioo+4GsDjexMPTPfDFVhOEk2 tbZ9av0/dgUiR3VGKExvH3ltgz2E2HVXOOWev5YurRYHoPRXjEvIAIDs2NklCl9/i4yl mWdx/FSFpP68yLp6wPr1JnPhiX3W1bLk3i25R//4naqSAQz9UnFta86aIDkzCAUoosCI ae+yHx6SXjGHwmgO9fnL7jsXtifJ9QUanhTCYMvF43kkvSj7sQ4CB7duM6NWjNUHNpul /dtyzrZr198X7CHzldWySUCKiShAJH5XAsZLSpEh6PczzkiqwjAG/46zYI19nwve7aJJ ECSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768897088; x=1769501888; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dvxdF1yW3erVUZtptDE7+oEUIWOlSFR799M0RZyknHo=; b=QRYGr0L2WExp84+FrAwzHCx5yRWwsSHuxKdw0+I70SSgEBUuyJsoFxPSTr7f2Rc/el /QWmXrZ4MSUt4AAKxk4gZtl7FyzeL3hUGyZQDYgKzO5q4Lw17G9mn6K/5znJj+ftUpOv VQkU2ecnGjKTu4IOHvob05BZ858TeN7NsJlROG78t9PKgAb6K+izP1KYjxhJbZrjHl8i 21VLMBhnqnV/jQHiL8aJQrT91cCL6AKerNV2Hzhobu9dxQbHo0KtgA0ioYit1XiOjiHy KZnEHTkk8bS5X6fp1L9ygCfIM7ZaHabla3R8PfqhNRgtKVwRiHwzoBCZlmT+YvGdMdwH SyCg== X-Forwarded-Encrypted: i=1; AJvYcCUY/Ft1WBfeI9cjSVNZmvLvZKXaRII1Ge+Lt8HYWrT5rOfBxNdJrQbA61iR1F087Eg35wiCvR1Xa/V3Qz8=@vger.kernel.org X-Gm-Message-State: AOJu0YzitbXiY2S3biK1jw2kWTvzyNgS4vO6uJxB0U9KfozaFb6EXX1h QyXqaj2yNkdPn8HIeP8fT94C2rASCT4TjnL1kuFJYBYszFPOMOYRfY1W X-Gm-Gg: AY/fxX7QTifUXwfFgZuvUrS9YMsOs06K+4tbSqx1ngZRoKkD8fCNGomh6L0/u7OC110 ZnLOqd1h3lSeKkHG+hsGxaLnAcyXDNAOHhneHaA0Jo/WdshBZgZ5FoIier0XyvFOtSvOk3lkbix jRCZTESGc0fJigJT3fvBfivo62Yqo8CyZqhwcB2dk7udTllVYiNOyTrtsGZrguUYezFl6TSxdzG KwQ1ZE/ocd4D3Yr46Au8kNaqu7+UoMhEK5XjvE96G9zyKPSuBzXMmURg3ZUao6rS7E0NLGmd89u wofoekYMObag0hNDlDO6dGlOQhZUCE3tIG3bpjOPevWq/Feix2lEpxQTZC5BQMtWrtEp3bQbz01 Lafcp38mqgCZtZZXifzndbyTgtd+PKUO8l4zG4CZA9+KBkXDDEGLpi4M1nsE3 X-Received: by 2002:a05:600c:8b67:b0:47d:3ffb:16c9 with SMTP id 5b1f17b1804b1-4801e342091mr141811525e9.23.1768897088056; Tue, 20 Jan 2026 00:18:08 -0800 (PST) Received: from krava ([2a02:8308:a00c:e200::b44f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e9ebc1bsm102170685e9.5.2026.01.20.00.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 00:18:07 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Tue, 20 Jan 2026 09:18:06 +0100 To: Menglong Dong Cc: Menglong Dong , Jiri Olsa , andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, mattbobrowski@google.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v3 1/2] bpf: support bpf_get_func_arg() for BPF_TRACE_RAW_TP Message-ID: References: <20260119023732.130642-1-dongml2@chinatelecom.cn> <20260119023732.130642-2-dongml2@chinatelecom.cn> <6099572.DvuYhMxLoT@7950hx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6099572.DvuYhMxLoT@7950hx> On Tue, Jan 20, 2026 at 09:24:46AM +0800, Menglong Dong wrote: > On 2026/1/20 07:37, Jiri Olsa wrote: > > On Mon, Jan 19, 2026 at 10:37:31AM +0800, Menglong Dong wrote: > > > For now, bpf_get_func_arg() and bpf_get_func_arg_cnt() is not supported by > > > the BPF_TRACE_RAW_TP, which is not convenient to get the argument of the > > > tracepoint, especially for the case that the position of the arguments in > > > a tracepoint can change. > > > > > > The target tracepoint BTF type id is specified during loading time, > > > therefore we can get the function argument count from the function > > > prototype instead of the stack. > > > > > > Signed-off-by: Menglong Dong > > > --- > > > v3: > > > - remove unnecessary NULL checking for prog->aux->attach_func_proto > > > > > > v2: > > > - for nr_args, skip first 'void *__data' argument in btf_trace_##name > > > typedef > > > --- > > > kernel/bpf/verifier.c | 32 ++++++++++++++++++++++++++++---- > > > kernel/trace/bpf_trace.c | 4 ++-- > > > 2 files changed, 30 insertions(+), 6 deletions(-) > > > > > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > > > index faa1ecc1fe9d..4f52342573f0 100644 > > > --- a/kernel/bpf/verifier.c > > > +++ b/kernel/bpf/verifier.c > > > @@ -23316,8 +23316,20 @@ static int do_misc_fixups(struct bpf_verifier_env *env) > > > /* Implement bpf_get_func_arg inline. */ > > > if (prog_type == BPF_PROG_TYPE_TRACING && > > > insn->imm == BPF_FUNC_get_func_arg) { > > > - /* Load nr_args from ctx - 8 */ > > > - insn_buf[0] = BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); > > > + if (eatype == BPF_TRACE_RAW_TP) { > > > + int nr_args = btf_type_vlen(prog->aux->attach_func_proto); > > > + > > > + /* > > > + * skip first 'void *__data' argument in btf_trace_##name > > > + * typedef > > > + */ > > > + nr_args--; > > > + /* Save nr_args to reg0 */ > > > + insn_buf[0] = BPF_MOV64_IMM(BPF_REG_0, nr_args); > > > + } else { > > > + /* Load nr_args from ctx - 8 */ > > > + insn_buf[0] = BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); > > > + } > > > insn_buf[1] = BPF_JMP32_REG(BPF_JGE, BPF_REG_2, BPF_REG_0, 6); > > > insn_buf[2] = BPF_ALU64_IMM(BPF_LSH, BPF_REG_2, 3); > > > insn_buf[3] = BPF_ALU64_REG(BPF_ADD, BPF_REG_2, BPF_REG_1); > > > @@ -23369,8 +23381,20 @@ static int do_misc_fixups(struct bpf_verifier_env *env) > > > /* Implement get_func_arg_cnt inline. */ > > > if (prog_type == BPF_PROG_TYPE_TRACING && > > > insn->imm == BPF_FUNC_get_func_arg_cnt) { > > > - /* Load nr_args from ctx - 8 */ > > > - insn_buf[0] = BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); > > > + if (eatype == BPF_TRACE_RAW_TP) { > > > + int nr_args = btf_type_vlen(prog->aux->attach_func_proto); > > > + > > > + /* > > > + * skip first 'void *__data' argument in btf_trace_##name > > > + * typedef > > > + */ > > > + nr_args--; > > > + /* Save nr_args to reg0 */ > > > > I think we can attach single bpf program to multiple rawtp tracepoints, > > in which case this would not work properly for such program links on > > tracepoints with different nr_args, right? > > Hi, Jiri. As for now, I think we can't do that when I look into > bpf_raw_tp_link_attach(). For the BPF_TRACE_RAW_TP, we specify > a target btf type id when loading the bpf prog. And during > attaching, it seems that we can only attach to that target, which > means that we can't attach to multiple rawtp tracepoint. And > we can't change the target btf id when reattach, too. Right? > > Part of the implement of bpf_raw_tp_link_attach(): > > static int bpf_raw_tp_link_attach(struct bpf_prog *prog, > const char __user *user_tp_name, u64 cookie, > enum bpf_attach_type attach_type) > { > struct bpf_link_primer link_primer; > struct bpf_raw_tp_link *link; > struct bpf_raw_event_map *btp; > const char *tp_name; > char buf[128]; > int err; > > switch (prog->type) { > case BPF_PROG_TYPE_TRACING: > case BPF_PROG_TYPE_EXT: > case BPF_PROG_TYPE_LSM: > if (user_tp_name) > /* The attach point for this category of programs > * should be specified via btf_id during program load. > */ ah there's the name check, ok.. got confused by the max_ctx_offset check in bpf_probe_register thanks, jirka > return -EINVAL; > if (prog->type == BPF_PROG_TYPE_TRACING && > prog->expected_attach_type == BPF_TRACE_RAW_TP) { > tp_name = prog->aux->attach_func_name; > break; > } > [......] > } > [......] > } > > Thanks! > Menglong Dong > > > > > jirka > > > > > > > + insn_buf[0] = BPF_MOV64_IMM(BPF_REG_0, nr_args); > > > + } else { > > > + /* Load nr_args from ctx - 8 */ > > > + insn_buf[0] = BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); > > > + } > > > > > > new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, 1); > > > if (!new_prog) > > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > > > index 6e076485bf70..9b1b56851d26 100644 > > > --- a/kernel/trace/bpf_trace.c > > > +++ b/kernel/trace/bpf_trace.c > > > @@ -1734,11 +1734,11 @@ tracing_prog_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) > > > case BPF_FUNC_d_path: > > > return &bpf_d_path_proto; > > > case BPF_FUNC_get_func_arg: > > > - return bpf_prog_has_trampoline(prog) ? &bpf_get_func_arg_proto : NULL; > > > + return &bpf_get_func_arg_proto; > > > case BPF_FUNC_get_func_ret: > > > return bpf_prog_has_trampoline(prog) ? &bpf_get_func_ret_proto : NULL; > > > case BPF_FUNC_get_func_arg_cnt: > > > - return bpf_prog_has_trampoline(prog) ? &bpf_get_func_arg_cnt_proto : NULL; > > > + return &bpf_get_func_arg_cnt_proto; > > > case BPF_FUNC_get_attach_cookie: > > > if (prog->type == BPF_PROG_TYPE_TRACING && > > > prog->expected_attach_type == BPF_TRACE_RAW_TP) > > > > > > > >