Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Jan 19, 2026 at 11:50:49AM -0800, Dave Hansen wrote:

> The intel-family.h header uses Vendor/Family/Model macros but it does not
> #include the header where they are defined. If that header is included,
> the build blows up in #include hell.
> 
> Luckily, these macros are completely independent and do not themselves
> have any dependencies on other code.
> 
> Break the VFM_*() macros out into their own header.
> 
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

Still don't understand why people putting Cc list before the cutter. This noise
in the commit message and when retrospectively one reads on the small screen (I
do on the phone from time to time) it makes it at bare miniumum inconvenient).

> Cc: Thomas Gleixner <tglx@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: x86@kernel.org
> Cc: Jon Kohler <jon@nutanix.com>
> ---

...

> +#define	VFM_MODEL_MASK	GENMASK(VFM_FAMILY_BIT - 1, VFM_MODEL_BIT)
> +#define	VFM_FAMILY_MASK	GENMASK(VFM_VENDOR_BIT - 1, VFM_FAMILY_BIT)
> +#define	VFM_VENDOR_MASK	GENMASK(VFM_RSVD_BIT - 1, VFM_VENDOR_BIT)

There are tabs after #define, is it on purpose?
(yes, I know this is simple move, but if not deliberate, we can tweak
 the tabs/spaces while at it)

...

> +#define	VFM_MAKE(_vendor, _family, _model) (	\

Ditto.

> +	((_model) << VFM_MODEL_BIT) |		\
> +	((_family) << VFM_FAMILY_BIT) |		\
> +	((_vendor) << VFM_VENDOR_BIT)		\
> +)

-- 
With Best Regards,
Andy Shevchenko