From: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
To: linusw@kernel.org
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, linux-gpio@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
gaohan@iscas.ac.cn, me@ziyao.cc
Subject: Re: [PATCH v2] pinctrl: canaan: k230: Fix NULL pointer dereference when parsing devicetree
Date: Tue, 20 Jan 2026 14:03:24 +0800 [thread overview]
Message-ID: <aW8arOPzmpigRW+a@duge-virtual-machine> (raw)
In-Reply-To: <aWiLFFnk9aAiMMJI@duge-virtual-machine>
On Thu, Jan 15, 2026 at 02:38:14PM +0800, Jiayu Du wrote:
> On Sun, Dec 28, 2025 at 11:49:47PM +0800, Jiayu Du wrote:
> > When probing the k230 pinctrl driver, the kernel triggers a NULL pointer
> > dereference. The crash trace showed:
> > [ 0.732084] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000068
> > [ 0.740737] ...
> > [ 0.776296] epc : k230_pinctrl_probe+0x1be/0x4fc
> >
> > In k230_pinctrl_parse_functions(), we attempt to retrieve the device
> > pointer via info->pctl_dev->dev, but info->pctl_dev is only initialized
> > after k230_pinctrl_parse_dt() completes.
> >
> > At the time of DT parsing, info->pctl_dev is still NULL, leading to
> > the invalid dereference of info->pctl_dev->dev.
> >
> > Use the already available device pointer from platform_device
> > instead of accessing through uninitialized pctl_dev.
> >
> > Fixes: d94a32ac688f ("pinctrl: canaan: k230: Fix order of DT parse and pinctrl register")
> > Signed-off-by: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
> > ---
> > drivers/pinctrl/pinctrl-k230.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pinctrl/pinctrl-k230.c b/drivers/pinctrl/pinctrl-k230.c
> > index d716f23d837f..20f7c0f70eb7 100644
> > --- a/drivers/pinctrl/pinctrl-k230.c
> > +++ b/drivers/pinctrl/pinctrl-k230.c
> > @@ -65,6 +65,7 @@ struct k230_pmx_func {
> > };
> >
> > struct k230_pinctrl {
> > + struct device *dev;
> > struct pinctrl_desc pctl;
> > struct pinctrl_dev *pctl_dev;
> > struct regmap *regmap_base;
> > @@ -470,7 +471,7 @@ static int k230_pinctrl_parse_groups(struct device_node *np,
> > struct k230_pinctrl *info,
> > unsigned int index)
> > {
> > - struct device *dev = info->pctl_dev->dev;
> > + struct device *dev = info->dev;
> > const __be32 *list;
> > int size, i, ret;
> >
> > @@ -511,7 +512,7 @@ static int k230_pinctrl_parse_functions(struct device_node *np,
> > struct k230_pinctrl *info,
> > unsigned int index)
> > {
> > - struct device *dev = info->pctl_dev->dev;
> > + struct device *dev = info->dev;
> > struct k230_pmx_func *func;
> > struct k230_pin_group *grp;
> > static unsigned int idx, i;
> > @@ -596,6 +597,8 @@ static int k230_pinctrl_probe(struct platform_device *pdev)
> > if (!info)
> > return -ENOMEM;
> >
> > + info->dev = dev;
> > +
> > pctl = &info->pctl;
> >
> > pctl->name = "k230-pinctrl";
> > --
> > 2.52.0
> >
Hi Linus, sorry for bothering again. Could you please take a look at
this patch? Thanks for your time.
Regards,
Jiayu Du
next prev parent reply other threads:[~2026-01-20 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-28 15:49 [PATCH v2] pinctrl: canaan: k230: Fix NULL pointer dereference when parsing devicetree Jiayu Du
2026-01-15 6:38 ` Jiayu Du
2026-01-20 6:03 ` Jiayu Du [this message]
2026-02-03 0:32 ` Linus Walleij
2026-02-03 14:02 ` Ze Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW8arOPzmpigRW+a@duge-virtual-machine \
--to=jiayu.riscv@isrc.iscas.ac.cn \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=gaohan@iscas.ac.cn \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@ziyao.cc \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox