From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E78CB3806C5 for ; Tue, 20 Jan 2026 07:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768892788; cv=none; b=asjDhhRuMRBbOX3fbhfWWseWgaErkzwa7N9uOzrZYrdnn+/TXws1P79bBVgWYJGvpkUjyQh0/Vdxt6ER1QJ1ugsknVnFGhp1NGZDyB2bJOoBUyNlubVwq3gRE7WIP2HkwPSIKcRjK/ic4Cn/X8HNyn+Vr1WuPcmAlgH+3BMcjY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768892788; c=relaxed/simple; bh=ba6zY2XyrwqB2CPUushd7nLiDwvtvl9GQips3T4NSk8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H2xnfRHfybomdQ6IiR7EKvbPlw3di7hdvJBjZNS1CjVcxGl8ep88n4zZ/rST1BpgFsm2ecKAAV+07ePrZ0yhceYwOtcJoWXIwgtx+CJyCoTh1VxStemuJqWF9RU0rD/0r9NU7Ycjbt0K64OsSgXJcPmfUf46HXnTioN/HtbvU8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mSI/gYN4; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mSI/gYN4" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47ff94b46afso33040645e9.1 for ; Mon, 19 Jan 2026 23:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768892779; x=1769497579; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c/aaI4jFo0H96RNLVYivVXnfIHMNBzi8Il4iagJPrMA=; b=mSI/gYN4sCVgGa4hPDEL/wAEdFJDNXfWHIFuSn2eoHGD9TmDmuA+vM5L1lzFcly7nh bdbHFhLUUAAYQyd+Ipne+2BOcJzo5sE7hH8CJmvbr8a1CWNErdR+qja+grHE74Ogacgx fks3fjSjGEk84qto8NKF2xb9ThX8LtGlKTYHs2UuySJZjWY4UijOL5v80JE2T0zMhux9 VY7Kba9bSi9PciWbj1GxGLONzEOzHsfODiSHZgw4rIOfJQVHjY5r/Sohh+B57FO5y3ip xjG0hiznAQZWtf4PbHOKKFBP5Kle47KCwAfSec2Fvx+nyGvFRgPZGj8QeN63k7uW6UIg j0tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768892779; x=1769497579; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c/aaI4jFo0H96RNLVYivVXnfIHMNBzi8Il4iagJPrMA=; b=QQ/1BNE0rTNHwO1g9fclpzKrEaMgACwlwKws0OTO2TgTppRWhK8lH++Qb0SyYocNQW lalbwlEmDgCuv4NlAE4c1rwgiOcPaoUVzIE0FIpQLTTbhHLAMjDk3hrYqDrUDv/h4g0d Qod+rBNeblnxXYXBf0z51iQuhdctiMYMMXUf4VBkRyN0JgP2W1K/iuzFsDbShUMqpACZ 3HSSrQasQDdDqXTh474sMtW4qeAdV5IVyvOS+McOJi//ZacUmycd67LcXcUJjJbJW7ZJ LGd/NlzjSOHQjeb3k+YtDFDZUeB3KwkKhwKO9uznN6G2QjsYDE11upSkSQ721YOBFClL yXkw== X-Forwarded-Encrypted: i=1; AJvYcCUhKp00fseS0jxQlc86jSss13Gi0jhLH2VCueUapzsT4bxfQH+P/oXmj8MmrR35q51wlS2GsFEOlOB+H94=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+NOyw83h3ZvcMNL2lM54ZL+R2pYl/CWzk4JVTZNR8lcvyOQBZ WPb+3Z479i2YO3Kn7uoU3aTwW+6c17EoV46FjULyN/l43ZcNTDFxDory7nYShkOgjrQ= X-Gm-Gg: AY/fxX5dZOXWhC9TbFt/GsSJQ+4qGxU8CANowTgTAtX/s0vgIkPqHgi/1Hr21KKdm2W I1WZYDNkEF80WqdgqsDTho/rYDfEQ1+Cgqmc0P4VVKSlq7ODjmg/HVk8XM1+NXcfFodGYGYWqjm SqV45iEr9k72MxvPEwTpy2RbkFPiXwh4NHGyIgkYQsgLYUtLEnJOAGgrvsjL6WJoPhIW7fqiJ+K vC32rj4B/DsQAu3CDwnGip+ixVBn00gCwm6r5NaFf8No22BqPoUOndfiX84HiwH6CAEwgwJSHMo FUvUnpButaj4ITU74G/20yRfcLMs3BcdOkkopJNCH73ts7p8dUMXGylwg3scBrKBxbSL47xvO9g fx09FMyXZUgtDspXUFqdX7x5SUr+QKw999EChzqQc3TK35TWPKCl+A/hFzDMJKYJtOmP2lTbqHg VVdYl9CupSOqpdAi0N X-Received: by 2002:a05:600c:c09b:b0:477:3fcf:368c with SMTP id 5b1f17b1804b1-47f428f6d40mr154922375e9.9.1768892779280; Mon, 19 Jan 2026 23:06:19 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996cf33sm28437893f8f.25.2026.01.19.23.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 23:06:18 -0800 (PST) Date: Tue, 20 Jan 2026 10:06:15 +0300 From: Dan Carpenter To: Minu Jin Cc: gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, abrahamadekunle50@gmail.com, zxcv2569763104@gmail.com, milospuric856@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix unchecked return value of skb_copy_bits Message-ID: References: <20260120025051.2843461-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260120025051.2843461-1-s9430939@naver.com> On Tue, Jan 20, 2026 at 11:50:51AM +0900, Minu Jin wrote: > diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > index 944b9c724b32..0720aa7cad62 100644 > --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > @@ -28,8 +28,10 @@ uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen) > len = rtw_remainder_len(pfile); > len = (rlen > len) ? len : rlen; > > - if (rmem) > - skb_copy_bits(pfile->pkt, pfile->buf_len - pfile->pkt_len, rmem, len); > + if (rmem) { > + if (skb_copy_bits(pfile->pkt, pfile->buf_len - pfile->pkt_len, rmem, len) != 0) > + return 0; Zero normally means success. Propagate the negative error code from skb_copy_bits(). ret = skb_copy_bits(); if (ret) return ret; I understand that this driver already does a lot of crazy stuff, but it's not a model to follow when we're writing new code. regards, dan carpenter