From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45CC83A1D02 for ; Tue, 20 Jan 2026 07:25:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768893946; cv=none; b=cPh/XkPwzmY/wuGEOGF4cJ9vHeLksQU3fv4XEFegkNcPJlLW2GcmIZdFQEaK7FpKOux1nQ3m0zFly+XIubazGeunKiGNBS3E3KcOipSGkwx/rDOSgs69S+F6KyBMk/yb+KpAaktvdBPQhbxF/W+Wgd/rc1VTywee8c5HqqyUpvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768893946; c=relaxed/simple; bh=qM2Pjww8pxRD61/kVoZb79d0u/T1AD77dPP9pHfrP6Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bgcHvF7rdT3RRVHkdlzfRDQvOrAFejRcAvv46wgIMAQS9IVu7bisyxHpeEE4M0kh3YzV39popbJg6GmiHM7MLROfoMpjWgteI08N+9anUW2QpIUqKB7fn86HvNyJkaOtKi4jrPddRbEbquX2cmENEWT19TsFCklUvR4wII4GgdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=knWxyANc; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="knWxyANc" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a35ae38bdfso55405ad.1 for ; Mon, 19 Jan 2026 23:25:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768893937; x=1769498737; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sYk5VbQOx8qeK5j+I6exldUJy66Tz0nREUA5btGygaA=; b=knWxyANclN2Wewi0b4+6hembHm/0TVZhBzpoUrFDltYODd2YhpKSD5SYklUV8jwHEW 48GAfUAvU38HlhbWoeCgskHVtB0bNl8Ptf4Hv4aoNTZdk0WLSRkRt9MuHvBvDuc/x2C+ 0ph44DVJYFW6uHzrQ5k2sN55mhCQwhYxSuc9HG5MrU9xBWtsXb/8N1gFVfftDaA1d3xY Tt8GfJHCEVhvS1siOZWQ+v+0TKonjgDNODS8wY5bj5+Q3nXIYwRO7rTZo3ZvbD8FkTh8 ZmREX1Mgy6gZ1IsKR6zmknOeyWKcs/oNSOkvPKoqn4XICNOvYTmIDb5+xFlYzDgEdxiz ojbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768893937; x=1769498737; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sYk5VbQOx8qeK5j+I6exldUJy66Tz0nREUA5btGygaA=; b=k2uTgYcpgrf3AOO9HXs0VfEmWzHupIGsuZ428pzCCzwNaZjlMJtMweFqffpJjYs/CN LiedNoH7hjDGDK3I6SmkV3eZes2zaJWyUKUUWuQJz/TtfgvMiBEIOTvgR82lxW+Poi2K U4eDRZFqqGtf7ZcAayDMAR1jgZ23g3cIsI4fOJFw2qQ22n/K2rpxmkkSVAxkXGUuw4kf X9od0bbSurZO0+Y6Hjf9ePYYdxbADqxdkP39HvRSYwRoB0rA3+RMBu5RPFTmZaqOw4Wm 7PKsL7ZqOcfaR9W+bEqhKwZ2NvSUZSXildsiHr41T/9BzSEMhZQ+GEFEYahJ+U+xNldD KIMQ== X-Forwarded-Encrypted: i=1; AJvYcCWDj3+WWSlzN4sd/PyTTOdDvO2oSQDwmzukRP6/1WXRtipdyhyuE6hlgFWwy0K81vRSZsus+oRF59puSdI=@vger.kernel.org X-Gm-Message-State: AOJu0YwAJOo49fnLK0duonT871yXJVbDFUfTNoWTy9q/zG8jSw1LqdN4 p3J0U06QiBbP+SB9lRaW9gRfxvYbqGyEC/1C0evxagTJrO63UZ+sOo/b+H40Io1scw== X-Gm-Gg: AZuq6aKrdylpGVhKnfToMk5t2B8+A/S4L/xyj/eJo5HnG4hHmbgCrlQpdDcOE/ml5Ul jYQirAkEIKRbfVT92qVHdn+S56/Q85iOZGwH2YExTx1zSUcCT2qGig7ocuHqrQWiSNIdxHsh1J+ eHpelPk75CYeQlXJcwRM1Z2vMJeF7bxuhokRXMExtwBfSYottnKFzXB/0mpZkgkf3oyN+HRMR0f Zc8W6dKkgme30/a4sKGJcvxUeuQebm1twBkDDiPdG1Ccow6cECbHOIf+J9GZkLFh73Yvi2Jqj3y 2W6rVRaEGaWqAYxvamXGmYBjgQ/XxXe54VDCLXjpyHu5u2l6PspunYGfvyxCy5vwAQlE1/0ct9G yK2LBoyOxu+uAFmBPZ49ccZN2NcvwUiFAuspPzXnAcmbh51b6blxAGVsp56pX7QcKezcpm89qqZ 8jBF0vn8EKZavhD3DVwloa2rRY8JqhNX1TPeNb9dLxZYBgDXfF X-Received: by 2002:a17:903:2289:b0:2a7:6c4e:5914 with SMTP id d9443c01a7336-2a76c4e5f06mr647805ad.6.1768893937263; Mon, 19 Jan 2026 23:25:37 -0800 (PST) Received: from google.com (222.245.187.35.bc.googleusercontent.com. [35.187.245.222]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa10c5502sm11275223b3a.24.2026.01.19.23.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 23:25:36 -0800 (PST) Date: Tue, 20 Jan 2026 07:25:31 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: will@kernel.org, jgg@nvidia.com, robin.murphy@arm.com, joro@8bytes.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH rc] iommu/arm-smmu-v3: Do not set disable_ats unless vSTE is Translate Message-ID: References: <20260115011243.1302402-1-nicolinc@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115011243.1302402-1-nicolinc@nvidia.com> On Wed, Jan 14, 2026 at 05:12:43PM -0800, Nicolin Chen wrote: > A vSTE may have three configuration types: Abort, Bypass, and Translate. > > An Abort vSTE wouldn't enable ATS, but the other two might. > > It makes sense for a Transalte vSTE to rely on the guest vSTE.EATS field. > > For a Bypass vSTE, it would end up with an S2-only physical STE, similar > to an attachment to a regular S2 domain. However, the nested case always > disables ATS following the Bypass vSTE, while the regular S2 case always > enables ATS so long as arm_smmu_ats_supported(master) == true. > > Note that ATS is needed for certain VM centric workloads and historically > non-vSMMU cases have relied on this automatic enablement. So, having the > nested case behave differently causes problems. > > To fix that, add a condition to disable_ats, so that it might enable ATS > for a Bypass vSTE, aligning with the regular S2 case. > > Fixes: f27298a82ba0 ("iommu/arm-smmu-v3: Allow ATS for IOMMU_DOMAIN_NESTED") > Cc: stable@vger.kernel.org > Suggested-by: Jason Gunthorpe > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c > index 93fdadd07431..823461a26659 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c > @@ -177,7 +177,9 @@ static int arm_smmu_attach_dev_nested(struct iommu_domain *domain, > * config bit here base this off the EATS value in the STE. If the EATS > * is set then the VM must generate ATC flushes. > */ > - state.disable_ats = !nested_domain->enable_ats; > + if (FIELD_GET(STRTAB_STE_0_CFG, le64_to_cpu(nested_domain->ste[0])) == > + STRTAB_STE_0_CFG_S1_TRANS) > + state.disable_ats = !nested_domain->enable_ats; > ret = arm_smmu_attach_prepare(&state, domain); > if (ret) { > mutex_unlock(&arm_smmu_asid_lock); This makes sense. The nested_domain->enable_ats should indeed only be checked for Translate configs. Reviewed-by: Pranjal Shrivastava Thanks, Praan