From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 084AF3D6665 for ; Tue, 20 Jan 2026 10:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768904151; cv=none; b=CPix69wX1idqv+S4tRzRyzPmZTBcqsDAnkL1fMXvo0CU7Wv1AWzk4TPZYiSBygP0C3c5GzfvlfmdMEYpYsjy6eQuKbI/goeW/U7qZKMpbixhZaQUq8qdHSQozuiYQmWwc+jEpG1BnfIesAF8NWWil9vt1jhEfV5YHqIm0NzT0XA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768904151; c=relaxed/simple; bh=DxLJ6APSej3JnTxJKVN3TakJFVH/e+dw1Ul5GgybkdQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=taR0JhP3ZVChsiJti8AJcZfztD1kHQ3K/SgfNi0afWx/QgZlc1KK0x9Xc6I8vMesrfOIVAuuV84hdZnVb7MDd8AjN9NLlXlR1f/nooMlR7rEGQQQ6b1ZegvW7FoylC6WsNiT9VFS1uM6ipfSdpvAbVo1PMFWzZ0DbprfEQ0mU1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GtlKPQAf; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GtlKPQAf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768904148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DaphwKTr6kruAM6Ca6z24D6/blOeNF2NHw7uL9x+gGQ=; b=GtlKPQAfm7a8g/SEweyPX2JtjVLqUJZDAoBSpEJlN252AO6ruajc7VelG067yvb2zsVcOv Qx+KS4loZ46V33kDut9LSHOpzgpUrzLQGk0XcaaAy/ZvNaasXEAcpSUMC4cbAAkgLGnJr4 r9QYBPUoSmfN9hHudwu8M6JgnqwOTYg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-XPoEYggVOSeMcVKFq0boNA-1; Tue, 20 Jan 2026 05:15:41 -0500 X-MC-Unique: XPoEYggVOSeMcVKFq0boNA-1 X-Mimecast-MFC-AGG-ID: XPoEYggVOSeMcVKFq0boNA_1768904140 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 414C01954B0B; Tue, 20 Jan 2026 10:15:39 +0000 (UTC) Received: from localhost (unknown [10.72.112.122]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 45B4B19560A2; Tue, 20 Jan 2026 10:15:36 +0000 (UTC) Date: Tue, 20 Jan 2026 18:15:33 +0800 From: Baoquan He To: Andrew Morton , Qiang Ma Cc: catalin.marinas@arm.com, will@kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] kexec: add kexec flag to control debug printing Message-ID: References: <20251219093134.2268620-1-maqianga@uniontech.com> <20260119154947.e351bfb8e97d91305932e2eb@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260119154947.e351bfb8e97d91305932e2eb@linux-foundation.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 01/19/26 at 03:49pm, Andrew Morton wrote: > On Fri, 19 Dec 2025 17:31:30 +0800 Qiang Ma wrote: > > > The commit cbc2fe9d9cb2 ("kexec_file: add kexec_file flag to control > > debug printing") added the kexec_file flag to control debug printing. > > However, for arm64, after commit 6f8c1da071a4 ("kexec_file, arm64: print > > out debugging message if required"), when using the kexec_load interface, > > the kexec_image_info function is called to print debug message, but > > it uses kexec_dprintk, which is only available under kexec_file, > > then when specifying 'kexec -d', kexec_load interface will print nothing. > > > > For riscv, commit eb7622d908a09 ("kexec_file, riscv: print out debugging > > message if required") remove kexec_image_info(), because the content has > > been printed out in generic code in kexec_file_load, but not in kexec_load. > > > > Therefore, in order to solve the two problems mentioned above, for this > > patchset, several things need to be done: > > > > 1. Enabling kexec_dprintk is available for kexec_load. > > 2. Add some debugging message of the deleted kexec_image_info > > to generic code. > > 3. Remove duplicate debugging prints for arm64. > > Some additional review input on this series would be good, if someone > has the time. As I have said before, I am not fan of this patchset becuase I think it's not necessary, even though it has no much harm except of adding code. Leave this to those who like it.