From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDDC642315F for ; Tue, 20 Jan 2026 11:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768909048; cv=none; b=YIwJwGvxvBRVekocoW13jkUVLknMLLNw0ug2rHKQ2qgy6ffx9t48PqHXqNTLUs2BZk0iwVYGh8ukUavJrJEWKWypvBzwIFJ0cITmUAUlH9b/VOlPyhf+qBFI0AqTRHpP6Oh0nb9azNeiRuQZfJT/GOTZjveZipcl6MKOcnTtP0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768909048; c=relaxed/simple; bh=rEZf/1Sg4LXN0exmaMPQLqDFKOXXdr/Yxg1dey9pOTA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qW1I0mtmPcj7e/YeiCHfr/dA9qmRueIMsPcTIgxAJwaL+q6tjLJ0Dw+GPDLxmgAt0MDDAcK6alG4oEOYLb/KA3QPLcZ4Ybo93HdC6NpHWiY4WeYbOpupM/wiBfFHsw8hX4iSjyhonTB8iuF7k7v2Ba6nRZx4woRP9PqUxBYzNZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7d122733808so1029696a34.2 for ; Tue, 20 Jan 2026 03:37:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768909046; x=1769513846; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LSmHYeXBvlEb7OLSe8G59RYQyhINnpjWVcu9COHnqJY=; b=HckTaIBNKpk5tL6QW7EYn77NQcfMAD3pYdk6wP81THIZvCcmZvpeAyLlhao+nclJA6 +dfRMw5djVcOtshXpJJkImWvNeRUQ/FPDllxCQs5HIL3yGMV3BDn8izBN4jZpyWCQLeU njKjm7RNuK5qVBr3UFBtPogUtv3bgX5lkUhfaOUAKb8kRonVxXsS+G3eLb76ZPkYjjtI TcJnU4rcu5jSWL1q2XOBoPFoiMnAmgLyGUFujASRG80k5NhFRJYbz2WJP3V3ieu0irfE JEkIFoQAU797m9KU3U7AdpFVBK3zOYdT5crzwa+oGDTtJ2aysgcEoISsSbBjss1ggBhE +KEQ== X-Forwarded-Encrypted: i=1; AJvYcCXNY+Vw+OGnXMLG07zIWlFLeaP4Rrttf5xorOgeSLKjwG+lKXbSQgrTxIX8ZT1P/LfVH4Jpa1AMX1dz6/4=@vger.kernel.org X-Gm-Message-State: AOJu0YxjMBuLqDhZ1t63QQj8tiqhyZbFiIWJ4Tl1zSx7eR1nTG9qRENb UoogD6PulUEz/wlgX2NZJ5DW61QDd8WoUW/MfvZgt4M80f0b5Jn4jnM6 X-Gm-Gg: AY/fxX6QH2crY+wl5q/0fYOlDVdtMobxmrEIXoK3HCLTOr4V0OR6Y/AyfjZYnywMU1n ZffvKUMsCszO+VjrBbeTejpN2K9UcgpSpPe0KrQa630xWHsPKtSBP8ipFPs3/kbIP8Yc0jb1E2z WUxUjlXEWEga5CU/cZIBfvXKsn+ckB71jRzkXUqER6B6PYllS/+qtN4E5gCRd8MXNtOVS9Mh5Bl aoihfQNivUhPHKCKqH/Ahk1A5ieuDMTVvF1oBLf7auzIxQrhRmDXsUDJKpz7IWNE/fhGtc3nY64 FSSYBEvnMuWRA+bt6vbqCpwNqJvccOm/LZR3T4nvI7It5RN6d13YzGGvvRT+xaEJPDgLRTIOqyb 04yYFEyIkot2D/h3aWn9MGTYZz6D6XFUJ7MGquvqa9tuHTpUxHi3ed+9MA4WFV952kLDx+0LnHQ iI X-Received: by 2002:a05:6830:378a:b0:7cf:d9ba:c9a6 with SMTP id 46e09a7af769-7cfdfd7a1a1mr6528097a34.0.1768909045718; Tue, 20 Jan 2026 03:37:25 -0800 (PST) Received: from gmail.com ([2a03:2880:10ff:7::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cfdf0db2ddsm8381109a34.3.2026.01.20.03.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 03:37:25 -0800 (PST) Date: Tue, 20 Jan 2026 03:37:22 -0800 From: Breno Leitao To: Andre Carvalho Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v11 6/7] netconsole: resume previously deactivated target Message-ID: References: <20260118-netcons-retrigger-v11-0-4de36aebcf48@gmail.com> <20260118-netcons-retrigger-v11-6-4de36aebcf48@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260118-netcons-retrigger-v11-6-4de36aebcf48@gmail.com> On Sun, Jan 18, 2026 at 11:00:26AM +0000, Andre Carvalho wrote: > Attempt to resume a previously deactivated target when the associated > interface comes back (NETDEV_REGISTER) or when it changes name > (NETDEV_CHANGENAME) by calling netpoll_setup on the device. > > Depending on how the target was setup (by mac or interface name), the > corresponding field is compared with the device being brought up. Targets > that match the incoming device, are scheduled for resume on a workqueue. > > Resuming happens on a workqueue as we can't execute netpoll_setup in the > context of the netdev event. A standalone workqueue (as opposed to the > global one) is used to allow for proper cleanup process during > netconsole module cleanup as we need to be able to flush all pending > work before traversing the target list given that targets are temporarily > removed from the list during resume_target. > > Target transitions to STATE_DISABLED in case of failures resuming it to > avoid retrying the same target indefinitely. > > Signed-off-by: Andre Carvalho Reviewed-by: Breno Leitao