From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86D3832D0FA for ; Thu, 8 Jan 2026 19:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767902252; cv=none; b=cIsVAv/SVCaW7ZiUK9YE3eBIoXcZYtS1S0vovc4GxeCMkwEQKdSLF8Q9DcexpYJDr+LgQYgNypT4idOc1hnZ2bSiKlQb/ddRlkskaaFJKgyBFPGhjBPwVtQw1fWzIrLB4A7JEDGtxBAdZRzdFefqCwzD45FKtmDR+z/hV4EsGg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767902252; c=relaxed/simple; bh=c7jMhN8XtvfpyVorUkznyAzrFKyWQ17Srg5BEIXNWfk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Eozq4FHOnxIkB3SqsLzz7AqEUSD0pfIt+QaL9pjJQyMRrK1gjL0Y23SLrwBi+C3r/W2QWGjKNJK5y+NdJZT/bbN/r3iL1gHfOGJbcTSj5LkKVFGKnA4V6oweUrSElbBDubm0KA61m9MRLcKtZN+Qg/U4nsKz5QmEAkjaBlg6UXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xsYvxyEb; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xsYvxyEb" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-4327555464cso2064386f8f.1 for ; Thu, 08 Jan 2026 11:57:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767902247; x=1768507047; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=QCRWVLE8KYqwVCUSR+leEM1QO2iDsc6SFUmiGPEHzWo=; b=xsYvxyEbzVUkGTzlfYVMFJ/vUAuvbRawquZVff+08OVYyYuDMQ7g9Dsvqk4e4UcL7K ASESN3IWIMURW7YlXIbUKNH9gzZ8KUFTs9NT6ecvcOJfqKUH8lGn0OhQqGyWUNjTF1bd daicfrBQPuVIWjCZAMB/1YA0O/BmKL7dEC0cF5lDabJaRIRyF5yE+5llXTiRAvaw0yOs DABOchO0eGNgeVHEBLWR1korUzpoG6ydFtLm4XDbbmcHudX/P2Ij2Few21Ws5D2J+qOd 9/krazfEPNn3r76DDN5RXT43hy7jty6KwzaM6DpWAoWr5+QgaSWgMp0vYwn+QBlHJD9d Pm6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767902247; x=1768507047; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QCRWVLE8KYqwVCUSR+leEM1QO2iDsc6SFUmiGPEHzWo=; b=naiRlY37BuxbZMl8C+lfPQhbVneJJ1kcM17QXw526ttnlET3+Vu5URZZbSdH1cwc77 VuWVAL46DrEK6h7GnbbWAx8TA1vAued2UTuy6D7WHMayTBwT3Xv4bQH2HAbo6MTAkviU c9WITkILk/SaO3stc7vunDC8d1wauyKTX2ggf0y/Q4JDkNqYVHLXmiubsXVUV0jvVf3Q VsY1AY8umHY6OMX8OHwyDZpPbyW48OxWnHqfd1jYY7UFNVp56yQf1BY9Yb2YRVar5x1u e+PV5FbUIte5cZI1qjy1pwG14lWU0jOstd0Eze26d3WKw7Zb+PUjLI9cea2pPoBPdfZO 0JZA== X-Forwarded-Encrypted: i=1; AJvYcCW519WCjdSqdSLloqAfLRDlIoJtQouA6WgkT2ktww4qwuNRavm2alWHMJHdCyNAC1pd/MJ3zEPcrfVHIvU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw48spmIPiUlSLe7sP5jYZfbJ+UVxJhIG9CelW6B3R3I6Z3r0h8 cpN2S+ngWbSkFSQ4lCwQUsm7OMZApaz8pX6pAPMb4Bf0w4KdPFysOtr0fQbb5yZOwZY= X-Gm-Gg: AY/fxX6r9un3gfLKJiajgccx4QXyBWnKQKxHNrY7V5zkPfSKVrcNSX2Ybv5wlbP5Jt0 Z+L01fYgy1gYKSCHfRqdqtsC138832hAoQ5aL1sxLTqawGz1QFRGCx56eaaX6K/RcUqkL5ieULJ 6gWeWb+VWrwvQZzHfGFT6IRyc3lVqFk7wx6VT737wVx7+LeTGjFT7BNtVgllnmcNV+yizdEtYy3 OhcVZH0tPFaKmIT+JHmOBdgm9kNm5GdAhrqEJPvRsZdujf4n3wtiDQp1k5AUIBV+fnGDxE7dVDa 9YiMeN5VYFlkpUtey7svwgsetnZPG/xvT4JGY+DUS55yF1MyD5LtLTYGm/65K+VKx3jomtfWO0d Mn6hUuWIuz/5gVZo6g0jMFYoO7k1bleWG1sJ/YzHJaRHe4mcxra3BDF1vcieUVHdBoEf8c9auIo eiSvHMyX+oZd8gIC+c X-Google-Smtp-Source: AGHT+IFcp3VtHt/q/Alt1immzh6zHpZoD2LnzhIVd+S2uek5Z3OEZpx2nKLWt2bXAXJEShIrU12xOw== X-Received: by 2002:a05:6000:24c6:b0:430:f742:fbb4 with SMTP id ffacd0b85a97d-432c37a4f66mr8711115f8f.43.1767902246566; Thu, 08 Jan 2026 11:57:26 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df91fsm18529516f8f.23.2026.01.08.11.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 11:57:26 -0800 (PST) Date: Thu, 8 Jan 2026 22:57:22 +0300 From: Dan Carpenter To: Rob Clark Cc: Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/msm: remove some dead code Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding This is supposed to test for integer overflow but it is wrong and unnecessary. The size_add()/mul() macros return SIZE_MAX when there is an integer overflow. This code saves the SIZE_MAX to a u64 and then tests if the result is greater than SIZE_MAX which it never will be. Fortunately, when we try to allocate SIZE_MAX bytes the allocation will fail. We even pass __GFP_NOWARN so the allocation fails harmlessly and quietly. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/msm/msm_gem_vma.c | 8 +------- 1 file changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c index 71d5238437eb..7968c2dccff0 100644 --- a/drivers/gpu/drm/msm/msm_gem_vma.c +++ b/drivers/gpu/drm/msm/msm_gem_vma.c @@ -947,15 +947,9 @@ vm_bind_job_create(struct drm_device *dev, struct drm_file *file, struct msm_gpu_submitqueue *queue, uint32_t nr_ops) { struct msm_vm_bind_job *job; - uint64_t sz; int ret; - sz = struct_size(job, ops, nr_ops); - - if (sz > SIZE_MAX) - return ERR_PTR(-ENOMEM); - - job = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN); + job = kzalloc(struct_size(job, ops, nr_ops), GFP_KERNEL | __GFP_NOWARN); if (!job) return ERR_PTR(-ENOMEM); -- 2.51.0