* [PATCH] drm/xe: Add missing newlines to drm_warn messages
@ 2025-12-24 21:21 Osama Abdelkader
2026-01-08 21:17 ` Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: Osama Abdelkader @ 2025-12-24 21:21 UTC (permalink / raw)
To: Lucas De Marchi, Thomas Hellström, Rodrigo Vivi,
David Airlie, Simona Vetter, intel-xe, dri-devel, linux-kernel
Cc: Osama Abdelkader
The drm_warn() calls in the default cases of various switch statements
in xe_vm.c were missing trailing newlines, which can cause log messages
to be concatenated with subsequent output. Add '\n' to all affected
messages.
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
drivers/gpu/drm/xe/xe_vm.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 79ab6c512d3e..1349dbc6f0ab 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -2187,7 +2187,7 @@ static void print_op(struct xe_device *xe, struct drm_gpuva_op *op)
(ULL)xe_vma_start(vma), (ULL)xe_vma_size(vma));
break;
default:
- drm_warn(&xe->drm, "NOT POSSIBLE");
+ drm_warn(&xe->drm, "NOT POSSIBLE\n");
}
}
#else
@@ -2283,7 +2283,7 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
xe_bo_unlock(bo);
break;
default:
- drm_warn(&vm->xe->drm, "NOT POSSIBLE");
+ drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
ops = ERR_PTR(-EINVAL);
}
if (IS_ERR(ops))
@@ -2552,7 +2552,7 @@ static int xe_vma_op_commit(struct xe_vm *vm, struct xe_vma_op *op)
op->flags |= XE_VMA_OP_COMMITTED;
break;
default:
- drm_warn(&vm->xe->drm, "NOT POSSIBLE");
+ drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
}
return err;
@@ -2750,7 +2750,7 @@ static int vm_bind_ioctl_ops_parse(struct xe_vm *vm, struct drm_gpuva_ops *ops,
break;
default:
- drm_warn(&vm->xe->drm, "NOT POSSIBLE");
+ drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
}
err = xe_vma_op_commit(vm, op);
@@ -2812,7 +2812,7 @@ static void xe_vma_op_unwind(struct xe_vm *vm, struct xe_vma_op *op,
/* Nothing to do */
break;
default:
- drm_warn(&vm->xe->drm, "NOT POSSIBLE");
+ drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
}
}
@@ -2989,7 +2989,7 @@ static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm,
break;
}
default:
- drm_warn(&vm->xe->drm, "NOT POSSIBLE");
+ drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
}
return err;
@@ -3228,7 +3228,7 @@ static void op_add_ufence(struct xe_vm *vm, struct xe_vma_op *op,
vma_add_ufence(gpuva_to_vma(op->base.prefetch.va), ufence);
break;
default:
- drm_warn(&vm->xe->drm, "NOT POSSIBLE");
+ drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
}
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/xe: Add missing newlines to drm_warn messages
2025-12-24 21:21 [PATCH] drm/xe: Add missing newlines to drm_warn messages Osama Abdelkader
@ 2026-01-08 21:17 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2026-01-08 21:17 UTC (permalink / raw)
To: Osama Abdelkader
Cc: Lucas De Marchi, Thomas Hellström, David Airlie,
Simona Vetter, intel-xe, dri-devel, linux-kernel
On Wed, Dec 24, 2025 at 10:21:16PM +0100, Osama Abdelkader wrote:
> The drm_warn() calls in the default cases of various switch statements
> in xe_vm.c were missing trailing newlines, which can cause log messages
> to be concatenated with subsequent output. Add '\n' to all affected
> messages.
As the lines state, not possible... but well, if the messages exist,
let's ensure that if that end up happening it doesn't get concatenated.
pushed to drm-xe-next. Thanks for the patch.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 79ab6c512d3e..1349dbc6f0ab 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2187,7 +2187,7 @@ static void print_op(struct xe_device *xe, struct drm_gpuva_op *op)
> (ULL)xe_vma_start(vma), (ULL)xe_vma_size(vma));
> break;
> default:
> - drm_warn(&xe->drm, "NOT POSSIBLE");
> + drm_warn(&xe->drm, "NOT POSSIBLE\n");
> }
> }
> #else
> @@ -2283,7 +2283,7 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
> xe_bo_unlock(bo);
> break;
> default:
> - drm_warn(&vm->xe->drm, "NOT POSSIBLE");
> + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
> ops = ERR_PTR(-EINVAL);
> }
> if (IS_ERR(ops))
> @@ -2552,7 +2552,7 @@ static int xe_vma_op_commit(struct xe_vm *vm, struct xe_vma_op *op)
> op->flags |= XE_VMA_OP_COMMITTED;
> break;
> default:
> - drm_warn(&vm->xe->drm, "NOT POSSIBLE");
> + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
> }
>
> return err;
> @@ -2750,7 +2750,7 @@ static int vm_bind_ioctl_ops_parse(struct xe_vm *vm, struct drm_gpuva_ops *ops,
>
> break;
> default:
> - drm_warn(&vm->xe->drm, "NOT POSSIBLE");
> + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
> }
>
> err = xe_vma_op_commit(vm, op);
> @@ -2812,7 +2812,7 @@ static void xe_vma_op_unwind(struct xe_vm *vm, struct xe_vma_op *op,
> /* Nothing to do */
> break;
> default:
> - drm_warn(&vm->xe->drm, "NOT POSSIBLE");
> + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
> }
> }
>
> @@ -2989,7 +2989,7 @@ static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm,
> break;
> }
> default:
> - drm_warn(&vm->xe->drm, "NOT POSSIBLE");
> + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
> }
>
> return err;
> @@ -3228,7 +3228,7 @@ static void op_add_ufence(struct xe_vm *vm, struct xe_vma_op *op,
> vma_add_ufence(gpuva_to_vma(op->base.prefetch.va), ufence);
> break;
> default:
> - drm_warn(&vm->xe->drm, "NOT POSSIBLE");
> + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");
> }
> }
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-08 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-24 21:21 [PATCH] drm/xe: Add missing newlines to drm_warn messages Osama Abdelkader
2026-01-08 21:17 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox