From: Alice Ryhl <aliceryhl@google.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Christian Brauner" <brauner@kernel.org>,
"Carlos Llamas" <cmllamas@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binder: don't use %pK through printk
Date: Fri, 9 Jan 2026 08:22:30 +0000 [thread overview]
Message-ID: <aWC6xu5px9MbTqS7@google.com> (raw)
In-Reply-To: <20260107-restricted-pointers-binder-v1-1-181018bf3812@linutronix.de>
On Wed, Jan 07, 2026 at 03:29:50PM +0100, Thomas Weißschuh wrote:
> In the past %pK was preferable to %p as it would not leak raw pointer
> values into the kernel log. Since commit ad67b74d2469 ("printk: hash
> addresses printed with %p") the regular %p has been improved to avoid
> this issue. Furthermore, restricted pointers ("%pK") were never meant
> to be used through printk(). They can still unintentionally leak raw
> pointers or acquire sleeping locks in atomic contexts.
>
> Switch to the regular pointer formatting which is safer and
> easier to reason about.
>
> There are still a few users of %pK left, but these use it through
> seq_file, for which its usage is safe.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
prev parent reply other threads:[~2026-01-09 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 14:29 [PATCH] binder: don't use %pK through printk Thomas Weißschuh
2026-01-08 21:45 ` Carlos Llamas
2026-01-09 8:22 ` Alice Ryhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWC6xu5px9MbTqS7@google.com \
--to=aliceryhl@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox