From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED64287257 for ; Fri, 9 Jan 2026 06:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767939237; cv=none; b=Tfk3rMsDmiiEhW9zHf3O4Yi5B6WcFm/a0dpoCTvvwXlQNLUq7lkkugmaDj2eN8TKiS3xlKitggA8Q5sYPN15FDBqW2acHw61VGTuAg4fT93eMSsvA0UFQLV6i/7erPrEogrt7LO26V2Bo/pQ+iB6DTcJ18PNwJ2jQ6MEu+MNavc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767939237; c=relaxed/simple; bh=/zWpOYdNbhQSA1af4BEj4qX4xj2WrrLGGa8eMj8aPvo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dDutqndCbfEPlNRQg4oOe2cWvBuwKYESuV2QLdGa8jWAboN9H3B6/0DHYKJcBaSPEESDyvkZZrJy5vTgHX2jYlilLTXVXh7Rc0hGdaCxQCKD/HACfNwZAQm0nOwoCkDyL4vqykW6E9nL+tSmM8KRrMN14oWNmeGfaxyjS8szJN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Bp1uV87X; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Bp1uV87X" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a35ae38bdfso33735ad.1 for ; Thu, 08 Jan 2026 22:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767939235; x=1768544035; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Nys0Vr5kzC40Tsia9AyrmiWODO98psXZK0lJxHgb7BQ=; b=Bp1uV87XdO3kgoa4P9VLB3YaAM4/vGOPDZXbDQ1bU4iuXDTH1pXEX4rLfCVLKHn2Ms /GF4DuPH6dbQNLVEGnpcyxfz+gVf/mOWG/HF4xdw3h6wy6Xju9CtInlhMkw5TrFOpx46 l8zZAlRIP45pysTdBpnNo6j3S8wJ8l/p82vuYzaFXZCuRY99c4O/M4S+M5yiy5SIkcQO 3YvTGtRKSG2lqP78u44C+kL2MFZ0Qsyj9R19Lqgxgt+vnILq9S2Qdx8/j3nxaJNaxH4k 1jr2JyOHxAt2ieAAQGlJV33SdnMcbD5egB2Q9r1BJn+/huos//9yhrulr+szIF6gUjST ITqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767939235; x=1768544035; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nys0Vr5kzC40Tsia9AyrmiWODO98psXZK0lJxHgb7BQ=; b=slFMgrftOU+Mz/KuTcbV3pCJvW5g3Sa2HnckgXCrPCSn2SLIr7QuvxZ6t8EXuE5ZPO nE+mK61okvBNwHzBWJsodi9FJ6jcJwYXpOmCjGCEjvwumrj+UvXk+ogE6wRMhwF9DtWK CJXauqyX802m7aIOTZu2gBdep1wG6kHT3KbidXIe0nS5fy0aSPiPr9WMjmb0dlxS8maX lvRV9KkQOtlMGZAnjD/iam8psbGzcr1QXPeSDi0HZBNlGrzaAdFzcqfL+tAUBw8TF4qA 93igJZu//VmSPkT/Dz3dieYc+B17ivnBe0Y7hGYgMhlA38+cYKcDZFZyyp/wQnpie0M2 ekbw== X-Forwarded-Encrypted: i=1; AJvYcCWVO3osS5Ik1iJRi7CKMmIaq0sdv1afS1LdmUElhHbP3/fjP365pHWXX9TGVHadCW4VCQ4CpZtc5+4tb9w=@vger.kernel.org X-Gm-Message-State: AOJu0YzV4BG0pL9FDkvTpCnCkc5t00N74JUKm5haOLxjSbFplYo+Imkr oLdgy1v9irPkSQmg5aUdg7oLDwJx1/TRp6e1yQrOUSOPwyJ3KzBtjmT5hRgevfKtDQ== X-Gm-Gg: AY/fxX4RtNUQq8BAXkheM4Xh6AGKIetBiTlIaJ6f9PevG8yiZE3Nf58Vy8L58RSW2qs WRkcnNtIxVPH2EnO2Yq0q0usQgt1KchqVoQ/NzjLN4JS4h8eazCPdVRUbLK+M81pALpKyE/IHyN /g76t+JKnHK6U4nKOAlzv0UgZpPXbbO3LAcfgcAT2Lvxh9ACaZ+GwtxdS4YqJ7R9hcWlHYnWKiX ZsuIokm41TXUG92qTMMB7D6sstELE3v9M/1HYFVyWf4RyANRXtCgPobz8Ds4ccx9zjx0gB7egtt sewXAiN8bLR+4pBFeRkytDr3dRlcTE+aTh3+2KcylU39FBmuHRG3ndKtorDGc1lCslSn0NY4q8B ZOCt8aPCqxF8XYneDFCJ476yeeL8VpOsoJCKBn8hNYLM/exW7NzE6wtZ28fnIoWNn9lqiNO0r5i fghmeyO9IgQ8Le/xLDjtFW2l3Qzv36QsL+SeslZcjmtlwMtaLEoIPG X-Received: by 2002:a17:902:f786:b0:294:d42c:ca0f with SMTP id d9443c01a7336-2a409a4dc29mr2088965ad.2.1767939234904; Thu, 08 Jan 2026 22:13:54 -0800 (PST) Received: from google.com (248.132.125.34.bc.googleusercontent.com. [34.125.132.248]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2c5bsm96212385ad.58.2026.01.08.22.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 22:13:54 -0800 (PST) Date: Fri, 9 Jan 2026 06:13:49 +0000 From: Bing Jiao To: linux-mm@kvack.org Cc: Andrew Morton , Axel Rasmussen , Yuanchu Xie , Wei Xu , Johannes Weiner , David Hildenbrand , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mm/vmscan: fix uninitialized variable in demote_folio_list() Message-ID: References: <20260109055937.3739860-1-bingjiao@google.com> <20260109060622.3742262-1-bingjiao@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260109060622.3742262-1-bingjiao@google.com> On Fri, Jan 09, 2026 at 06:06:21AM +0000, Bing Jiao wrote: > Commit d92027a5f30a6c ("mm/vmscan: select the closest preferred node in > demote_folio_list()") refactored the selection logic for demotion target > nodes. However, it removed the initial assignment of 'target_nid' while > leaving a premature check for 'NUMA_NO_NODE' in place. > > Since 'target_nid' is now assigned further down in the function based on > preferred and allowed node masks, the initial check at line 1046 is > redundant. > > Remove the redundant check to resolve the compiler warning. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202601091037.vUSHeJCH-lkp@intel.com/ > Fixes: d92027a5f30a6c ("mm/vmscan: select the closest preferred node in demote_folio_list()") > Signed-off-by: Bing Jiao > --- > mm/vmscan.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 213ee75b3306..590ab3ec1998 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1044,10 +1044,6 @@ static unsigned int demote_folio_list(struct list_head *demote_folios, > if (list_empty(demote_folios)) > return 0; > > - if (target_nid == NUMA_NO_NODE) > - /* No lower-tier nodes or nodes were hot-unplugged. */ > - return 0; > - > node_get_allowed_targets(pgdat, &allowed_mask); > mem_cgroup_node_filter_allowed(memcg, &allowed_mask); > if (nodes_empty(allowed_mask)) > -- Hi Andrew, Sorry for bother you again in my patch series. The fix is a simple removal of a redundant, premature check that was using 'target_nid' before its new initialization point, which is reported by the kernel test. I am not sure whether it is a good idead to send a standalone patch to fix it. Maybe it is likely easier to process. However, if you would like replace the series Commit d92027a5f30a6c ("mm/vmscan: select the closest preferred node in demote_folio_list()") entirely to keep the versioning consistent, I can send an v8 version. Thanks for your time on this patch series. Best regards, Bing Jiao