From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDDA13596FB for ; Fri, 9 Jan 2026 09:36:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.248.80.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767951412; cv=none; b=HwPuQrmNw441vJwDKjnIjyPH2kDJ3j7G7Yc3m0xfbVpxV/vu+H69RZsc+qkQJyB1ywwczPkFFSVNOaHwnDeUkiSQN8rySb64vpbdjWowORR0v4BDvT/W/Df/dei9e1Ef4XWSi11WVOTb1QikdTPVY9SFunPElfOtOYgQe4h/4Xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767951412; c=relaxed/simple; bh=qf0Ay49SUWNcpfPLtH9KOhfJ3qPKHVC59ZmhW095Oos=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k6GCeBCc948Tdf+E1G4UFX6CtLlQ3kK03LUeIT+W9gGhKrRF3+JNG63PeG7vMK8+NdI/hZ4vtYum2HreolwB6JD4V9atd/uBkyhAKXWacr6vOHbMA/LlCxmqaU07M8XuzkjyTSXRyl1qXTLLzJAaqFwTC3F9kplJ9JgPEEPZCLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com; spf=pass smtp.mailfrom=andestech.com; arc=none smtp.client-ip=60.248.80.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=andestech.com Received: from mail.andestech.com (ATCPCS34.andestech.com [10.0.1.134]) by Atcsqr.andestech.com with ESMTPS id 6099a3IQ031860 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Fri, 9 Jan 2026 17:36:03 +0800 (+08) (envelope-from cl634@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS34.andestech.com (10.0.1.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 9 Jan 2026 17:36:03 +0800 Date: Fri, 9 Jan 2026 17:35:58 +0800 From: CL Wang To: Krzysztof Kozlowski CC: , , , , , , , , , Subject: Re: [PATCH 1/3] dt-bindings: watchdog: Add support for Andes ATCWDT200 Message-ID: References: <20260107145058.213334-1-cl634@andestech.com> <20260107145058.213334-2-cl634@andestech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-ClientProxiedBy: ATCPCS33.andestech.com (10.0.1.100) To ATCPCS34.andestech.com (10.0.1.134) X-DKIM-Results: atcpcs34.andestech.com; dkim=none; X-DNSRBL: X-SPAM-SOURCE-CHECK: pass X-MAIL:Atcsqr.andestech.com 6099a3IQ031860 Hi Krzysztof, Thanks for your review. On 07/01/2026 15:50, Krzysztof Kozlowski wrote: > Last part is redundant. Can you add a binding without supported properties and without usage examples? Agreed. I will remove the redundant part "including supported properties and usage examples" in the commit message in the next version. > Subject says WDT200, this code sais 350 and qilai. What is what? You have entire commit msg to explain that I will clarify in the commit message that ATCWDT200 is the IP name, which is embedded in AndesCore-based platforms or SoCs such as AE350 and Qilai. > No clue what's this, but for sure does not pass tests without description and type. You are right, I missed the type definition. I will add the description and set the type to uint32 (enum [0, 1]) for `andestech,clock-source`. Best regards, CL Wang