From: Andrea Righi <arighi@nvidia.com>
To: George Guo <dongtai.guo@linux.dev>
Cc: changwoo@igalia.com, etsal@meta.com, guodongtai@kylinos.cn,
linux-kernel@vger.kernel.org, sched-ext@lists.linux.dev,
tj@kernel.org, void@manifault.com
Subject: Re: [PATCH v2 1/1] sched_ext: Add error logging for dsq creation failures
Date: Fri, 9 Jan 2026 12:07:55 +0100 [thread overview]
Message-ID: <aWDhi0l1mHxjCg-H@gpd4> (raw)
In-Reply-To: <20260109103916.93454-1-dongtai.guo@linux.dev>
On Fri, Jan 09, 2026 at 06:39:16PM +0800, George Guo wrote:
> > Huh? No, we already get an error message both in dmesg and in stdout when
> > scx_bpf_create_dsq() fails, so I don't think this is required.
> >
> > Are you sure you were not hitting other issues when your scheduler failed
> > to load silently?
>
>
> Hi Andrea,
> Here take an instance.
> You need add bpf_printk in BPF_STRUCT_OPS_SLEEPABLE(central_init),
> even with dmesg when central_init fails, as central_init have multiply
> error return.
Ok, then maybe we can add a bit more information to the error message,
printing which DSQ failed to be created, for example:
scx_bpf_error("failed to create DSQ %d (%d)", SHARED_DSQ, ret);
This would be more helpful I think.
Thanks,
-Andrea
prev parent reply other threads:[~2026-01-09 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 10:03 [PATCH v2 1/1] sched_ext: Add error logging for dsq creation failures George Guo
2026-01-09 10:11 ` Andrea Righi
2026-01-09 10:39 ` George Guo
2026-01-09 11:07 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWDhi0l1mHxjCg-H@gpd4 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=dongtai.guo@linux.dev \
--cc=etsal@meta.com \
--cc=guodongtai@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox