public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>,
	James.Bottomley@hansenpartnership.com, leonro@nvidia.com,
	kch@nvidia.com, LKML <linux-kernel@vger.kernel.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	riteshh@linux.ibm.com, ojaswin@linux.ibm.com
Subject: Re: [next-20260108]kernel BUG at drivers/scsi/scsi_lib.c:1173!
Date: Fri, 9 Jan 2026 19:55:16 +0800	[thread overview]
Message-ID: <aWDspG-J1a3iyIqG@fedora> (raw)
In-Reply-To: <7382f235-3e42-4b77-b18d-c38661816301@linux.ibm.com>

On Fri, Jan 09, 2026 at 05:14:36PM +0530, Venkat Rao Bagalkote wrote:
> 
> On 09/01/26 12:19 pm, Ming Lei wrote:
> > On Thu, Jan 08, 2026 at 09:56:39PM -0800, Christoph Hellwig wrote:
> > > I've seen the same when running xfstests on xfs, and bisected it to:
> > > 
> > > commit ee623c892aa59003fca173de0041abc2ccc2c72d
> > > Author: Ming Lei <ming.lei@redhat.com>
> > > Date:   Wed Dec 31 11:00:55 2025 +0800
> > > 
> > >      block: use bvec iterator helper for bio_may_need_split()
> > > 
> > Hi Christoph and Venkat Rao Bagalkote,
> > 
> > Unfortunately I can't duplicate the issue in my environment, can you test
> > the following patch?
> > 
> > diff --git a/block/blk.h b/block/blk.h
> > index 98f4dfd4ec75..980eef1f5690 100644
> > --- a/block/blk.h
> > +++ b/block/blk.h
> > @@ -380,7 +380,7 @@ static inline bool bio_may_need_split(struct bio *bio,
> >                  return true;
> >          bv = __bvec_iter_bvec(bio->bi_io_vec, bio->bi_iter);
> > -       if (bio->bi_iter.bi_size > bv->bv_len)
> > +       if (bio->bi_iter.bi_size > bv->bv_len - bio->bi_iter.bi_bvec_done)
> >                  return true;
> >          return bv->bv_len + bv->bv_offset > lim->max_fast_segment_size;
> >   }
> 
> Hello Ming,
> 
> 
> This is not helping. I am hitting this issue, during kernel build itself.

Can you confirm if it can fix the blktests ext4/056 first?

If kernel building is running over new patched kernel, please provide the
dmesg log. And if it is reproduciable, can you confirm if it can be fixed
by reverting ee623c892aa59003 (block: use bvec iterator helper for bio_may_need_split())?


Thanks,
Ming


  reply	other threads:[~2026-01-09 11:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  4:58 [next-20260108]kernel BUG at drivers/scsi/scsi_lib.c:1173! Venkat Rao Bagalkote
2026-01-09  5:56 ` Christoph Hellwig
2026-01-09  6:49   ` Ming Lei
2026-01-09  7:21     ` Christoph Hellwig
2026-01-09 15:08       ` Christoph Hellwig
2026-01-09 11:44     ` Venkat Rao Bagalkote
2026-01-09 11:55       ` Ming Lei [this message]
2026-01-09 12:21         ` Venkat Rao Bagalkote
2026-01-09 12:58           ` Ming Lei
2026-01-09 13:56             ` Venkat Rao Bagalkote
2026-01-09 14:05               ` Ming Lei
2026-01-09 14:23                 ` Venkat Rao Bagalkote
2026-01-09 14:38                   ` Keith Busch
2026-01-09 14:40                   ` Ming Lei
2026-01-09 16:33                     ` Venkat Rao Bagalkote

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWDspG-J1a3iyIqG@fedora \
    --to=ming.lei@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=kch@nvidia.com \
    --cc=leonro@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=riteshh@linux.ibm.com \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox