From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FEBE27B4E8 for ; Fri, 9 Jan 2026 18:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767983979; cv=none; b=mUsk7XnyFoKdBhDKXU2sdFcQ6w7XqhYTRS+J/JAuFpriuoAMJ82PF6kjYlTDQ1Sy4haG5V7OmPJ82pYgE5l7DV3ofy+0WDAp7mktR4cTQHChd7lUFIDtQE1uTjEt2Pu1N/x3fLawKawVAuFoFBjlEVAQ90XgHX0Wth08pHZAcoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767983979; c=relaxed/simple; bh=iii0d123ExKIJrlcwvMsxl1ja4HVBrDf1cJ4y3FJyAk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZjWmI8T8i+z7UcCDoIrykItmq3gxHSu0oFpNpE3kDBIzsxfzk9IZRP7wi5Gkzq5HIktogB2acdZD5IhCszeG1YG+tqs3caGl6hazwkyts1SwstgoVB/Rn7AFdR2+EJ/H2+ckIcG0U+stFtQnRxBUmFxMhb1wQmN0M2UvXCZfMWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=BclTg9pQ; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BclTg9pQ" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-11f1fb91996so5611748c88.1 for ; Fri, 09 Jan 2026 10:39:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1767983975; x=1768588775; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QGkAMkqR+V4OBARM5yVeFTyT/fTTXcnLUWDxaN4DzMQ=; b=BclTg9pQllzNtnvHfYpiN2kKyYVHGcTWJ50LUyO7PZnEJq5wPR6va+ZTNCaTnGwxMl N/y8I89/s+H3j8as8PlWATsu0TC6Y+CTiZp873dRy+3as0htr05jijGgf51uZGxjOyNA L6qknlgiIcd5pACTBJEY5mGPt/j+uOlW6OFbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767983975; x=1768588775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QGkAMkqR+V4OBARM5yVeFTyT/fTTXcnLUWDxaN4DzMQ=; b=Wc42EXiiowYC3tvmj2jyBk7PSuHfkVQ3eucCJo1GvKhIL/y0Cqxdwpekv+DmllGc2k JKEncibiXOa73S5Em2LNsW/FTIrMFi45dswLvo7AEl4rJQCD3rL4uNYJWEBNWdaSAwNb ZvXdS5Q7iGFB1EvBK6aZs8iX6BD9dD++WhOhdck4+k5SYa3R9fMgFKHvT8/lOnbn25tP eNzdf0POzx8B6GDGUeNgXQPKBSOEu8tZtJ+ZaPJC/z/SCU45oNVXQ8vcibeLxo6U8VUx +KilrDtjxNIC965V4fZb70qK4byP9d/A6wc7cEgWb0mp1hyG5d0HsKqUkDhtbRvLyO76 fLHw== X-Forwarded-Encrypted: i=1; AJvYcCWIsVxln6vOYSZsBrwG1XvX7H81IUO+75xOJY/cNUCna9wYV5E8Y5fByK8ihf9zHu5hU3a1TCG93uuf6F8=@vger.kernel.org X-Gm-Message-State: AOJu0YxUzl6kcwUxONKXRdgd0SeNPdGoCHvJNS9NzlwiVRJlI/iePsp/ ITABhOWx0OQ6359RmrEYeA9jIpl/wX/iWXhKIFXkx5wAHgNy6/VNIUSJCFlFgbpzjQ== X-Gm-Gg: AY/fxX7nO5eW2G+q2RpVMCXcypnQ5PvlZhKnNl7oOSa95Ay5uezeweuhGZEXRL8oSlp qzFngKCncIt/zWgNNF1vXrFtvh6HiUeTkDjpIYaZth5wMjeP0gBABwR/PFXXmS5TjHWwy4S5HMd 8b1hB1USwLtU4NjdYS2/fqaBIeUJS2IVfjBl0iHr+z4h74JU4HT39IpFLsuuzH+JJlq1kmwfpRm 4NA0KhrPQ444fwyP9CPVCfybWLoO6Y9sHmxs81z2jsqziYTgPrJpruE3xxjfPlIV76B6BIlcm4j c+9/PyCOo+v6qpI2Y+vORDH/GDvHxSK+cQZK/TuNybebAUKLUcD94bboRccLtOfbzfU3rMPy6Pc NZG9MEydGwp1NItI6AYmiWUGS9OnBNzMAPlgTbxQHHmIogSAzKMVRKsGYE6Wbq4nO6Oa8eTnIpM PzZN8X5TgFgjnX9XoFCxK3b09aJSoaBiRs4BVVT/JgS6PMuFE8mA== X-Google-Smtp-Source: AGHT+IHonbgs6ZEi4A+cvUsv/vZJaz7TJOTduFOwUmD0NihA9pCUnmtwr83vFvcpz3aX6hWOmbkJ4w== X-Received: by 2002:a05:7022:698a:b0:11b:9386:a3bf with SMTP id a92af1059eb24-121f8b64dc4mr10304781c88.42.1767983975254; Fri, 09 Jan 2026 10:39:35 -0800 (PST) Received: from localhost ([2a00:79e0:2e7c:8:b4c7:3d26:a6c4:9c0e]) by smtp.gmail.com with UTF8SMTPSA id a92af1059eb24-121f24984a3sm18424854c88.13.2026.01.09.10.39.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 10:39:34 -0800 (PST) Date: Fri, 9 Jan 2026 10:39:32 -0800 From: Brian Norris To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: drivers/base/power/runtime-test.c:22 pm_runtime_depth_test() warn: pm_runtime_get_sync() also returns 1 on success Message-ID: References: <202601091832.YueBSiOb-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202601091832.YueBSiOb-lkp@intel.com> On Fri, Jan 09, 2026 at 02:02:09PM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 623fb9912f6af600cda3b6bd166ac738c1115ef4 > commit: 7f7acd193ba8aaa8ed07cfadc335bb17a991fd42 PM: runtime: Add basic kunit tests for API contracts > config: x86_64-randconfig-161-20260109 (https://download.01.org/0day-ci/archive/20260109/202601091832.YueBSiOb-lkp@intel.com/config) > compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 > smatch version: v0.5.0-8985-g2614ff1a > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202601091832.YueBSiOb-lkp@intel.com/ > > New smatch warnings: > drivers/base/power/runtime-test.c:22 pm_runtime_depth_test() warn: pm_runtime_get_sync() also returns 1 on success > drivers/base/power/runtime-test.c:78 pm_runtime_idle_test() warn: pm_runtime_get_sync() also returns 1 on success > drivers/base/power/runtime-test.c:182 pm_runtime_error_test() warn: pm_runtime_get_sync() also returns 1 on success > > Old smatch warnings: > drivers/base/power/runtime-test.c:185 pm_runtime_error_test() warn: pm_runtime_get_sync() also returns 1 on success FWIW, these are all false positives. These are unit tests which are purposely exercising the return codes of this notably-complex API under controlled conditions. Brian > vim +22 drivers/base/power/runtime-test.c > > 7f7acd193ba8aa Brian Norris 2025-09-25 13 static void pm_runtime_depth_test(struct kunit *test) > 7f7acd193ba8aa Brian Norris 2025-09-25 14 { > 7f7acd193ba8aa Brian Norris 2025-09-25 15 struct device *dev = kunit_device_register(test, DEVICE_NAME); > 7f7acd193ba8aa Brian Norris 2025-09-25 16 > 7f7acd193ba8aa Brian Norris 2025-09-25 17 KUNIT_ASSERT_PTR_NE(test, NULL, dev); > 7f7acd193ba8aa Brian Norris 2025-09-25 18 > 7f7acd193ba8aa Brian Norris 2025-09-25 19 pm_runtime_enable(dev); > 7f7acd193ba8aa Brian Norris 2025-09-25 20 > 7f7acd193ba8aa Brian Norris 2025-09-25 21 KUNIT_EXPECT_TRUE(test, pm_runtime_suspended(dev)); > 7f7acd193ba8aa Brian Norris 2025-09-25 @22 KUNIT_EXPECT_EQ(test, 0, pm_runtime_get_sync(dev)); > > Use pm_runtime_resume_and_get()? > > 7f7acd193ba8aa Brian Norris 2025-09-25 23 KUNIT_EXPECT_TRUE(test, pm_runtime_active(dev)); > 7f7acd193ba8aa Brian Norris 2025-09-25 24 KUNIT_EXPECT_EQ(test, 1, pm_runtime_get_sync(dev)); /* "already active" */ > 7f7acd193ba8aa Brian Norris 2025-09-25 25 KUNIT_EXPECT_EQ(test, 0, pm_runtime_put_sync(dev)); > 7f7acd193ba8aa Brian Norris 2025-09-25 26 KUNIT_EXPECT_EQ(test, 0, pm_runtime_put_sync(dev)); > 7f7acd193ba8aa Brian Norris 2025-09-25 27 KUNIT_EXPECT_TRUE(test, pm_runtime_suspended(dev)); > 7f7acd193ba8aa Brian Norris 2025-09-25 28 } >