From: Dan Carpenter <dan.carpenter@linaro.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
linux-sound@vger.kernel.org,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Vinod Koul <vkoul@kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] soundwire: bus: fix off-by-one when allocating slave IDs
Date: Mon, 12 Jan 2026 11:49:19 +0300 [thread overview]
Message-ID: <aWS1j7IdRLCJTj1h@stanley.mountain> (raw)
In-Reply-To: <aWSwS0PQHumb2TJG@stanley.mountain>
On Mon, Jan 12, 2026 at 11:26:51AM +0300, Dan Carpenter wrote:
> On Sun, Jan 11, 2026 at 10:27:08AM +0100, Markus Elfring wrote:
> > …
> > > Using SDW_FW_MAX_DEVICES(16) therefore allows an ID of 16 to be
> > > allocated, but the IRQ domain created for the bus is sized for IDs
> > > 0-15. If 16 is returned, irq_create_mapping() fails and the driver
> > > ends up with an invalid IRQ mapping.
> > …
> >
> > See also once more:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc4#n659
> >
>
> Markus, please only comment when it's a bug in the patch instead of
> wrong advice about commit messages.
Sorry, if that was unclear. The link is a real link to the documentation
which says:
- The body of the explanation, line wrapped at 75 columns, which will
be copied to the permanent changelog to describe this patch.
The rules that we write down are simplified guidelines which are designed
to be easy explain. 75 is the upper bound where checkpatch will complain.
But I think line wrapping at 72 or 74 characters is more common. Either
way it's fine.
regards,
dan carpenter
next prev parent reply other threads:[~2026-01-12 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 20:19 [PATCH] soundwire: bus: fix off-by-one when allocating slave IDs Harshit Mogalapalli
2026-01-11 9:27 ` Markus Elfring
2026-01-12 8:26 ` Dan Carpenter
2026-01-12 8:49 ` Dan Carpenter [this message]
2026-01-12 10:55 ` Markus Elfring
2026-01-12 11:13 ` Richard Fitzgerald
2026-01-13 11:24 ` Vinod Koul
2026-01-12 9:56 ` [PATCH] " Charles Keepax
2026-01-13 11:29 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWS1j7IdRLCJTj1h@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=Markus.Elfring@web.de \
--cc=ckeepax@opensource.cirrus.com \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox