From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7EEB255F2C for ; Mon, 12 Jan 2026 07:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.248.80.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768201569; cv=none; b=Ffo0Z2u8pRCblcXQi3usaksnSrc1Kn4SmXTcbFh4Gzw0YK6Y9owLZU+84rw+9TVj55crOYGq19QZbJgfN6oi7WCRKscNOXTYvAZjC4kmMzy06LHOW0xnOmizlmawf5uO/5dkIpnvfzS7fFrRRBgzRz0RekSPX1+ptaf6LhULNDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768201569; c=relaxed/simple; bh=rLBjb640zyqA+ySpejEq1VoKjaB5jzwCyEhdh3AEdzI=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hns/y0mnoVE2eARUm/NcbFTrn3rtL57MN5yNmJ/8YJiolw+4yHzGHotxHvoOjDUjWyoOZAvt1IZe+O3kUOgnKpZTsuNE++ijqEPDZAfuuhSjmmUc7o+UxFx0jAMAhG4rinaecmVBPfBbEPqCKzsDb52BYzoi3lVSv+j+mmIklLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=permerror header.from=andestech.com; spf=pass smtp.mailfrom=andestech.com; arc=none smtp.client-ip=60.248.80.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=permerror header.from=andestech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=andestech.com Received: from mail.andestech.com (ATCPCS34.andestech.com [10.0.1.134]) by Atcsqr.andestech.com with ESMTPS id 60C75QC9070519 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Mon, 12 Jan 2026 15:05:26 +0800 (+08) (envelope-from cl634@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS34.andestech.com (10.0.1.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 12 Jan 2026 15:05:26 +0800 Date: Mon, 12 Jan 2026 15:05:26 +0800 From: CL Wang To: Krzysztof Kozlowski CC: , , , , , , , , , , Subject: Re: [PATCH 2/3] watchdog: atcwdt200: Add driver for Andes ATCWDT200 Message-ID: References: <20260107145058.213334-1-cl634@andestech.com> <20260107145058.213334-3-cl634@andestech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-ClientProxiedBy: ATCPCS33.andestech.com (10.0.1.100) To ATCPCS34.andestech.com (10.0.1.134) X-DKIM-Results: atcpcs34.andestech.com; dkim=none; X-DNSRBL: X-SPAM-SOURCE-CHECK: pass X-MAIL:Atcsqr.andestech.com 60C75QC9070519 Hi Krzysztof, Thanks for your review. On 07/01/2026 15:50, Krzysztof Kozlowski wrote: > Just use API for getting enabled clock. Agreed. I will switch to using `devm_clk_get_enabled()` to simplify the clock handling and error paths. > No, read your binding. You said it is a list... list of phandles? You are right. The property is intended to be a single uint32 configuration value. I will update the binding schema to clearly define it as such and make it consistent with the driver. > Just return. Agreed. I will simplify the resume path and return directly on error. > Drop, not needed. Understood. I will drop the `"andestech,qilai-wdt"` compatible and keep only the generic one. > From where did you get this? You're right, this is unnecessary. I will remove `.owner = THIS_MODULE`. I will address all of the above in the next revision. Best regards, CL Wang