From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D33532AACB for ; Mon, 12 Jan 2026 07:55:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204551; cv=none; b=qOybrwEbK+7/vL4zImudCsZrWaSFOErAsfPFaUk/JV0maONDtHppQzulQqf7tz5FM76H59OMzZaNfGMDrjtPD+wSp3mkUW3GyKBMbm5yY8QB67TIHkY1+QaIhJpOPkPPoNQ1Ua9bJZzL+6PRFtfHBAy7/TINHhhQ8emQchxbXBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204551; c=relaxed/simple; bh=anx9En/JIDl8AILRrMMoMqcvbdXvKc6xp7QNufV/w8Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i+86ePpHP0pUKvNdw4+mv18O11XB4ZFLyVmNptGZ1pl/fa6P25r8eaZU39LFQ1lHEu6Y9z7Ck1tLfwI3GxUZ8GWpVz3jhdFmS59CzqrM5OMtbE8kJ0jy60zpw4rhdMRL4uwP55lIo5eM6XxGsZd8NH5/emrxkkv/+00E/80tpH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wKG1vkYu; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wKG1vkYu" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so4998889f8f.2 for ; Sun, 11 Jan 2026 23:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768204546; x=1768809346; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kMNv1efcOlEhsDfhmhYD4j/vQ0CBh/NDVWT8ixEF3II=; b=wKG1vkYuajptxaPg7hBQkJnWTdLLBgbF52Wh3cHt107M0nrgT421uT1gkGSUHQWyWE CXBPFUJWeRc1vkNKCy7Ek5BJS57WjQEH0vcFBszzie6PKTfdQUU7cdn7kZWp+wRUEFsy 5eyGeYirBzaRUnyy3bwXQZA3q4Cqtk61WQB0ZY6rQN4TXyQYL+XT5wBtzL7sqDfov20C 8DexAonLmYldY7bLOzwE7vR2j+2qes+IaAYHod4VNwPyxTNqQwSe/Uh2VYWgtSYFPtro qStFaaU7fjzIIWzM9GNdwBQoPxPaD4iTzMNkvYTDNKntCR/PleqrxJ7pf9UJ/yXI3OrP DBcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768204546; x=1768809346; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kMNv1efcOlEhsDfhmhYD4j/vQ0CBh/NDVWT8ixEF3II=; b=IBDCp5oDqZoc19NLBbJPaALpnH/ht2cdJPJjbUuVGFTGZ/GdJToOLvgqMx+Gqh5z1r uH4uapVvx9hiO0ZPgNrT9LaTTppmAx92kdCBgSyf2Z0TJv0e7CEr9VV8OKR8svNebUW2 q72ZNDMNrr2v68/TMsVwN6uCywoAj/Yvh0sn2/jSS2kB7CwjVnthTGxXhUpKSNEFFpt5 Q8hIftiA51ShfYPKv23AcTS3WTQuLVuDzmmXMo939UmtTYAZpFPSsDQUSs6nWnn0NyiR cHlzqfrSPD78kTyDm0ViaWCGXt/gh5ykM/AsX1lHZLL0OSvfmeMLsJQ4FLlkmP9zLOeA VnCA== X-Forwarded-Encrypted: i=1; AJvYcCWMU1/goMcSWP1YQ1bxzVp21zHKhZlKw/YWWxtcK1CvrRnHRqXO0Z4YooOEPN9H+i3SutR7rStQfyq4bcc=@vger.kernel.org X-Gm-Message-State: AOJu0YxSLQb2FTu1UZ74iPDP98ZFpGwzJmP+JmcFqEwOx5Wo0HbQ6qsL 4YZnSwmchcN1/6rZ+Tk3LkboPZqyZv2CvB4iJE4/G8j8qAeXeLfFuaRLytlV3JDPVP8= X-Gm-Gg: AY/fxX5/nPEbOWCV0omFRTlGEfLRkTHHCEmL1JO/4CtzTMkNn0SUNgxWTSagEZF3dfd qyDCUnaBSx1OY+DXjQa73boYceKT1Eap34sJRWKVD5DARN7lkjmJ5b6c2UQJlz2DPjmPHoVw8se x4TsQoc0hNcbnaL9TTAnRMVUMNgA2nyeXwF/Xti8ZsXR8KI9edb7VwtpRGtEq2QSSDiQa2xu4LH Z7b6B/ofR29FaU5VoKMkJ3qGwDu7DlmYRcMar5xjuGYNIl1OkTwFh/yQvLH2RiL7pxIVgJMflMO z7mzwZtlDRejegk8ehGr0nnMRYn4DRUzuNe5ZNHezMhBy5vV34faz3LQ2Z4PPSmka0hxtovjzuz GWKfjytlVXJfjeDbhftj19uBuIlQhbnQ6vt+bCqaCOX+OEiS89++EutoZnexZYMbcJGzm4+D3qk H/QVKxX1hy0i6xVCkNu0B46EOsyJ0= X-Google-Smtp-Source: AGHT+IEwV6E8LNaRLpqECPGzftpWWd4dux6Ti28U2R5tBdKbVyEfX77NkCO2988JsMKhDpZY/fGKCA== X-Received: by 2002:a05:6000:2dc2:b0:432:c0e6:cfda with SMTP id ffacd0b85a97d-432c378a800mr18263914f8f.7.1768204546424; Sun, 11 Jan 2026 23:55:46 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ede7esm37609522f8f.32.2026.01.11.23.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 23:55:46 -0800 (PST) Date: Mon, 12 Jan 2026 10:55:42 +0300 From: Dan Carpenter To: 2023060904@ycu.edu.cn Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, guagua210311@qq.com Subject: Re: [PATCH v5 1/3] rtl8723bs: io: Add independent rtw_check_continual_io_error function Message-ID: References: <20260111032136.7078-1-2023060904@ycu.edu.cn> <2048B07E5179CB78+20260111032136.7078-2-2023060904@ycu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2048B07E5179CB78+20260111032136.7078-2-2023060904@ycu.edu.cn> On Sun, Jan 11, 2026 at 11:21:34AM +0800, 2023060904@ycu.edu.cn wrote: > diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c > index 0f52710e6d3a..cd455cfcf046 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_io.c > +++ b/drivers/staging/rtl8723bs/core/rtw_io.c > @@ -132,19 +132,7 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt > return _SUCCESS; > } > > -/* > - * Increase and check if the continual_io_error of this @param dvobjprive is larger than MAX_CONTINUAL_IO_ERR > - * @return true: > - * @return false: > - */ > -int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj) > -{ > - dvobj->continual_io_error++; > - return (dvobj->continual_io_error > MAX_CONTINUAL_IO_ERR); > -} > - > -/* Set the continual_io_error of this @param dvobjprive to 0 */ > -void rtw_reset_continual_io_error(struct dvobj_priv *dvobj) > +bool rtw_check_continual_io_error(int error_count) > { > - dvobj->continual_io_error = 0; > + return (error_count > MAX_CONTINUAL_IO_ERR) ? true : false; > } You've broken this patch up in the wrong way. This patch removes the dvobj->continual_io_error++ and then the later patches remove the code which uses it. This introduces a bug and then fixes it later. You can't introduce bugs even when they are fixed later in the patchset. Also I don't really know why you are doing this. Have you tested your code? I don't really know why they wrote it like this originally, but it wouldn't surpise me if they did it based on testing. regards, dan carpenter