From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31BE330E83C for ; Mon, 12 Jan 2026 08:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204882; cv=none; b=l0+M44BOhkC+17gz6V1bbdVmnB6GA3rXx7/R9sSmUvnlCEkU8guRFJJJvnWSQWMueQvQL+uPcYFVRhPbWTd+pJmQHcTpSR5NLLCSFah8YDHQ6A1OTfqvi15Atyg8fxXTfJ25u9qXm6bflvms2z+8kgfHz483urMP1uiX8W+2zUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204882; c=relaxed/simple; bh=biL6z9E5LaciSUtIhzFqHVWruJUCSz6yRGjuibFFomA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fmbsRTVR5k2wyKitvsLQuDUncD8FaPMqgPuKj4RrJ85bo7iDbNBrP00i5+sk0h2Di5HxOM5aFROYqSBgZp0PZ/rLjXTssjXypnuorBQaGvmLj0oHQYO+n8kN7OUPWLS1bps0R9oWVPot+h2o0pjQh9xNQ9khH6z87ZX8FdPJb0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vUKjbBL/; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vUKjbBL/" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so62537745e9.1 for ; Mon, 12 Jan 2026 00:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768204880; x=1768809680; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6RaUWb9aHxhel68eHV6lVpbCEpRxCUpEYjk0zN/H2Ak=; b=vUKjbBL/XHcXDr8hg4rgUj60ppTC5y2XeHh5qTOVSiE2cZFjCgV0bRejsnXX0Q8NTh VhbGkPjckuPjqoJSEQT7ASiQTimOEet0zF9XrIHNYmRmWQ+afqwphhh0GtulrC+5Xyxg 5HEum3KD0GD6tbExaLUG6z1Uxc68DBq9EYYPjsOWEs/dOycQNA6+U1RXRyVkKQ1IHvXG u0FoMBtKU4QbIgHA382cwcAIBSzsATYCpsqCTAYlf5TbMfVQhLfeg1Me446jlF9XBGzA cXIBsR2fyGawV97lInZsfGrchCa1CR1VeP8bAfuZVx3lp2LLKMLld3eRfqozUGoO/Mdt AafQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768204880; x=1768809680; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6RaUWb9aHxhel68eHV6lVpbCEpRxCUpEYjk0zN/H2Ak=; b=Yfpo0GKaZipJM1lEOIvQKajIWn/tLmZqo2YT/lMk5b3PgkTsV6EB/6MW8vYSDqnbSd JACfNCwBt7r4iekTEYIMQq48ZQ3zfAxzZ6CQUP1bj9VWPw+HT5MXUupZrrEz2cA5a7zE Lssngk9JB9apKh5k7Khu1nQhLa/4mEJ6ZhzxFD6G5LYhqiBobeRRRjH/GbJ9zuf3qn6v MfaLVVwXuDqO1g42jlHpuKgYMPUebyUwEDwv0+X3VxoK2rq7x1pkm4RPirQYtja6GzEK RfpCZT8/w0aQ6ul7a+yb8OQYMNeXloo5YqFp4kE0GVeDbnIMojP0Yx/1NfnZSu8B+d0p 1TaA== X-Forwarded-Encrypted: i=1; AJvYcCXC27NfzeoSXyEHKzvRXHuWPn38PzOvASUY1kuXBfxvk64GgX/SoIXieVN8a3/C7zgYtb0JSvVorrx5sxo=@vger.kernel.org X-Gm-Message-State: AOJu0YwndIRqbKRBzTE1RmEuQBULVDChhTBE1K/FaMc8QsKLjq8eQ2pz YTt4nfR2mm0ew2TxaOsO7tvFlMl//x5u/VxnT8LdE51L5WvKvrqIbp8Ywq7bUdAx+c8= X-Gm-Gg: AY/fxX4ypEHyvdHCl670tssBsD+B3OtNNd5C5sCbd/Te6MMsn8qjCHtJvfMNRO78hOA SJicM14uYvIe5Ye9229FhueIOhavFKKGrsW4oAA08XVt4dHWMesWzRaz4ud13MNOabYm/seBUy4 aCWRD8bLOVCSN64BHzpldj31t5Xygdw+UkSgI4KDIZ1RhTtItNdSkXgNdDVj/8wlcJQQspTcL9f OmzBV5nqFgGzirO9636TgAdLPTuoxHZCklFcKSxKPGVJePz2m1ULcG17JSkYy2+/hxBy2lSaj7V 3VZQj8fwI9HyVjcEANc6b2JhM8cL+S+TO5eQscYpcyiND4rWM8pWZ6KHnqhaA9Q2iLSRXNPCBUQ 1zXJpaZ8H2E79hr0SnK/QWlSun62yDHI9PocSyKFmO0QA9KxFJiFVlL1pYl22fWPgqHHmwKGLaB +h69X2r/fHewrv+v+y X-Google-Smtp-Source: AGHT+IGwWu6b2drWz7RYiF77nN5AZWhVOT/cb32OXcOfnDJixMi4E2CLNkGJ0NOhd8B+Zb6Xxs7BzA== X-Received: by 2002:a05:600c:a102:b0:477:7a53:f493 with SMTP id 5b1f17b1804b1-47d84b32793mr166994765e9.23.1768204879251; Mon, 12 Jan 2026 00:01:19 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f653cd6sm358916845e9.9.2026.01.12.00.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 00:01:18 -0800 (PST) Date: Mon, 12 Jan 2026 11:01:15 +0300 From: Dan Carpenter To: Khushal Chitturi Cc: Greg Kroah-Hartman , Michael Straube , Hans de Goede , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/9] staging: rtl8723bs: split chained assignments Message-ID: References: <20260111183630.12816-1-khushalchitturi@gmail.com> <20260111183630.12816-6-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260111183630.12816-6-khushalchitturi@gmail.com> On Mon, Jan 12, 2026 at 12:06:26AM +0530, Khushal Chitturi wrote: > @@ -1155,11 +1158,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s > u8 MME[_MME_IE_LENGTH_]; > u32 ori_len; > > - mem_start = pframe = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; > + mem_start = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; > + pframe = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; > pwlanhdr = (struct ieee80211_hdr *)pframe; > > ori_len = BIP_AAD_SIZE + pattrib->pktlen; > - tmp_buf = BIP_AAD = rtw_zmalloc(ori_len); > + tmp_buf = rtw_zmalloc(ori_len); > + BIP_AAD = rtw_zmalloc(ori_len); Nope. We don't want two allocations. regards, dan carpenter