From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D2B33D6DA for ; Mon, 12 Jan 2026 08:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204981; cv=none; b=tMLfvHzH2iYC0p7xW7F6+BxrlkEEO0NA71IrmQ5osQza2qLXRpuPKhiyovGdMTT0m9kMK8bCQneVgehPABvrIQnif7jm79g8tuZVjBIy8Q+R04CgHxaHIwnXky0NiyzeTf7TR22XR4KFslo89Hm0JlBM/1AXyM4dWS1fchZMhfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204981; c=relaxed/simple; bh=8eSaqBHhyaTbXx8HyFw7w133c0078czWubgAV5Moivs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FpE9lRg9gjApK7Htgh8n/VAep7LXoypfzi5C/SbK8yC0ZtCHqWoEWXQ0I/ZdEb9II551jrwuhZTo6cxfskUo4qf7np1cbPRFAGp/PUSwCu3eSN8yF8R+915/L6GdEXquJhbKwJKi1P9P3B4Tnj3wNNY11DXnXYie8seF1rRllxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aghkadVE; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aghkadVE" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42fb5810d39so3100549f8f.2 for ; Mon, 12 Jan 2026 00:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768204978; x=1768809778; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DXTb/TRMy/aD5Zg0lrKtWEV5XVMb4ppi7OiMcPdP/cc=; b=aghkadVEaxNIsyiOYukfoGMDY/3ZyjJRaEVZiFiE4zinZ519MvfDsVpgDF2f/8gIP8 OqaLXU9v2Ub6Q5+CkF7PfMq4UCUq0CvdqawRtZayl2+cRHa7E5iiF81dUewAgcy7zuJl Qk0eIziC2ePFUvebB81bYEWGwfz+ReFnngnAJNinWVN2qYPI313oD8iBRywhm6BtWcBw KTcuZjHaSdaA2lh3qixBt/p+8CFjcnv9z90Wq/YiTFkvw+0VJ4jKnzAdkuwN+1r0HqYl 6bp6J0Nu3kdEBLcqVP7dSnnIg9/yT4w/0A3Ge9uulJV2YU8ItHAUGujpjsNFK97DWnMN +UOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768204978; x=1768809778; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXTb/TRMy/aD5Zg0lrKtWEV5XVMb4ppi7OiMcPdP/cc=; b=LsxoZU1dlpYXaq3ztJQTQ+2hBb+UfaKkO7WIl0S8dTAcNKfa2vjJCuCD8CI8a9ntob YtVRDGhyxpioNOnZjKznBZLy86eFYvWqqHtyOtDzwXNI6p+CgWF2xuEymAspwiaG73C8 SuRNA8w34hu2WMyMcoq8QcNw+FLVyD4Akolu7FNHoXObILf/z35oIPT6zfm+76bJhPpq 9aN5fB6JSkDyZWnbu9SEmYX08VBJPDq8NRVbCLW5s82+0ypmMaCclkW30MxIqNdTOWU1 uDawGjfW5q+pSX3YjGW6JX6laEMDpX2sar3+81r7plQEpQm8HXCdbj58SnECx43I4Yx0 eyMg== X-Forwarded-Encrypted: i=1; AJvYcCW508+Br4tQ3DmpuR7Zmb23wCq+6O1QM7NhwcqJtD7ZcJlCVO95teY07dKgUsDDnhzpueXXS7bWpg4uNno=@vger.kernel.org X-Gm-Message-State: AOJu0YwqgltpoL/SQ9ITmuD3fMdorjLrIFJHQLIRDCqlD7yy7XXX9ydE 126u0n4KXAz4suMRfAkH2+GCxdNcXDwqUQT1ZftoJverDsqsrw0pJMy4yBugJ1YQschOndO2Ox8 oUirg X-Gm-Gg: AY/fxX4JWbb4sccy1SCa4rjAfPTPjeRcSTBqDU0le1+kmwtqzVLTXnJSEAJed87BW6q cD9wfnS8I7roVzzUqNvumkmeLMkzhkav+2t0EF3O0kQ8Fdrniv93DJvEGIrMjf+zz92TmwhOSwi Qv6yfBeXpB5DtR+bUFHbfB3+suVvqnVkg+/dfcV66xYWc7QYTgsXbLkH7+eerthL4RH/qVVK9Qn mq3euga9SQKpf3ACGDj7Je1lo3VqBwpM9VNe5hK7+TBIcnBhBiNrP0yeRKFrv6EHdu3+rbwI4zg acWFkLfXGn73Vec2a3vaN23U1prWhP8s907zDhyIMS8xczi/+iGrcVoH9o5F7wmF+QnnZvCPRCF L85fghM+ZrQq9A11qYSvC/QfVS0Sc3afrLrqqDb7fG44RkV6h1uzK/Di9f4fBpIoSmShpKyulZf g4v/V+oa8ADp/eI9Om X-Google-Smtp-Source: AGHT+IGa06vl7V+9OMZmesChPdTfB81+O48iDAVJjk7fsGcbNg3J6WDhfLSPsO+YS5n0PKEqrjZQdQ== X-Received: by 2002:a05:6000:18c9:b0:432:8537:85ca with SMTP id ffacd0b85a97d-432c3761574mr15158266f8f.50.1768204978178; Mon, 12 Jan 2026 00:02:58 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432dfa6dc4esm15393027f8f.23.2026.01.12.00.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 00:02:57 -0800 (PST) Date: Mon, 12 Jan 2026 11:02:53 +0300 From: Dan Carpenter To: Khushal Chitturi Cc: Greg Kroah-Hartman , Michael Straube , Hans de Goede , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] staging: rtl8723bs: remove empty branches Message-ID: References: <20260111183630.12816-1-khushalchitturi@gmail.com> <20260111183630.12816-3-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260111183630.12816-3-khushalchitturi@gmail.com> On Mon, Jan 12, 2026 at 12:06:23AM +0530, Khushal Chitturi wrote: > Remove empty else blocks in rtw_xmit.c to improve > readability and follow the kernel coding style. > > Signed-off-by: Khushal Chitturi > --- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c > index b0d7e59e492d..cf7d92a85d6c 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > @@ -1707,8 +1707,6 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram > queue = &pxmitpriv->free_xmit_queue; > else if (pxmitframe->ext_tag == 1) > queue = &pxmitpriv->free_xframe_ext_queue; > - else { > - } > > spin_lock_bh(&queue->lock); > > @@ -1999,11 +1997,11 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *xmitframe) > ) > allow = true; > > - } else if (registry->hiq_filter == RTW_HIQ_FILTER_ALLOW_ALL) > + } else if (registry->hiq_filter == RTW_HIQ_FILTER_ALLOW_ALL) { > allow = true; > - else if (registry->hiq_filter == RTW_HIQ_FILTER_DENY_ALL) { > - } else > + } else { > rtw_warn_on(1); > + } Please be more careful. I'm not going to review the other patches. regards, dan carpenter