From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C66A533F397 for ; Mon, 12 Jan 2026 08:19:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768205944; cv=none; b=IRb3Izb/7/SijmlI9AsjKe7vYZAHot3coCHsxE1x9eWk/SL5SxlkYQr7/bB83p/4P8T7Kn1LQaN99IXf/fwDJ26cEGlrZL1b3yx1KIfrKwFfiKU6Uf0UgJ1+lNyHhxSBPogzn8/jjrUErMMhBTwMfohLMC5ds6x7XXoTUGxlfdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768205944; c=relaxed/simple; bh=YxzlEMNKDF0g8mchGkxTwinv2UdMEtiyN/LBYdYwUMw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MeNWsxde00omfvfx3ODQFiFuGpQcb/4zB/tW4SG3/L946HpZ926P94SjVv3AJpCdAiXbsd0YavFSq8NPUzEWnIrQxz3U15YjQ3bofumc3NzvB2xtJGBmdkcQ2pxd/cMEoHDoHQWBdT2WUapoMHYtCdpbUObSEnHFd/nXp2kB2wQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qnLsAiIF; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qnLsAiIF" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-47d6a1f08bbso24236895e9.2 for ; Mon, 12 Jan 2026 00:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768205939; x=1768810739; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NuZvSlWAujHem4qpT7Gn5wLBwA3Ool/TXpYXI9500J0=; b=qnLsAiIFTF6XY1s8Cc1DU6w1oqQng5Q3I9iXRESo4yUUN/Qouy0AwYcAI8cHrv7aoz RTLVamy0RolQLd4cdEH3j9El+wia2BxrlQiqg6qGr7QciD5nwX6GiahrLu4ZZTQaEybe aWY70xGwLjjUEkyv5I+XhdRBr2OdT/agPR+2Hsa+ZrvB9d3nH3Dsr2+MWGIbft6KAUvO oY7HJBSV46lKNP/zKN9al8jDTt/dwzq/ghkEMUWYTmQ3/4Q1TgZE4lK8VGNf3mm7PaZ8 4bmUtt2olXyC/WxAqJpmycRFKf69ufVoNSG1bVbpGgwBDUf65ltigQpfiuwS+TRbIw2L 6caQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768205939; x=1768810739; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NuZvSlWAujHem4qpT7Gn5wLBwA3Ool/TXpYXI9500J0=; b=U/2UQAFFidPIPwz5Wz83a1ytt7Avjf1x/Qp9C+hXBJBdJ18TnpYRDlaZbBZrPUTXrX o8gY81c5lqQjIPg84yvoottG9gZ9ugoCLeVGjtGskQoA3B4ZCW6NXvrGhDj3COHiWFoi Q4pU+xa0FGWhMnGnwiPRY1yLP6XOGMHzz/B2qLo+yJ6+nY6TD9KYJ+nhFHmKsKOiICOe eUY7XO20orFKGdFUU9nwkm3+KFe1Dw2zhyBc/y52WBmwqUWHimq106gIlBv/0Fp3GNef ky/toTp/P0yW0ljPWDhleKlG1fy7QuuhBS+GjbYks7Xbx9RSorAx9P/8x8efzn+nqSRd 0rhQ== X-Forwarded-Encrypted: i=1; AJvYcCWDtwDNDc01y2F2tLo7iB0CJpQSu0h+Yvt0BHnjXadaha7t3lZRDEl05D7IJpxXKv9Os47cAdBzHWJ2Va0=@vger.kernel.org X-Gm-Message-State: AOJu0YylNfRx/bEyrX9VdY2yQ1wUI6akBnOhVGYSEXAXQ9fSVun+1r0m 6rkWtDbGb7mP32X0hNqUI9H46NpJN6W+02Pt+wmleWz7X8pmzR590zduGcNCkniiGg0= X-Gm-Gg: AY/fxX531RKur2c/VJkmQLWI+U5eek7pMKtsCLK+1JxqVBjBNFgRGusGb7MSWzRfyRH IibDesTjXmIcj+6FC6wIvixe54//700UChO8CLMzZgkCxfOurYGteCUzQAqJkNGxVB3D26iEIH5 AaqUA/Pm2IvxG2lsWXUzXm5EN+rFHF149zOlfMUqo4WMsIfFsj4LQgdBb+vAuPxzvPESafZdbgu HiZ1gZwlmDXq9qpnKwY5TBr6074XwT4moGIHMuNpAWZ/Ymeppqj45ToFuDFxee5oquh9MQ6+IrH owQ0R6s4swKvOih3CvjKU2SgvfFDYdEAWedYXCwAaQymB+abHpK1BfFaWwy95C5I/rQJD+WZ9ki sQg2E8GE0H1PvLRq4ky05td9w4eX/qRY4AInn+8dGyj311Ytcp1VakGHQPsBG6A2fdfKlI/Iv9J l/akuV488Uy/9Y1uwm X-Google-Smtp-Source: AGHT+IHgTjliOBZESJFfHoP2lOsn/WfkCD5Nq4LP5m5xfIVnoxcvdXZ7nDXO2ChE3KU/+lNGhFaGdQ== X-Received: by 2002:a05:600c:1992:b0:471:9da:5232 with SMTP id 5b1f17b1804b1-47d84b1a08amr211569615e9.15.1768205938986; Mon, 12 Jan 2026 00:18:58 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8662c09bsm131700035e9.2.2026.01.12.00.18.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 00:18:58 -0800 (PST) Date: Mon, 12 Jan 2026 11:18:55 +0300 From: Dan Carpenter To: Khushal Chitturi Cc: Greg Kroah-Hartman , Michael Straube , Hans de Goede , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/9] staging: rtl8723bs: simplify boolean expressions Message-ID: References: <20260111183630.12816-1-khushalchitturi@gmail.com> <20260111183630.12816-4-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260111183630.12816-4-khushalchitturi@gmail.com> On Mon, Jan 12, 2026 at 12:06:24AM +0530, Khushal Chitturi wrote: > do_queue_select(padapter, &pxmitframe->attrib); > > spin_lock_bh(&pxmitpriv->lock); > - if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) == true) { > + if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) { > spin_unlock_bh(&pxmitpriv->lock); > return 1; > } > spin_unlock_bh(&pxmitpriv->lock); > > /* pre_xmitframe */ > - if (rtw_hal_xmit(padapter, pxmitframe) == false) > + if (rtw_hal_xmit(padapter, pxmitframe)) You reversed this if statement. Really, just please throw this patchset away and restart from scratch. This wasn't my only complaint about this patch but the other was more of a style issue and I think you will fix it if you go slower. > return 1; > > return 0; regards, dan carpenter