From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AFCE31194C for ; Mon, 12 Jan 2026 08:26:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768206418; cv=none; b=khNxsVkjOj9NDg7k1WqCRVBdcbY49xB4To5kOqkGQxNTfsfLB1zIsxj8J2RvEGPheLzc7OMrjpdeBqsvr2wMkTVlVqfOx3UkFGWHUIMhJWgxQ6Jd4K4SjryHvB9oA5TiFwunxnXU7c/xyiVQU9IUbwX4vY5xy8AelRFmkHeK8+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768206418; c=relaxed/simple; bh=PuWAjjq9YrXOY/YeKxnLLx/uXIvacM03hu0GiN3MDm0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mwCGI22m6LJjSoVZ+sVlCaKPQ2Fb/UrvwlLx1gUcfz3mYzPdNJZtQO4IlUVaCRApv3LNzXAq+riErhpyUQQ6ffFnimn/sUSE/x928S0nxBjMjGIcT/8f5hLcmi8qiCSo/c0uT4vEi1JR/SYuExVQFgeb7HDWtkkcUAwTrxOHC+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lUuvD9p9; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lUuvD9p9" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-47774d3536dso42468685e9.0 for ; Mon, 12 Jan 2026 00:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768206415; x=1768811215; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ZC0DHZS+P3sGEVCdfDj7Y+FJ8IlnwpNEuGNXuXov+ic=; b=lUuvD9p93wARKiODPXbE57XAAteBQRm7NXnoZXJ0cw9U1I4to/6g+DmmUlChdA7kns SJ6/m9uOhWcgxuUvuqdgl2oEsu0PSzKAXkNKCd5g8gThl7zzGWCvYTzpO4vw/NDNJlLT R4cjeUXzJHITeeK6/gNSvCPR0XwOEeaZwNdPsl1WlulUaT9TLdllqqvenxZ+2r3ZyyTG iPqluX8go1PX3MobkHltR5Xqf6TTgDcTHpBp5rbEvM03Pz2digTvRQ7kk92c7xU7pxLJ BMOMpAMmhmdHQPNYrxERjK7Fw14yRnVqkz7UQFs1WWDr9g7LdzIMQQi0NgxnwPzZXmkv VK3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768206415; x=1768811215; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZC0DHZS+P3sGEVCdfDj7Y+FJ8IlnwpNEuGNXuXov+ic=; b=GaP/3vrH1VQmJRorBWHnrWN9HFFYudbXJNrDVms0Yf7g4bBRPixeGiUzqCD/2SJhog vd+eE/PSOrAijs0OCHrw4bEH6Ks7pfkr5bmPRkXpO8LbSg3slBC7S1yLXvNh9qaT2Ev8 4kUTovCITclScf53KrobY/3eUYkeKarNTYivS5eYNWojshPGaXpmLGGAAfMX/rDt3MBD mno2SACu++zlpEz6WbIkwGlNJLCytn595gUc8DmFGglPdFGGkZRFA9+iYBWhpCs0lqe6 2NG8/ACsy/iBfN40fOB3+m2rMGNuuAiar+3anxPK35QazEmqMQPN6lyknKYQuz5C/jeF theg== X-Forwarded-Encrypted: i=1; AJvYcCW2XMkbM6gQ6B7xFq0KJgbyjyKwgOfQoA9+QPZ4gex/XnFx6YDjVI4001hqafXTv/apR2TUQ4VPv1hNop8=@vger.kernel.org X-Gm-Message-State: AOJu0YzByM+dPJANa5hwgT15m7J2luNWBn5j42zmD5RMAF/SL6eM6yiH 3LSTAe1Bu6JnepL/ANihVgtNSiBWAdaAUOc+gvBHtuPsXkmdJgEbrnBKhjRkGjeqolY= X-Gm-Gg: AY/fxX6QmLHdjX4fPtn/OTsmcykV/8imT1xS5QtBoyIMsn/88y828GSEpZzariY91YC B8B94h1XxB81ZbCGBqMK2tuJWT+OHdKgdCJFqEvUxG/N2QUNZajswGtDTa9g1Nu1j6vhvHte0aP UC686yNucIcO5sMmd2VEpZczuedWf3fyNm29bNl3XJ50tntNQ0E8Yaw+q0akZbFrsEGiG60ef96 CtAhZYqRF2cVcvZG2ZnnHNNve/ICw6V8ML1+fJE5vK850Ev/XHBncnGMUZWfNV/hqZxf7l3nBjH rdiFGnNsMcw5MDqCHeVrCnGASAvZYkxTP8bqWQJklSLRJ4ZvzHtI9DzrOaMvIuMdVCIJQiEv2Be POF1t3k9zzIssJj9sL0vaNLlVLxj/n7iGS5zrHqgWc2C/MzK19FK9lvtZJmkuYbUfOw0l/BiXC6 MytWyBkDEVs9aCNmL8 X-Google-Smtp-Source: AGHT+IFbBbC9fKaRkOJtSisp6obozjfPCjhneka9YIKhPUP1zuA8mpyRuSMy+JSdrPF+1j6pMtPRHQ== X-Received: by 2002:a05:600c:8b6c:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-47d8486ccebmr166152255e9.11.1768206415540; Mon, 12 Jan 2026 00:26:55 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f68f69dsm339349495e9.1.2026.01.12.00.26.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 00:26:55 -0800 (PST) Date: Mon, 12 Jan 2026 11:26:51 +0300 From: Dan Carpenter To: Markus Elfring Cc: Harshit Mogalapalli , linux-sound@vger.kernel.org, Bard Liao , Charles Keepax , Pierre-Louis Bossart , Vinod Koul , kernel-janitors@vger.kernel.org, LKML , lkp@intel.com, Dan Carpenter Subject: Re: [PATCH] soundwire: bus: fix off-by-one when allocating slave IDs Message-ID: References: <20260110201959.2523024-1-harshit.m.mogalapalli@oracle.com> <732ad24d-d88f-47dc-bb6f-bd1b64ad354e@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <732ad24d-d88f-47dc-bb6f-bd1b64ad354e@web.de> On Sun, Jan 11, 2026 at 10:27:08AM +0100, Markus Elfring wrote: > … > > Using SDW_FW_MAX_DEVICES(16) therefore allows an ID of 16 to be > > allocated, but the IRQ domain created for the bus is sized for IDs > > 0-15. If 16 is returned, irq_create_mapping() fails and the driver > > ends up with an invalid IRQ mapping. > … > > See also once more: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc4#n659 > Markus, please only comment when it's a bug in the patch instead of wrong advice about commit messages. regards, dan carpenter