From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D36340A4D for ; Mon, 12 Jan 2026 08:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768206772; cv=none; b=nZnZHKGWySem7fQMs7T/ki+lbz1SIJhnjbT+T+KOJIJplHv0yCuWaWU7TBESUiP+WmKSiZxdoxVbwbqkKbhQgyl5AJfkN56wBa+nsIG5zKZzRKKPUKgVqcMI6TFTiuoWagCGhremccuQ3S0C4PiZ9d3rSe617TJxXSnNSxVORzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768206772; c=relaxed/simple; bh=CHhxbYtVRJ8UvARH1WuSWqeG79V38j2YQwQMMpKhPlg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UEALEJS9shkrNNDyIpHAKXBXF1Gu9QgWYZNMsPKSXc9wd8Rg5nniFJvn3PgXplJ5uh/9S7HS8kub2YpqqP/fyoxxs267XGDvEK8+wlZySagiEqyANnbd82M34bE8HADi7iTsw2XsGdiZyDrPCDqkfQDmLHMP56z9KQ5EafdQMmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U3yFqGeO; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U3yFqGeO" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47755de027eso34751785e9.0 for ; Mon, 12 Jan 2026 00:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768206769; x=1768811569; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p51irmMY54wjEoANrY9x5z2U+DeQ+nE/A1c1QJUgAvU=; b=U3yFqGeOJ/quAntAUd8gY5ATQsK3KjF7LZAeI6ly0pJlc/lUkNSOlkls8i1hUPZl2H x7t5mB9gQrGxk5yNCCC8owrgPj7QMYdInAI5UTndW03LQDe+kT9s5gYpfTcAjt/r8Cc/ i+cmxW6Jf12EOSWe8WGCJaoeozL6F8c61PAu6FlW81CYHoyt8/pU3Dd9NfWii+JQh9Eq WuVZTF2H3vRFnyUBxLwCW5JYCS9Y6lVdahnjsb03bN/nlEUyfgSCR7lU9A7OKhZ7kCvU QEiE0DdlvALZ2YjjSFAOsI7y49nmcS3Ury/h62HduIsRBhQW1yVX+titDY26q428CNDS toOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768206769; x=1768811569; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p51irmMY54wjEoANrY9x5z2U+DeQ+nE/A1c1QJUgAvU=; b=Lk63z2uyMDVzeOs3sUh4999M4kGYQa8oecoYeJuAkfoskMs/LylH9JVXHJ9HVxnkz3 scg4xZqA/Ncg9pxlETzqnuMiwuInixzn/4Wm4wj7gmcu1l6nIrYrLNUhDFbu0gyDKnwm yz79EM+ckkkjBJ1fFmLd+yjIsaRfwLtjS0Fm6n8XC2i2s3JtL9YGnXlm9va1Kf1v3O6k oX0ESBNN8enqVZgpAVDGv17PSKUNcZARMiLiNLr/iiMVSB4lhvHK7nq1J2LcWiLqFp8x OKC5pRM6oTYQpuGZpaRw6tOI87p6ekiLxWpqoPY5iZ5ZRhge7FD3NbumpIkKB8k2STg6 79Eg== X-Gm-Message-State: AOJu0Yw/P1ZteGRBRlkZLXYaUUowf3cwl+nDbyc+IZYqP+OkWUZxwPPk dy9zoXplgF6cjDNvyjVFOiAIwW1FKcBsUdhR3GY9m0Xk7tHgUhAeUufg X-Gm-Gg: AY/fxX7oCKR6t8yBtEmu0P6sXNYpr9fwQVTCqBVXBQ9oG4vsG8I0ionYLq77Oj+rrzx 2ahlaJxuTAsRauKjO3rMDLsKC2Ul8COH1ofjtivOyyRzuEi12/jpY+el6lI2d1g2zUPpA/iHhgg QXI1e9wf/ju0Lebkx7s2nz0SzVOt1qAWlnnETW+EJAz14cxTexVpbnRm3pn1dJxDM+vTpH9X4Ev 3JlEZWRoBXGUT4GlyintT95rdt6gj6NrUwbg5Qqls5XFee9nrIbmdYN5oRoEt1qCnBNqMc47fiv rpA1dDRead5J7ywQO2jvtgdg4y4CVp7afeOorfa4oQsff+wjOr1gVONuRHrAyuW/KXA9KjTqLGD gEt9z7PsRsvO3ElDazPP2ko8eaVUwxHWPFZclEfBH2iepjET6F3jd4e4NvpMSEm8ZNruNh7IXhN 7bYsOXjBoAuVcY6SIvkJXPO9FIFDrdWI2BkFmbqnAdDiAbV1RAd7PB+MzjQ4T+p1AIGKnazFt15 f8= X-Google-Smtp-Source: AGHT+IH6wXfedcQ2yu1RtG+zbjkyA3yU3V5+gN1yJHGFYOVEaMi7Q5RPlb6IdLZcFS0Zw8lmttQbCA== X-Received: by 2002:a05:600c:630f:b0:47d:5d27:2a7f with SMTP id 5b1f17b1804b1-47d84b38534mr177978875e9.26.1768206769102; Mon, 12 Jan 2026 00:32:49 -0800 (PST) Received: from localhost (brnt-04-b2-v4wan-170138-cust2432.vm7.cable.virginm.net. [94.175.9.129]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f695225sm344466455e9.4.2026.01.12.00.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 00:32:48 -0800 (PST) Date: Mon, 12 Jan 2026 08:32:47 +0000 From: Stafford Horne To: Krzysztof Kozlowski Cc: LKML , Linux OpenRISC , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO Message-ID: References: <20260109134409.2153333-1-shorne@gmail.com> <20260109134409.2153333-3-shorne@gmail.com> <20260111-bold-wolf-of-champagne-58fac7@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 12, 2026 at 08:31:03AM +0100, Krzysztof Kozlowski wrote: > On 11/01/2026 17:46, Stafford Horne wrote: > > On Sun, Jan 11, 2026 at 11:18:42AM +0100, Krzysztof Kozlowski wrote: > >> On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote: > >>> Add a device tree binding for the opencores GPIO controller. > >>> > >>> On FPGA Development boards with GPIOs the OpenRISC architecture uses the > >>> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver. > >>> > >>> Link: https://opencores.org/projects/gpio > >>> Signed-off-by: Stafford Horne > >>> --- > >>> Since v2: > >>> - Fixup patch to simply add opencores,gpio and add an example. > >> > >> Simplify? You completely changed the meaning of binding here - now > >> device is not compatible. > >> > >> I don't know which one is correct, but your changelog must explain why > >> now devices are not compatible but they were before. Trying to answer this better this time: As per our discussion with Geert and Linus W. It was pointed out that the original patch, which added openrisc,gpio to be allowed along with the broadcom chip e.g. ( compatible = "opencores,gpio", "brcm,bcm6345-gpio"; ), was wrong. The opencores,gpio is compatible with the gpio-mmio driver, but it is not a hardware clone with the broadcomm chip. It has 8-bit registers vs 32-bit registers and the register map is different. Instead of allowing opencores,gpio to be specified along with the broadcom chip, opencores,gpio should be specified on its own. So we agreed to resend the patch with to parts: 1. A commit to add the opencores,gpio to the driver compatibility list. (new 1/6) 2. A commit to add opencores,gpio to the binding (replacement of the original patch 2/6) (now I understand this order is bad, I can resend) This is a "simplification" as we are now just adding the opencores,gpio string to the list rather than changing the schema with oneOf and items. I wanted top get it out quickly so it can be fixed up before the merge window opens. > > Hello, > > > > Did you miss the 1/6 patch in this series? We add the compatible string to the > > There is no 1/6! It seems you are not on it, but it is on lore here, if you missed it. https://lore.kernel.org/lkml/20260109134409.2153333-2-shorne@gmail.com/ Reading the bindings submitting patches doc's it seems I need to send the whole series to the bindings list. Which may explain. > > driver there before we add it here. > > How does it matter? How can you add something to the driver before you > document the ABI? Did you read the submitting patches doc? Sorry, I didn't read, or realize there was a device tree bindings specific patch document. I see it now, and I see point 5 makes it clear that we should document the binding before the code change. I got the order swapped. https://docs.kernel.org/devicetree/bindings/submitting-patches.html If necessary I can resend the 2 patches in the right order as a series to the devicetree list. devicetree@vger.kernel.org > > > > Sorry, I thought the series and the over letter would be enough to understand > > what I meant by the "Fixup" description here. > > You still did not answer to my comments. OK, I tried again above. -stafford