* [PATCH v3 1/6] gpio: mmio: Add compatible for opencores GPIO
2026-01-09 13:43 [PATCH v3 0/6] OpenRISC de0 nano single and multicore boards Stafford Horne
@ 2026-01-09 13:43 ` Stafford Horne
2026-01-09 23:19 ` Linus Walleij
2026-01-10 14:03 ` Geert Uytterhoeven
2026-01-09 13:43 ` [PATCH v3 2/6] dt-bindings: gpio-mmio: Add " Stafford Horne
` (4 subsequent siblings)
5 siblings, 2 replies; 18+ messages in thread
From: Stafford Horne @ 2026-01-09 13:43 UTC (permalink / raw)
To: LKML
Cc: Linux OpenRISC, Stafford Horne, Linus Walleij,
Bartosz Golaszewski, linux-gpio
On FPGA Development boards with GPIOs the OpenRISC architecture uses the
opencores gpio verilog rtl. This is compatible with the gpio-mmio. Add
the compatible string to allow probing this driver from the devicetree.
Link: https://opencores.org/projects/gpio
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
Since v2:
- New patch
drivers/gpio/gpio-mmio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
index 5daf962b0323..edbcaad57d00 100644
--- a/drivers/gpio/gpio-mmio.c
+++ b/drivers/gpio/gpio-mmio.c
@@ -724,6 +724,7 @@ static const struct of_device_id gpio_mmio_of_match[] = {
{ .compatible = "wd,mbl-gpio" },
{ .compatible = "ni,169445-nand-gpio" },
{ .compatible = "intel,ixp4xx-expansion-bus-mmio-gpio" },
+ { .compatible = "opencores,gpio" },
{ }
};
MODULE_DEVICE_TABLE(of, gpio_mmio_of_match);
--
2.51.0
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 1/6] gpio: mmio: Add compatible for opencores GPIO
2026-01-09 13:43 ` [PATCH v3 1/6] gpio: mmio: Add compatible for opencores GPIO Stafford Horne
@ 2026-01-09 23:19 ` Linus Walleij
2026-01-10 14:03 ` Geert Uytterhoeven
1 sibling, 0 replies; 18+ messages in thread
From: Linus Walleij @ 2026-01-09 23:19 UTC (permalink / raw)
To: Stafford Horne; +Cc: LKML, Linux OpenRISC, Bartosz Golaszewski, linux-gpio
On Fri, Jan 9, 2026 at 2:44 PM Stafford Horne <shorne@gmail.com> wrote:
> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> opencores gpio verilog rtl. This is compatible with the gpio-mmio. Add
> the compatible string to allow probing this driver from the devicetree.
>
> Link: https://opencores.org/projects/gpio
> Signed-off-by: Stafford Horne <shorne@gmail.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v3 1/6] gpio: mmio: Add compatible for opencores GPIO
2026-01-09 13:43 ` [PATCH v3 1/6] gpio: mmio: Add compatible for opencores GPIO Stafford Horne
2026-01-09 23:19 ` Linus Walleij
@ 2026-01-10 14:03 ` Geert Uytterhoeven
1 sibling, 0 replies; 18+ messages in thread
From: Geert Uytterhoeven @ 2026-01-10 14:03 UTC (permalink / raw)
To: Stafford Horne
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
linux-gpio
On Fri, 9 Jan 2026 at 14:48, Stafford Horne <shorne@gmail.com> wrote:
> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> opencores gpio verilog rtl. This is compatible with the gpio-mmio. Add
> the compatible string to allow probing this driver from the devicetree.
>
> Link: https://opencores.org/projects/gpio
> Signed-off-by: Stafford Horne <shorne@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-09 13:43 [PATCH v3 0/6] OpenRISC de0 nano single and multicore boards Stafford Horne
2026-01-09 13:43 ` [PATCH v3 1/6] gpio: mmio: Add compatible for opencores GPIO Stafford Horne
@ 2026-01-09 13:43 ` Stafford Horne
2026-01-09 23:20 ` Linus Walleij
` (3 more replies)
2026-01-09 13:43 ` [PATCH v3 3/6] openrisc: dts: Add de0 nano config and devicetree Stafford Horne
` (3 subsequent siblings)
5 siblings, 4 replies; 18+ messages in thread
From: Stafford Horne @ 2026-01-09 13:43 UTC (permalink / raw)
To: LKML
Cc: Linux OpenRISC, Stafford Horne, Linus Walleij,
Bartosz Golaszewski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-gpio, devicetree
Add a device tree binding for the opencores GPIO controller.
On FPGA Development boards with GPIOs the OpenRISC architecture uses the
opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
Link: https://opencores.org/projects/gpio
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
Since v2:
- Fixup patch to simply add opencores,gpio and add an example.
Since v1:
- Fix schema to actually match the example.
Documentation/devicetree/bindings/gpio/gpio-mmio.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
index ee5d5d25ae82..d44edc181e0a 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
@@ -23,6 +23,7 @@ properties:
- ni,169445-nand-gpio
- wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
- intel,ixp4xx-expansion-bus-mmio-gpio
+ - opencores,gpio
big-endian: true
@@ -160,3 +161,11 @@ examples:
intel,ixp4xx-eb-write-enable = <1>;
};
};
+
+ gpio@91000000 {
+ compatible = "opencores,gpio";
+ reg = <0x91000000 0x1>, <0x91000001 0x1>;
+ reg-names = "dat", "dirout";
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
--
2.51.0
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-09 13:43 ` [PATCH v3 2/6] dt-bindings: gpio-mmio: Add " Stafford Horne
@ 2026-01-09 23:20 ` Linus Walleij
2026-01-10 14:03 ` Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Linus Walleij @ 2026-01-09 23:20 UTC (permalink / raw)
To: Stafford Horne
Cc: LKML, Linux OpenRISC, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-gpio, devicetree
On Fri, Jan 9, 2026 at 2:44 PM Stafford Horne <shorne@gmail.com> wrote:
> Add a device tree binding for the opencores GPIO controller.
>
> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
>
> Link: https://opencores.org/projects/gpio
> Signed-off-by: Stafford Horne <shorne@gmail.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-09 13:43 ` [PATCH v3 2/6] dt-bindings: gpio-mmio: Add " Stafford Horne
2026-01-09 23:20 ` Linus Walleij
@ 2026-01-10 14:03 ` Geert Uytterhoeven
2026-01-11 10:18 ` Krzysztof Kozlowski
2026-01-11 10:20 ` Krzysztof Kozlowski
3 siblings, 0 replies; 18+ messages in thread
From: Geert Uytterhoeven @ 2026-01-10 14:03 UTC (permalink / raw)
To: Stafford Horne
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree
On Fri, 9 Jan 2026 at 14:48, Stafford Horne <shorne@gmail.com> wrote:
> Add a device tree binding for the opencores GPIO controller.
>
> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
>
> Link: https://opencores.org/projects/gpio
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> Since v2:
> - Fixup patch to simply add opencores,gpio and add an example.
> Since v1:
> - Fix schema to actually match the example.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-09 13:43 ` [PATCH v3 2/6] dt-bindings: gpio-mmio: Add " Stafford Horne
2026-01-09 23:20 ` Linus Walleij
2026-01-10 14:03 ` Geert Uytterhoeven
@ 2026-01-11 10:18 ` Krzysztof Kozlowski
2026-01-11 16:46 ` Stafford Horne
2026-01-11 10:20 ` Krzysztof Kozlowski
3 siblings, 1 reply; 18+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-11 10:18 UTC (permalink / raw)
To: Stafford Horne
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree
On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
> Add a device tree binding for the opencores GPIO controller.
>
> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
>
> Link: https://opencores.org/projects/gpio
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> Since v2:
> - Fixup patch to simply add opencores,gpio and add an example.
Simplify? You completely changed the meaning of binding here - now
device is not compatible.
I don't know which one is correct, but your changelog must explain why
now devices are not compatible but they were before.
> Since v1:
> - Fix schema to actually match the example.
>
> Documentation/devicetree/bindings/gpio/gpio-mmio.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> index ee5d5d25ae82..d44edc181e0a 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> @@ -23,6 +23,7 @@ properties:
> - ni,169445-nand-gpio
> - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
> - intel,ixp4xx-expansion-bus-mmio-gpio
> + - opencores,gpio
>
> big-endian: true
>
> @@ -160,3 +161,11 @@ examples:
> intel,ixp4xx-eb-write-enable = <1>;
> };
> };
> +
> + gpio@91000000 {
Please do not grow the examples if they are exactly the same as other.
> + compatible = "opencores,gpio";
> + reg = <0x91000000 0x1>, <0x91000001 0x1>;
> + reg-names = "dat", "dirout";
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-11 10:18 ` Krzysztof Kozlowski
@ 2026-01-11 16:46 ` Stafford Horne
2026-01-12 7:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 18+ messages in thread
From: Stafford Horne @ 2026-01-11 16:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree
On Sun, Jan 11, 2026 at 11:18:42AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
> > Add a device tree binding for the opencores GPIO controller.
> >
> > On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> > opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
> >
> > Link: https://opencores.org/projects/gpio
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > ---
> > Since v2:
> > - Fixup patch to simply add opencores,gpio and add an example.
>
> Simplify? You completely changed the meaning of binding here - now
> device is not compatible.
>
> I don't know which one is correct, but your changelog must explain why
> now devices are not compatible but they were before.
Hello,
Did you miss the 1/6 patch in this series? We add the compatible string to the
driver there before we add it here.
Sorry, I thought the series and the over letter would be enough to understand
what I meant by the "Fixup" description here.
> > Since v1:
> > - Fix schema to actually match the example.
> >
> > Documentation/devicetree/bindings/gpio/gpio-mmio.yaml | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > index ee5d5d25ae82..d44edc181e0a 100644
> > --- a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > @@ -23,6 +23,7 @@ properties:
> > - ni,169445-nand-gpio
> > - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
> > - intel,ixp4xx-expansion-bus-mmio-gpio
> > + - opencores,gpio
> >
> > big-endian: true
> >
> > @@ -160,3 +161,11 @@ examples:
> > intel,ixp4xx-eb-write-enable = <1>;
> > };
> > };
> > +
> > + gpio@91000000 {
>
> Please do not grow the examples if they are exactly the same as other.
I figured this is a new compatible string with a different set of 8 bit
registers so having this example would be beneficial.
> > + compatible = "opencores,gpio";
> > + reg = <0x91000000 0x1>, <0x91000001 0x1>;
> > + reg-names = "dat", "dirout";
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + };
> > --
> > 2.51.0
> >
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-11 16:46 ` Stafford Horne
@ 2026-01-12 7:31 ` Krzysztof Kozlowski
2026-01-12 8:32 ` Stafford Horne
0 siblings, 1 reply; 18+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-12 7:31 UTC (permalink / raw)
To: Stafford Horne
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree
On 11/01/2026 17:46, Stafford Horne wrote:
> On Sun, Jan 11, 2026 at 11:18:42AM +0100, Krzysztof Kozlowski wrote:
>> On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
>>> Add a device tree binding for the opencores GPIO controller.
>>>
>>> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
>>> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
>>>
>>> Link: https://opencores.org/projects/gpio
>>> Signed-off-by: Stafford Horne <shorne@gmail.com>
>>> ---
>>> Since v2:
>>> - Fixup patch to simply add opencores,gpio and add an example.
>>
>> Simplify? You completely changed the meaning of binding here - now
>> device is not compatible.
>>
>> I don't know which one is correct, but your changelog must explain why
>> now devices are not compatible but they were before.
>
> Hello,
>
> Did you miss the 1/6 patch in this series? We add the compatible string to the
There is no 1/6!
> driver there before we add it here.
How does it matter? How can you add something to the driver before you
document the ABI? Did you read the submitting patches doc?
>
> Sorry, I thought the series and the over letter would be enough to understand
> what I meant by the "Fixup" description here.
You still did not answer to my comments.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-12 7:31 ` Krzysztof Kozlowski
@ 2026-01-12 8:32 ` Stafford Horne
0 siblings, 0 replies; 18+ messages in thread
From: Stafford Horne @ 2026-01-12 8:32 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree
On Mon, Jan 12, 2026 at 08:31:03AM +0100, Krzysztof Kozlowski wrote:
> On 11/01/2026 17:46, Stafford Horne wrote:
> > On Sun, Jan 11, 2026 at 11:18:42AM +0100, Krzysztof Kozlowski wrote:
> >> On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
> >>> Add a device tree binding for the opencores GPIO controller.
> >>>
> >>> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> >>> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
> >>>
> >>> Link: https://opencores.org/projects/gpio
> >>> Signed-off-by: Stafford Horne <shorne@gmail.com>
> >>> ---
> >>> Since v2:
> >>> - Fixup patch to simply add opencores,gpio and add an example.
> >>
> >> Simplify? You completely changed the meaning of binding here - now
> >> device is not compatible.
> >>
> >> I don't know which one is correct, but your changelog must explain why
> >> now devices are not compatible but they were before.
Trying to answer this better this time:
As per our discussion with Geert and Linus W. It was pointed out that the
original patch, which added openrisc,gpio to be allowed along with the broadcom
chip e.g. ( compatible = "opencores,gpio", "brcm,bcm6345-gpio"; ), was wrong.
The opencores,gpio is compatible with the gpio-mmio driver, but it is not a
hardware clone with the broadcomm chip. It has 8-bit registers vs 32-bit
registers and the register map is different. Instead of allowing opencores,gpio
to be specified along with the broadcom chip, opencores,gpio should be specified
on its own.
So we agreed to resend the patch with to parts:
1. A commit to add the opencores,gpio to the driver compatibility list. (new
1/6)
2. A commit to add opencores,gpio to the binding (replacement of the
original patch 2/6)
(now I understand this order is bad, I can resend)
This is a "simplification" as we are now just adding the opencores,gpio string
to the list rather than changing the schema with oneOf and items.
I wanted top get it out quickly so it can be fixed up before the merge window
opens.
> > Hello,
> >
> > Did you miss the 1/6 patch in this series? We add the compatible string to the
>
> There is no 1/6!
It seems you are not on it, but it is on lore here, if you missed it.
https://lore.kernel.org/lkml/20260109134409.2153333-2-shorne@gmail.com/
Reading the bindings submitting patches doc's it seems I need to send the whole
series to the bindings list. Which may explain.
> > driver there before we add it here.
>
> How does it matter? How can you add something to the driver before you
> document the ABI? Did you read the submitting patches doc?
Sorry, I didn't read, or realize there was a device tree bindings specific patch
document. I see it now, and I see point 5 makes it clear that we should
document the binding before the code change. I got the order swapped.
https://docs.kernel.org/devicetree/bindings/submitting-patches.html
If necessary I can resend the 2 patches in the right order as a series to the
devicetree list. devicetree@vger.kernel.org
> >
> > Sorry, I thought the series and the over letter would be enough to understand
> > what I meant by the "Fixup" description here.
>
> You still did not answer to my comments.
OK, I tried again above.
-stafford
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-09 13:43 ` [PATCH v3 2/6] dt-bindings: gpio-mmio: Add " Stafford Horne
` (2 preceding siblings ...)
2026-01-11 10:18 ` Krzysztof Kozlowski
@ 2026-01-11 10:20 ` Krzysztof Kozlowski
2026-01-11 16:34 ` Stafford Horne
3 siblings, 1 reply; 18+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-11 10:20 UTC (permalink / raw)
To: Stafford Horne
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree
On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
> Add a device tree binding for the opencores GPIO controller.
>
> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
>
> Link: https://opencores.org/projects/gpio
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> Since v2:
> - Fixup patch to simply add opencores,gpio and add an example.
> Since v1:
> - Fix schema to actually match the example.
>
> Documentation/devicetree/bindings/gpio/gpio-mmio.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
This does not even apply now. Your previous version was applied almost
one month before and you WERE notified about it.
Why did you ignore Bartosz's reply?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-11 10:20 ` Krzysztof Kozlowski
@ 2026-01-11 16:34 ` Stafford Horne
2026-01-12 7:32 ` Krzysztof Kozlowski
0 siblings, 1 reply; 18+ messages in thread
From: Stafford Horne @ 2026-01-11 16:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree
On Sun, Jan 11, 2026 at 11:20:38AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
> > Add a device tree binding for the opencores GPIO controller.
> >
> > On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> > opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
> >
> > Link: https://opencores.org/projects/gpio
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > ---
> > Since v2:
> > - Fixup patch to simply add opencores,gpio and add an example.
> > Since v1:
> > - Fix schema to actually match the example.
> >
> > Documentation/devicetree/bindings/gpio/gpio-mmio.yaml | 9 +++++++++
> > 1 file changed, 9 insertions(+)
>
> This does not even apply now. Your previous version was applied almost
> one month before and you WERE notified about it.
>
> Why did you ignore Bartosz's reply?
Hi Krzysztof,
Sorry for the confusion, we discussed [1] this patch in the last Series with Geert
and Linus W. We decided to Fixup (replace) the original patch with this and a
patch to the GPIO MMIO driver instead. I pointed it out in the cover letter but
it may have not been clear.
I will reply to Bartosz's original mail too so he can understand the intent.
[1] https://lore.kernel.org/lkml/CAD++jLm1u9ChqsftwvbOptiG3Qo2KWxPjqN2snOVuZDYuVST5Q@mail.gmail.com/
-Stafford
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO
2026-01-11 16:34 ` Stafford Horne
@ 2026-01-12 7:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-12 7:32 UTC (permalink / raw)
To: Stafford Horne
Cc: LKML, Linux OpenRISC, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree
On 11/01/2026 17:34, Stafford Horne wrote:
> On Sun, Jan 11, 2026 at 11:20:38AM +0100, Krzysztof Kozlowski wrote:
>> On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
>>> Add a device tree binding for the opencores GPIO controller.
>>>
>>> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
>>> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
>>>
>>> Link: https://opencores.org/projects/gpio
>>> Signed-off-by: Stafford Horne <shorne@gmail.com>
>>> ---
>>> Since v2:
>>> - Fixup patch to simply add opencores,gpio and add an example.
>>> Since v1:
>>> - Fix schema to actually match the example.
>>>
>>> Documentation/devicetree/bindings/gpio/gpio-mmio.yaml | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>
>> This does not even apply now. Your previous version was applied almost
>> one month before and you WERE notified about it.
>>
>> Why did you ignore Bartosz's reply?
>
> Hi Krzysztof,
>
> Sorry for the confusion, we discussed [1] this patch in the last Series with Geert
> and Linus W. We decided to Fixup (replace) the original patch with this and a
> patch to the GPIO MMIO driver instead. I pointed it out in the cover letter but
> it may have not been clear.
>
> I will reply to Bartosz's original mail too so he can understand the intent.
But you did not send any fixup, anything which would change what was
applied almost one month ago!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3 3/6] openrisc: dts: Add de0 nano config and devicetree
2026-01-09 13:43 [PATCH v3 0/6] OpenRISC de0 nano single and multicore boards Stafford Horne
2026-01-09 13:43 ` [PATCH v3 1/6] gpio: mmio: Add compatible for opencores GPIO Stafford Horne
2026-01-09 13:43 ` [PATCH v3 2/6] dt-bindings: gpio-mmio: Add " Stafford Horne
@ 2026-01-09 13:43 ` Stafford Horne
2026-01-09 13:43 ` [PATCH v3 4/6] openrisc: Fix IPIs on simple multicore systems Stafford Horne
` (2 subsequent siblings)
5 siblings, 0 replies; 18+ messages in thread
From: Stafford Horne @ 2026-01-09 13:43 UTC (permalink / raw)
To: LKML
Cc: Linux OpenRISC, Stafford Horne, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jonas Bonn, Stefan Kristiansson, devicetree
The de0 nano from Terasic is an FPGA board that we use in the OpenRISC
community to test OpenRISC configurations. Add a base configuration for
the board that runs an OpenRISC CPU at 50Mhz with 32MB ram, UART for
console and some GPIOs for LEDs and switches.
There is an older version of this floating around that defines all of
the hardware on the board including SPI's, flash devices, sram, ADCs
etc. Eventually it would be good to get the full version upstream
but for now I think a minimal board is good to start with.
Link: https://openrisc.io/tutorials/de0_nano/
Link: https://github.com/olofk/de0_nano
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
Since v2:
- Move leds block up to the top.
- Remove unneeded "status" from gpio0.
- Removed earlycon from de0-nano.dts.
arch/openrisc/boot/dts/de0-nano-common.dtsi | 42 +++++++++++
arch/openrisc/boot/dts/de0-nano.dts | 54 ++++++++++++++
arch/openrisc/configs/de0_nano_defconfig | 79 +++++++++++++++++++++
3 files changed, 175 insertions(+)
create mode 100644 arch/openrisc/boot/dts/de0-nano-common.dtsi
create mode 100644 arch/openrisc/boot/dts/de0-nano.dts
create mode 100644 arch/openrisc/configs/de0_nano_defconfig
diff --git a/arch/openrisc/boot/dts/de0-nano-common.dtsi b/arch/openrisc/boot/dts/de0-nano-common.dtsi
new file mode 100644
index 000000000000..02e329e28e33
--- /dev/null
+++ b/arch/openrisc/boot/dts/de0-nano-common.dtsi
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+ leds0: leds {
+ compatible = "gpio-leds";
+
+ led-heartbeat {
+ gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>;
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_HEARTBEAT;
+ linux,default-trigger = "heartbeat";
+ label = "heartbeat";
+ };
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x00000000 0x02000000>;
+ };
+
+ /* 8 Green LEDs */
+ gpio0: gpio@91000000 {
+ compatible = "opencores,gpio";
+ reg = <0x91000000 0x1>, <0x91000001 0x1>;
+ reg-names = "dat", "dirout";
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ /* 4 DIP Switches */
+ gpio1: gpio@92000000 {
+ compatible = "opencores,gpio";
+ reg = <0x92000000 0x1>, <0x92000001 0x1>;
+ reg-names = "dat", "dirout";
+ gpio-controller;
+ #gpio-cells = <2>;
+ status = "disabled";
+ };
+};
diff --git a/arch/openrisc/boot/dts/de0-nano.dts b/arch/openrisc/boot/dts/de0-nano.dts
new file mode 100644
index 000000000000..b5b854e7e8b4
--- /dev/null
+++ b/arch/openrisc/boot/dts/de0-nano.dts
@@ -0,0 +1,54 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/dts-v1/;
+
+#include "de0-nano-common.dtsi"
+
+/ {
+ model = "Terasic DE0 Nano";
+ compatible = "opencores,or1ksim";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ interrupt-parent = <&pic>;
+
+ aliases {
+ uart0 = &serial0;
+ };
+
+ chosen {
+ stdout-path = "uart0:115200";
+ };
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ cpu@0 {
+ compatible = "opencores,or1200-rtlsvn481";
+ reg = <0>;
+ clock-frequency = <50000000>;
+ };
+ };
+
+ /*
+ * OR1K PIC is built into CPU and accessed via special purpose
+ * registers. It is not addressable and, hence, has no 'reg'
+ * property.
+ */
+ pic: pic {
+ compatible = "opencores,or1k-pic";
+ #interrupt-cells = <1>;
+ interrupt-controller;
+ };
+
+ serial0: serial@90000000 {
+ compatible = "opencores,uart16550-rtlsvn105", "ns16550a";
+ reg = <0x90000000 0x100>;
+ interrupts = <2>;
+ clock-frequency = <50000000>;
+ };
+};
+
+&gpio1 {
+ status = "okay";
+};
diff --git a/arch/openrisc/configs/de0_nano_defconfig b/arch/openrisc/configs/de0_nano_defconfig
new file mode 100644
index 000000000000..bc63905f9cd8
--- /dev/null
+++ b/arch/openrisc/configs/de0_nano_defconfig
@@ -0,0 +1,79 @@
+CONFIG_SYSVIPC=y
+CONFIG_NO_HZ=y
+CONFIG_LOG_BUF_SHIFT=14
+CONFIG_BLK_DEV_INITRD=y
+# CONFIG_RD_GZIP is not set
+# CONFIG_RD_LZMA is not set
+# CONFIG_RD_LZO is not set
+# CONFIG_RD_LZ4 is not set
+# CONFIG_RD_ZSTD is not set
+CONFIG_EXPERT=y
+# CONFIG_EPOLL is not set
+# CONFIG_TIMERFD is not set
+# CONFIG_EVENTFD is not set
+# CONFIG_AIO is not set
+CONFIG_BUILTIN_DTB_NAME="de0-nano"
+# CONFIG_FPU is not set
+CONFIG_HZ_100=y
+# CONFIG_BLOCK is not set
+CONFIG_SLUB_TINY=y
+# CONFIG_COMPAT_BRK is not set
+# CONFIG_VM_EVENT_COUNTERS is not set
+CONFIG_NET=y
+CONFIG_UNIX=y
+CONFIG_UNIX_DIAG=y
+CONFIG_INET=y
+CONFIG_IP_MULTICAST=y
+CONFIG_INET_UDP_DIAG=y
+CONFIG_INET_RAW_DIAG=y
+CONFIG_INET_DIAG_DESTROY=y
+# CONFIG_IPV6 is not set
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
+# CONFIG_PREVENT_FIRMWARE_BUILD is not set
+# CONFIG_FW_LOADER is not set
+# CONFIG_INPUT is not set
+# CONFIG_SERIO is not set
+# CONFIG_VT is not set
+# CONFIG_LEGACY_PTYS is not set
+CONFIG_SERIAL_8250=y
+CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_OF_PLATFORM=y
+# CONFIG_HW_RANDOM is not set
+CONFIG_PPS=y
+CONFIG_GPIO_SYSFS=y
+# CONFIG_GPIO_SYSFS_LEGACY is not set
+CONFIG_GPIO_GENERIC_PLATFORM=y
+# CONFIG_HWMON is not set
+# CONFIG_USB_SUPPORT is not set
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_TIMER=y
+CONFIG_LEDS_TRIGGER_ONESHOT=y
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
+CONFIG_LEDS_TRIGGER_CPU=y
+CONFIG_LEDS_TRIGGER_ACTIVITY=y
+CONFIG_LEDS_TRIGGER_GPIO=y
+CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
+CONFIG_LEDS_TRIGGER_TRANSIENT=y
+CONFIG_LEDS_TRIGGER_PANIC=y
+CONFIG_LEDS_TRIGGER_NETDEV=y
+CONFIG_LEDS_TRIGGER_PATTERN=y
+CONFIG_LEDS_TRIGGER_TTY=y
+# CONFIG_VIRTIO_MENU is not set
+# CONFIG_VHOST_MENU is not set
+# CONFIG_DNOTIFY is not set
+CONFIG_TMPFS=y
+# CONFIG_XZ_DEC_X86 is not set
+# CONFIG_XZ_DEC_POWERPC is not set
+# CONFIG_XZ_DEC_ARM is not set
+# CONFIG_XZ_DEC_ARMTHUMB is not set
+# CONFIG_XZ_DEC_ARM64 is not set
+# CONFIG_XZ_DEC_SPARC is not set
+# CONFIG_XZ_DEC_RISCV is not set
+CONFIG_PRINTK_TIME=y
+# CONFIG_DEBUG_MISC is not set
+# CONFIG_FTRACE is not set
+# CONFIG_RUNTIME_TESTING_MENU is not set
--
2.51.0
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 4/6] openrisc: Fix IPIs on simple multicore systems
2026-01-09 13:43 [PATCH v3 0/6] OpenRISC de0 nano single and multicore boards Stafford Horne
` (2 preceding siblings ...)
2026-01-09 13:43 ` [PATCH v3 3/6] openrisc: dts: Add de0 nano config and devicetree Stafford Horne
@ 2026-01-09 13:43 ` Stafford Horne
2026-01-09 13:43 ` [PATCH v3 5/6] openrisc: dts: Split simple smp dts to dts and dtsi Stafford Horne
2026-01-09 13:43 ` [PATCH v3 6/6] openrisc: dts: Add de0 nano multicore config and devicetree Stafford Horne
5 siblings, 0 replies; 18+ messages in thread
From: Stafford Horne @ 2026-01-09 13:43 UTC (permalink / raw)
To: LKML
Cc: Linux OpenRISC, Stafford Horne, Jonas Bonn, Stefan Kristiansson,
Thomas Gleixner
Commit c05671846451 ("openrisc: sleep instead of spin on secondary
wait") fixed OpenRISC SMP Linux for QEMU. However, stability was never
achieved on FPGA development boards. This is because the above patch
has a step to unmask IPIs on non-boot cpu's but on hardware without
power management, IPIs remain masked.
This meant that IPI's were never actually working on the simple SMP
systems we run on development boards. The systems booted but stability
was very suspect.
Add the ability to unmask IPI's on the non-boot cores. This is done by
making the OMPIC IRQs proper percpu IRQs. We can then use the
enabled_percpu_irq() to unmask IRQ on the non-boot cpus.
Update the or1k PIC driver to use a flow handler that can switch between
percpu and the configured level or edge flow handlers at runtime.
This mechanism is inspired by that done in the J-Core AIC driver.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/include/asm/smp.h | 3 ++-
arch/openrisc/kernel/smp.c | 22 +++++++++++++++++++++-
drivers/irqchip/irq-ompic.c | 15 +++++++++++----
drivers/irqchip/irq-or1k-pic.c | 27 ++++++++++++++++++++++++++-
4 files changed, 60 insertions(+), 7 deletions(-)
diff --git a/arch/openrisc/include/asm/smp.h b/arch/openrisc/include/asm/smp.h
index e21d2f12b5b6..007296f160ef 100644
--- a/arch/openrisc/include/asm/smp.h
+++ b/arch/openrisc/include/asm/smp.h
@@ -20,7 +20,8 @@ extern void smp_init_cpus(void);
extern void arch_send_call_function_single_ipi(int cpu);
extern void arch_send_call_function_ipi_mask(const struct cpumask *mask);
-extern void set_smp_cross_call(void (*)(const struct cpumask *, unsigned int));
+extern void set_smp_cross_call(void (*)(const struct cpumask *, unsigned int),
+ unsigned int irq);
extern void handle_IPI(unsigned int ipi_msg);
#endif /* __ASM_OPENRISC_SMP_H */
diff --git a/arch/openrisc/kernel/smp.c b/arch/openrisc/kernel/smp.c
index 86da4bc5ee0b..040ca201b692 100644
--- a/arch/openrisc/kernel/smp.c
+++ b/arch/openrisc/kernel/smp.c
@@ -13,6 +13,7 @@
#include <linux/smp.h>
#include <linux/cpu.h>
+#include <linux/interrupt.h>
#include <linux/sched.h>
#include <linux/sched/mm.h>
#include <linux/irq.h>
@@ -25,6 +26,7 @@
asmlinkage __init void secondary_start_kernel(void);
+static unsigned int ipi_irq __ro_after_init;
static void (*smp_cross_call)(const struct cpumask *, unsigned int);
unsigned long secondary_release = -1;
@@ -39,6 +41,14 @@ enum ipi_msg_type {
static DEFINE_SPINLOCK(boot_lock);
+static void or1k_ipi_enable(void)
+{
+ if (WARN_ON_ONCE(!ipi_irq))
+ return;
+
+ enable_percpu_irq(ipi_irq, 0);
+}
+
static void boot_secondary(unsigned int cpu, struct task_struct *idle)
{
/*
@@ -136,6 +146,7 @@ asmlinkage __init void secondary_start_kernel(void)
complete(&cpu_running);
synchronise_count_slave(cpu);
+ or1k_ipi_enable();
set_cpu_online(cpu, true);
local_irq_enable();
@@ -195,9 +206,18 @@ void smp_send_stop(void)
smp_call_function(stop_this_cpu, NULL, 0);
}
-void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int))
+void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int),
+ unsigned int irq)
{
+ if (WARN_ON(ipi_irq))
+ return;
+
smp_cross_call = fn;
+
+ ipi_irq = irq;
+
+ /* Enabled IPIs for boot CPU immediately */
+ or1k_ipi_enable();
}
void arch_send_call_function_single_ipi(int cpu)
diff --git a/drivers/irqchip/irq-ompic.c b/drivers/irqchip/irq-ompic.c
index e66ef4373b1e..f0e0b435bb1d 100644
--- a/drivers/irqchip/irq-ompic.c
+++ b/drivers/irqchip/irq-ompic.c
@@ -84,6 +84,8 @@ DEFINE_PER_CPU(unsigned long, ops);
static void __iomem *ompic_base;
+static DEFINE_PER_CPU_READ_MOSTLY(int, ipi_dummy_dev);
+
static inline u32 ompic_readreg(void __iomem *base, loff_t offset)
{
return ioread32be(base + offset);
@@ -183,12 +185,17 @@ static int __init ompic_of_init(struct device_node *node,
goto out_unmap;
}
- ret = request_irq(irq, ompic_ipi_handler, IRQF_PERCPU,
- "ompic_ipi", NULL);
- if (ret)
+ irq_set_percpu_devid(irq);
+ ret = request_percpu_irq(irq, ompic_ipi_handler, "ompic_ipi",
+ &ipi_dummy_dev);
+
+ if (ret) {
+ pr_err("ompic: failed to request irq %d, error: %d",
+ irq, ret);
goto out_irq_disp;
+ }
- set_smp_cross_call(ompic_raise_softirq);
+ set_smp_cross_call(ompic_raise_softirq, irq);
return 0;
diff --git a/drivers/irqchip/irq-or1k-pic.c b/drivers/irqchip/irq-or1k-pic.c
index 48126067c54b..73dc99c71d40 100644
--- a/drivers/irqchip/irq-or1k-pic.c
+++ b/drivers/irqchip/irq-or1k-pic.c
@@ -118,11 +118,36 @@ static void or1k_pic_handle_irq(struct pt_regs *regs)
generic_handle_domain_irq(root_domain, irq);
}
+/*
+ * The OR1K PIC is a cpu-local interrupt controller and does not distinguish or
+ * use distinct irq number ranges for per-cpu event interrupts (IPI). Since
+ * information to determine whether a particular irq number should be treated as
+ * per-cpu is not available at mapping time, we use a wrapper handler function
+ * which chooses the right handler at runtime based on whether IRQF_PERCPU was
+ * used when requesting the irq. Borrowed from J-Core AIC.
+ */
+static void or1k_irq_flow_handler(struct irq_desc *desc)
+{
+#ifdef CONFIG_SMP
+ struct irq_data *data = irq_desc_get_irq_data(desc);
+ struct or1k_pic_dev *pic = data->domain->host_data;
+
+ if (irqd_is_per_cpu(data))
+ handle_percpu_devid_irq(desc);
+ else
+ pic->handle(desc);
+#endif
+}
+
static int or1k_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw)
{
struct or1k_pic_dev *pic = d->host_data;
- irq_set_chip_and_handler(irq, &pic->chip, pic->handle);
+ if (IS_ENABLED(CONFIG_SMP))
+ irq_set_chip_and_handler(irq, &pic->chip, or1k_irq_flow_handler);
+ else
+ irq_set_chip_and_handler(irq, &pic->chip, pic->handle);
+
irq_set_status_flags(irq, pic->flags);
return 0;
--
2.51.0
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 5/6] openrisc: dts: Split simple smp dts to dts and dtsi
2026-01-09 13:43 [PATCH v3 0/6] OpenRISC de0 nano single and multicore boards Stafford Horne
` (3 preceding siblings ...)
2026-01-09 13:43 ` [PATCH v3 4/6] openrisc: Fix IPIs on simple multicore systems Stafford Horne
@ 2026-01-09 13:43 ` Stafford Horne
2026-01-09 13:43 ` [PATCH v3 6/6] openrisc: dts: Add de0 nano multicore config and devicetree Stafford Horne
5 siblings, 0 replies; 18+ messages in thread
From: Stafford Horne @ 2026-01-09 13:43 UTC (permalink / raw)
To: LKML
Cc: Linux OpenRISC, Stafford Horne, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jonas Bonn, Stefan Kristiansson, Masahiro Yamada,
devicetree
Split out the common memory, CPU and PIC definitions of the simple SMP
system to a DTSI file which we will later use for our De0 Nano multicore
board device tree. We also take this opportunity to swich underscores
to dashes as that seems to be the more common convention for DTS files.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
Since v2:
- Sort blocks alphabetically.
arch/openrisc/boot/dts/simple-smp.dts | 25 +++++++++++++++++++
.../dts/{simple_smp.dts => simple-smp.dtsi} | 11 ++++----
arch/openrisc/configs/simple_smp_defconfig | 2 +-
3 files changed, 31 insertions(+), 7 deletions(-)
create mode 100644 arch/openrisc/boot/dts/simple-smp.dts
rename arch/openrisc/boot/dts/{simple_smp.dts => simple-smp.dtsi} (90%)
diff --git a/arch/openrisc/boot/dts/simple-smp.dts b/arch/openrisc/boot/dts/simple-smp.dts
new file mode 100644
index 000000000000..01cf219e6aac
--- /dev/null
+++ b/arch/openrisc/boot/dts/simple-smp.dts
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/dts-v1/;
+
+#include "simple-smp.dtsi"
+
+/ {
+ model = "Simple SMP Board";
+};
+
+&cpu0 {
+ clock-frequency = <20000000>;
+};
+
+&cpu1 {
+ clock-frequency = <20000000>;
+};
+
+&enet0 {
+ status = "okay";
+};
+
+&serial0 {
+ clock-frequency = <20000000>;
+};
diff --git a/arch/openrisc/boot/dts/simple_smp.dts b/arch/openrisc/boot/dts/simple-smp.dtsi
similarity index 90%
rename from arch/openrisc/boot/dts/simple_smp.dts
rename to arch/openrisc/boot/dts/simple-smp.dtsi
index 71af0e117bfe..42d6eda33b71 100644
--- a/arch/openrisc/boot/dts/simple_smp.dts
+++ b/arch/openrisc/boot/dts/simple-smp.dtsi
@@ -1,4 +1,3 @@
-/dts-v1/;
/ {
compatible = "opencores,or1ksim";
#address-cells = <1>;
@@ -22,15 +21,15 @@ memory@0 {
cpus {
#address-cells = <1>;
#size-cells = <0>;
- cpu@0 {
+
+ cpu0: cpu@0 {
compatible = "opencores,or1200-rtlsvn481";
reg = <0>;
- clock-frequency = <20000000>;
};
- cpu@1 {
+
+ cpu1: cpu@1 {
compatible = "opencores,or1200-rtlsvn481";
reg = <1>;
- clock-frequency = <20000000>;
};
};
@@ -57,7 +56,6 @@ serial0: serial@90000000 {
compatible = "opencores,uart16550-rtlsvn105", "ns16550a";
reg = <0x90000000 0x100>;
interrupts = <2>;
- clock-frequency = <20000000>;
};
enet0: ethoc@92000000 {
@@ -65,5 +63,6 @@ enet0: ethoc@92000000 {
reg = <0x92000000 0x800>;
interrupts = <4>;
big-endian;
+ status = "disabled";
};
};
diff --git a/arch/openrisc/configs/simple_smp_defconfig b/arch/openrisc/configs/simple_smp_defconfig
index 6008e824d31c..db77c795225e 100644
--- a/arch/openrisc/configs/simple_smp_defconfig
+++ b/arch/openrisc/configs/simple_smp_defconfig
@@ -20,7 +20,7 @@ CONFIG_SLUB=y
CONFIG_SLUB_TINY=y
CONFIG_MODULES=y
# CONFIG_BLOCK is not set
-CONFIG_BUILTIN_DTB_NAME="simple_smp"
+CONFIG_BUILTIN_DTB_NAME="simple-smp"
CONFIG_SMP=y
CONFIG_HZ_100=y
CONFIG_OPENRISC_HAVE_SHADOW_GPRS=y
--
2.51.0
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 6/6] openrisc: dts: Add de0 nano multicore config and devicetree
2026-01-09 13:43 [PATCH v3 0/6] OpenRISC de0 nano single and multicore boards Stafford Horne
` (4 preceding siblings ...)
2026-01-09 13:43 ` [PATCH v3 5/6] openrisc: dts: Split simple smp dts to dts and dtsi Stafford Horne
@ 2026-01-09 13:43 ` Stafford Horne
5 siblings, 0 replies; 18+ messages in thread
From: Stafford Horne @ 2026-01-09 13:43 UTC (permalink / raw)
To: LKML
Cc: Linux OpenRISC, Stafford Horne, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jonas Bonn, Stefan Kristiansson, devicetree
Add a multicore configuration for the Terasic de0 nano FPGA development
board. This SoC runs 2 OpenRISC CPUs at 50Mhz with 32MB ram, UART for
console and GPIOs for LEDs.
This FPGA SoC is based on the simple-smp reference board and brings in
devices from the de0 nano common DTSI file.
A default config is added that brings together the device tree and
driver setup.
Link: https://github.com/stffrdhrn/de0_nano-multicore
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/boot/dts/de0-nano-multicore.dts | 25 +++++
.../configs/de0_nano_multicore_defconfig | 92 +++++++++++++++++++
2 files changed, 117 insertions(+)
create mode 100644 arch/openrisc/boot/dts/de0-nano-multicore.dts
create mode 100644 arch/openrisc/configs/de0_nano_multicore_defconfig
diff --git a/arch/openrisc/boot/dts/de0-nano-multicore.dts b/arch/openrisc/boot/dts/de0-nano-multicore.dts
new file mode 100644
index 000000000000..b6cf286afaa4
--- /dev/null
+++ b/arch/openrisc/boot/dts/de0-nano-multicore.dts
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+
+/dts-v1/;
+
+#include "simple-smp.dtsi"
+#include "de0-nano-common.dtsi"
+
+/ {
+ model = "Terasic DE0 Nano - Multicore";
+};
+
+&cpu0 {
+ clock-frequency = <50000000>;
+};
+
+&cpu1 {
+ clock-frequency = <50000000>;
+};
+
+&serial0 {
+ clock-frequency = <50000000>;
+};
diff --git a/arch/openrisc/configs/de0_nano_multicore_defconfig b/arch/openrisc/configs/de0_nano_multicore_defconfig
new file mode 100644
index 000000000000..d33b1226e09c
--- /dev/null
+++ b/arch/openrisc/configs/de0_nano_multicore_defconfig
@@ -0,0 +1,92 @@
+CONFIG_LOCALVERSION="-de0nano-smp"
+CONFIG_SYSVIPC=y
+CONFIG_POSIX_MQUEUE=y
+CONFIG_NO_HZ=y
+CONFIG_LOG_BUF_SHIFT=14
+CONFIG_BLK_DEV_INITRD=y
+# CONFIG_RD_GZIP is not set
+# CONFIG_RD_BZIP2 is not set
+# CONFIG_RD_LZMA is not set
+# CONFIG_RD_XZ is not set
+# CONFIG_RD_LZO is not set
+# CONFIG_RD_LZ4 is not set
+CONFIG_EXPERT=y
+# CONFIG_EPOLL is not set
+# CONFIG_TIMERFD is not set
+# CONFIG_EVENTFD is not set
+# CONFIG_AIO is not set
+CONFIG_KALLSYMS_ALL=y
+CONFIG_DCACHE_WRITETHROUGH=y
+CONFIG_BUILTIN_DTB_NAME="de0-nano-multicore"
+CONFIG_OPENRISC_HAVE_INST_CMOV=y
+CONFIG_SMP=y
+CONFIG_HZ_100=y
+CONFIG_JUMP_LABEL=y
+# CONFIG_BLOCK is not set
+CONFIG_SLUB_TINY=y
+# CONFIG_COMPAT_BRK is not set
+# CONFIG_VM_EVENT_COUNTERS is not set
+CONFIG_NET=y
+CONFIG_PACKET=y
+CONFIG_UNIX=y
+CONFIG_UNIX_DIAG=y
+CONFIG_INET=y
+CONFIG_IP_MULTICAST=y
+CONFIG_TCP_CONG_ADVANCED=y
+# CONFIG_TCP_CONG_BIC is not set
+# CONFIG_TCP_CONG_CUBIC is not set
+# CONFIG_TCP_CONG_WESTWOOD is not set
+# CONFIG_TCP_CONG_HTCP is not set
+# CONFIG_IPV6 is not set
+# CONFIG_WIRELESS is not set
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
+# CONFIG_PREVENT_FIRMWARE_BUILD is not set
+# CONFIG_FW_LOADER is not set
+CONFIG_NETDEVICES=y
+CONFIG_ETHOC=y
+CONFIG_MICREL_PHY=y
+# CONFIG_WLAN is not set
+# CONFIG_INPUT is not set
+# CONFIG_SERIO is not set
+# CONFIG_VT is not set
+# CONFIG_LEGACY_PTYS is not set
+CONFIG_SERIAL_8250=y
+CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_OF_PLATFORM=y
+# CONFIG_HW_RANDOM is not set
+CONFIG_GPIO_SYSFS=y
+# CONFIG_GPIO_CDEV_V1 is not set
+CONFIG_GPIO_GENERIC_PLATFORM=y
+# CONFIG_HWMON is not set
+# CONFIG_USB_SUPPORT is not set
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_TIMER=y
+CONFIG_LEDS_TRIGGER_ONESHOT=y
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
+CONFIG_LEDS_TRIGGER_CPU=y
+CONFIG_LEDS_TRIGGER_ACTIVITY=y
+CONFIG_LEDS_TRIGGER_GPIO=y
+CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
+CONFIG_LEDS_TRIGGER_TRANSIENT=y
+CONFIG_LEDS_TRIGGER_PANIC=y
+CONFIG_LEDS_TRIGGER_NETDEV=y
+CONFIG_LEDS_TRIGGER_PATTERN=y
+CONFIG_LEDS_TRIGGER_TTY=y
+# CONFIG_DNOTIFY is not set
+CONFIG_TMPFS=y
+CONFIG_NFS_FS=y
+CONFIG_XZ_DEC=y
+CONFIG_PRINTK_TIME=y
+CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
+CONFIG_GDB_SCRIPTS=y
+CONFIG_VMLINUX_MAP=y
+CONFIG_HARDLOCKUP_DETECTOR=y
+CONFIG_WQ_WATCHDOG=y
+CONFIG_WQ_CPU_INTENSIVE_REPORT=y
+CONFIG_STACKTRACE=y
+CONFIG_RCU_CPU_STALL_CPUTIME=y
+# CONFIG_RCU_TRACE is not set
--
2.51.0
^ permalink raw reply related [flat|nested] 18+ messages in thread