From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 925583806B7 for ; Mon, 12 Jan 2026 18:07:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768241273; cv=none; b=bTBgZm9h+J8KIpo/D4T2FmWtK4LGdJCumUEFvxSinmWmx1Qb14UQbQpAWDH52rG81yzEjtoAHP/0nrv2fk5Q5uhlgLgNZ0ZJIcYTp/B0yVKBoQOo7M55E6ltYtPCbpy/Eyu5vzIZLt80JMUIUp/39jVIxViXOb+3qNECHZo0qyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768241273; c=relaxed/simple; bh=dHrr/T4aX+vs3oAgOvAPZZQy7mi8rDhEwAcJ4vKtt48=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sG1pCIUK6r4USisEEj/awd0Lta17WLIJDjScYyyV7zQkvLOqGWATnS46f37Gt/IPOjpWtnjaqSrFdjdaFpdBarCZ/Sxz2FvVfEmyhbxw+zQJ2ziDj47IlfVzpC5lqqj9bddY7NG0U12bUo+jGu/PqZjqCCO5ZvPgcXCWzcZSx8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ccDCxXBY; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ccDCxXBY" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c2dd0c24e5cso2834472a12.3 for ; Mon, 12 Jan 2026 10:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768241272; x=1768846072; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zDGQRAbPUjfkXaVJhLTd0EOsqSoToEi+iTNTPo6suIg=; b=ccDCxXBYhuF35ZvvT//IXUBYFG5RQ562qWvlVHF0KxTlZgMF2/fBrYhuPVTiiHNz2r yFVJovT+sUOPzu0DVGKbfN/CpH3NIR7DVIfkem+4VxjDz8TGjCvfbMnVEyMK8fAKSVoR z/TQYsTlkgM2Sor3aWES2vEgKdT0P5sNff55KAPIgJtJ/n5DvCHso7vTi/jiL/xn6r6L P7d8TnDWL7dm5snN7ESHk6zgqOoBV3fVuB10T0j3xdllJtCzQU3Fq/2qpSZOhg5wnt9x HCRawoUcJxy3U3dk9Y0j5moAtKv+PsgsBenN1d7daR5u+Vg8+sSInp2A6eSRX6HyoroD qUYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768241272; x=1768846072; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zDGQRAbPUjfkXaVJhLTd0EOsqSoToEi+iTNTPo6suIg=; b=enuSBM53CqgnsfOexFwWbVciK/5cSElxA7Kp3/GcK/GGM8Ffnf6F0JxztSkc7a9Drh wc4qpFggmlq9Nw9qG34dZ8BLx9WPhIyaMKn7hSF7CEq7kJpIT6PV/tWfquxKpPpQ9YZl zl3lq861wp2DsXJLWZenpGeTMN3ud/JGh/erFVLIjR5D3h7VrSMbc0SvoHvBoLUUm6oV ReO9DvDCWnXDUVBdEdGV5v9ombvkNOIv5zUxbYS2omtFlTnzPjdUDZEKjRuLu2UC5H9v 1hCHrY49l7mWB1v7Guf6Rp+GyX6fI3rHwGw4mUwktGSTkKVz9cSPLlpMq1UYT48llVoa k5Bg== X-Forwarded-Encrypted: i=1; AJvYcCVE6PjVXbpXb4GOfoHyA7RzfAhGDapn0rGbMneiMNSsNGaMxjSsVvR8GyoqKM/zM5s6BizVkJPTdKzZ13s=@vger.kernel.org X-Gm-Message-State: AOJu0YwouhXJKrI+LnlKdgDP7dHG8xIhFFgVXdSisMxpxwtzlE/HSMeH zrT2OnzT4/CxPOYUvw8vh319wl8jIjxrI27ox1IUVlpTClO2WJihovl0 X-Gm-Gg: AY/fxX7bIXxJ58aMUj+ddkvQZvaVGgqu68ksjO8q5X214OnWwSNTPYOccy8ycFJ8qjx 70dK879uyFnL3JidDG6BMrV7AKY+04tlu7FjpSZljjoVnIUmwzGwWhaiWh4eeXpJ54rXQoOh3vG 6uFOs6+jzx9j1sa5bc54rHRVC/srVuKQi8sPH3Sccl+ABTdChkeaPeXqBGB21+h0VjVj4GGXvJa Y2KRLDiyUm0nVdFPS07y9jmkZul2SWpPuxrilOR1aToRiEoB02g350laR7bY18Wx6kFRaHKrnNK I9JwppTfJamEYGWN1gh2yLvPhUD+krlPFioVkhkaqxdJ6fmxRRR/xRdEV2uG8itgJ1aVDQxhjrr 8hN/AlzDk6jjxf4maNW5vEFECjS+nK4gC42tg+uCFva2ciptqLKZnUimC0YxsbGvxWepM5IDfEk Alw78/fQZxzcaf8MJkL1Y= X-Google-Smtp-Source: AGHT+IEUzxrN8NZqXvPH5JJMBYF3btzaRQp1HHCq9owJBNQYe6YmOBfDUYXF/ZMNTxgE09jJO72Ljg== X-Received: by 2002:a17:903:234c:b0:29d:6b8e:d565 with SMTP id d9443c01a7336-2a3ee4c0e80mr152917325ad.38.1768241271894; Mon, 12 Jan 2026 10:07:51 -0800 (PST) Received: from archlinux ([2405:201:1b:225c:eb9d:1fc0:f95c:bd90]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc88fcsm178881325ad.83.2026.01.12.10.07.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 10:07:51 -0800 (PST) Date: Mon, 12 Jan 2026 23:37:43 +0530 From: Krishna Chomal To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: Hans de Goede , linux@roeck-us.net, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, LKML Subject: Re: [PATCH v2 2/2] platform/x86: hp-wmi: implement fan keep-alive Message-ID: References: <20251225142310.204831-1-krishna.chomal108@gmail.com> <20251230145053.516196-1-krishna.chomal108@gmail.com> <20251230145053.516196-3-krishna.chomal108@gmail.com> <6b2be55e-dcfe-74b7-d8ca-b78f49cedb7a@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6b2be55e-dcfe-74b7-d8ca-b78f49cedb7a@linux.intel.com> On Mon, Jan 12, 2026 at 05:14:12PM +0200, Ilpo Järvinen wrote: [snip] >> static void __exit hp_wmi_bios_remove(struct platform_device *device) >> { >> int i; >> + struct hp_wmi_hwmon_priv *ctx; > >Can't we just call this priv everywhere as per the normal custom? > Yes this was a mistake, I forgot to rename "ctx" to "priv" in v2, sorry. I will ensure to fix this in v3.