From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 692C4387568 for ; Mon, 12 Jan 2026 18:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768241848; cv=none; b=rQBqa8yuD87ngo4U/FODWEVmtkwIIeSmdTHXjwLKkb1h9MfjwLC7WZa93TPkUKqULWYbP5b0w2Am/YE4Bf2G5KEEHLLcg7UTdhHfhyPMIr8MRv7Drz5Tpu5V8jyQtxiLIRbi3PCCEGA4YU+Kp/2ahclquGXsYO/qypRRmcNsUCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768241848; c=relaxed/simple; bh=HZWb8NTGhICIn9r0/1N4Kr1/FZT+Sn4S6zblZ/laKMg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tVG/aUXE+p94T4DRNvRvoKbPyLGd2rH356d9hpMm81Q9+bF0hCpVU5i+gA6KulYTeyAH+7LxlFQcTxaVOfQn6FOfJjPaginw4enuSeid/JXd71S8FSW40mYKbn8FO6h0U9E8MeOK77tRlUy8WpDy9ZYaZ8ki5s/p8Psszkd4bJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GjUYMmq6; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GjUYMmq6" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a081c163b0so43876685ad.0 for ; Mon, 12 Jan 2026 10:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768241846; x=1768846646; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EtGlqg5k06i3Wt6eqTAnbJ1drNbM/2MSyECysgkVtSA=; b=GjUYMmq6ihpSNNICeV8pA9aAnEwbo7l5+C1FcMLtFJkog3GMNjZS4b+3gKO2I+kcAG G5xp1Z9cm3cNSrgWtcknFTtzEsEU6QHytB+8jouGSBN3HwUtlL3uvF3fAfuUIQlwJ6dx xMDiVzBIH4uBIYyb7Vay7ibt9JmDcXKj/UYI7++pjCiuHkPEaT3kK2dARWiBR0HSbQkU +0Y3xZgv5VJnja7qmmSwyl9dvO3Y+l7fc57oiZKCkexMUxS7jHlP+tymQ5PbsutffLVH XrgXGQsx3xMDY8/polrh2VZ8jCg28y0A1gfT2m7xpPEUoYwX7tWJXIZKjnHP4qeNiNip nBCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768241846; x=1768846646; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EtGlqg5k06i3Wt6eqTAnbJ1drNbM/2MSyECysgkVtSA=; b=kchrlEF50HQi9D1va+BlAdWDaxmwrQSkC0nUmUmS09Eyc1q25sC0sb5kpBYL1ealwJ xM/xWEyDag5fiQXHWTylK9l3aELTLaIS622ASDIgFkisOpx+LTjj4Az8Xy5CLOcDSWRr BFk4gmc/Dz2c97aVSK8ICmCxhdloGr7YWVBjZe7gKY51e4SbRQVYJg2jF7S72egExhlZ SFeWOUKoF1HdpkC0XKPa82tvubqk+rDs+2DNGrXhozkugifcDyZsojrhOphR+HhdM6h8 QhMyqA7txcA4sCvwOV9iFo+s/iSUrN5euDnM9JbOFYCWwVeIvK5yzbvCJOmkpvo+/zGc mdSw== X-Forwarded-Encrypted: i=1; AJvYcCVGIf+TcZNq3S8H0zYptBAx1cSNqcULXnifsJwSZidYjNggIUAsyTZNjyuVaOtREbL1xLMnFoO0jB4NNrU=@vger.kernel.org X-Gm-Message-State: AOJu0YzkL9bk9K2E+hB2ZBVx3dqqTHjRKLkuMIxPOZHn4GBr0B/il0Lv iBXjGLPA3oV4FZ+mqtMkZo3Wtvt3wj9udzvnPJs8RTF3nw5NmewjoxW3qQh3PQ== X-Gm-Gg: AY/fxX6yKlrHL83u/YRssFZ9IsfUBLy7DznFu01F9dcKTxXFmFYC2FR54h9enFuA8uq fA8nxWyl66UhvROQT3RRxYqRI4QOljdjX65sRsx7Janut5LToxKpZNP1SSceyyW7tx2uuE8juqs vM1GFjkx0a037Jp1NkPnbKvKllSjmdtaUJljSBaO0tQ70Rfszi2zp19uGGRYiaOzBO2EDLItc+3 GgrVeAScsIN52t7l86Wr6P9tPBoI0HPjIr/0YNex/c6Y7IM8yYPRCsc7nuyQrnqhcykQsoqOINA BttOUPTlFEW/1CTr/XiP7XiSEaoCMAzRmIDFVgNQ4P9+TbHmaEHL+peoV71+QV7nhoQAhew/xB3 wLXaDnCjz8DFm7U44ffFjGHYEDqXlz1MrpR1g31z133Mlblsabsv+MIkZ410FIWJ/HiXVi1osuG fwhTuNRvmBb6/2JGVPoeE= X-Google-Smtp-Source: AGHT+IH67SsAmDW+XdcDdNkuZHCuju5RGcFncESFWYkzYZSMHpAuj4JZCKO+lnsTd85qUcAxrMy/lg== X-Received: by 2002:a17:903:1b6b:b0:2a3:c667:e0a0 with SMTP id d9443c01a7336-2a3ee47dee7mr204871275ad.29.1768241845516; Mon, 12 Jan 2026 10:17:25 -0800 (PST) Received: from archlinux ([2405:201:1b:225c:eb9d:1fc0:f95c:bd90]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2debsm182203665ad.65.2026.01.12.10.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 10:17:25 -0800 (PST) Date: Mon, 12 Jan 2026 23:47:15 +0530 From: Krishna Chomal To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: Hans de Goede , linux@roeck-us.net, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, LKML Subject: Re: [PATCH v2 1/2] platform/x86: hp-wmi: add manual fan control for Victus S models Message-ID: References: <20251225142310.204831-1-krishna.chomal108@gmail.com> <20251230145053.516196-1-krishna.chomal108@gmail.com> <20251230145053.516196-2-krishna.chomal108@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jan 12, 2026 at 08:08:29PM +0200, Ilpo Järvinen wrote: >On Mon, 12 Jan 2026, Krishna Chomal wrote: > >> On Mon, Jan 12, 2026 at 05:13:05PM +0200, Ilpo Järvinen wrote: >> > On Tue, 30 Dec 2025, Krishna Chomal wrote: >> > >> [snip] >> > > #include >> > > #include >> > > +#include >> > > +#include >> > > +#include >> > > +#include >> > > >> [snip] > >Hmm, these should be ordered alphabetically and if the existing one >aren't, try your best (or add a patch to fix the order for all). > Ok, then I will add a separate patch to this series to fix the ordering for all includes. >> > > + >> > > +struct victus_s_fan_table_header { >> > > + u8 unknown; >> > > + u8 num_entries; >> > > +} __packed; >> > >> > Please add #include for __packed. >> > >> >> __packed is defined in compiler_attributes.h, which is included in this >> patch. Please let me know if there are any other headers that should be >> included. > >Sorry, I don't know why I didn't notice it (too much reviewing in a row or >too much multi-tasking I guess :-)). > No problem, I understand. Thanks for the quick feedback.