From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EAE34B40F for ; Mon, 12 Jan 2026 20:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768250516; cv=none; b=AXLhY1ojt3toPA27Ur82OoBSg6ipR8UZHlMS8ZP7AUfg0aGjM1CE1j5kvaKdb1ZEA9+XdXunyHALnVrtNM/MII2rHFPs+WG1oKEVB6LwZToKz9WzoD1YThY2V77CDYrpnGeF8Rq2yCg53uDYj4ZA3RygHRbr56pVJsLnzyGfrC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768250516; c=relaxed/simple; bh=0apBjH3rou710+NoTDdnZM5btsO3XXqqpLVtuopCUfk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XilCzCI+SZ4stngqn2MQ7umqcZR4PKOfnJzp1CBswMGWDIdQj1y21YXZANF7wUz3E2HhOH7K9N12/RkzPHSvM1tewaridiyaz7LHiohQgiAVNf1wiVtkmUgfs7eAXu8AnYXsvuXNNg0ykDVv+cGEebrFjG60FTs57RakbqjJXVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FrGmZyTg; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RthAx7ao; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FrGmZyTg"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RthAx7ao" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768250514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lJGgQVWpo/69kg314oK/hykP1Foddia8ADofq23KoAk=; b=FrGmZyTgzQk/1IMuXztLxf/wMkXOjAgShrNzPpNDczSz/Md1ARPwiZIPXlwe4Es4SstUH3 vypWye6E8jIvKmme9ZdufGBNvoqWBFJZUZsPkR0CJ47gxjIjRoTuFKRCALlXDSMhNJO7Lr ImDls+5OzkaQvh8JD9vC2MaE3Z7+aHU= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-eDKkPwavPPCvHGvNUVtsaQ-1; Mon, 12 Jan 2026 15:41:53 -0500 X-MC-Unique: eDKkPwavPPCvHGvNUVtsaQ-1 X-Mimecast-MFC-AGG-ID: eDKkPwavPPCvHGvNUVtsaQ_1768250511 Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5637112ac92so6768301e0c.0 for ; Mon, 12 Jan 2026 12:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768250511; x=1768855311; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lJGgQVWpo/69kg314oK/hykP1Foddia8ADofq23KoAk=; b=RthAx7aoRr+qHxtaKm7KBLUs/RXq102tui+Tpf6aArtlezulp2gzYuRqKC5C+VJeg+ L/VUk8A0khNQnxk0hRXeCNftZF7lHulNht7Ct0J3900ZSksucAy7VkI+MixSveh3o/8D 0ok+2Hr4OOam1zUFS4DN4EnwOozbfPY8gJL1PS/IyBjLudbudV1mm1fjf4sNgJx8gG62 v84UwbT6iCkBgbbVvGzjRMaNCMXZ7QiPPFdX1jaWZOAkGo4E9pQODrIS/7r02c6+GIHg 6F9qGQCPCA9QRiXBr+G4oXpl0QHz5dKjNSSbKe8jYxvbxrIvnJUmmWolbjfGhvOmhRQn gAGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768250511; x=1768855311; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lJGgQVWpo/69kg314oK/hykP1Foddia8ADofq23KoAk=; b=BEXHn0qbH3tsjVEMNwMJwS6+a/nL0O2OFd9zo+S8+MofNZ2Z07J9dNo9bcdCrmeFjD 3LaNuXrT+4QiBy4KvMPQJ61KG5akj0BmttEy13mp5U7PsdAMAVWr2BTUw1M0Lr/dTZTx 1qdokdcG5k36nNCGe9xBNxq/I+XBRnHtbiIPWhjmUBAqQOs7ft08Y9XDY9Pk3IgMSs7k +fSpD+4VClma0p35xRjUUV2X5/8I05uQdKNUV48romYfOqRAZA5hOeEcspYH4Ojd3vSh EA7olY3Wd+b/aTdhzRjlWzN3b2V8Obw/I5OMCHIBWPqayhk0gvL025d3yiugf0hWdZpP t8OA== X-Forwarded-Encrypted: i=1; AJvYcCXzpGAT/GUuwSoccqwc0D3j4OQqsvwDx0n6E2/RmKp1chnu4s1Cwll5z0ejgXx3nh1uPjqeX174r3Q9a2w=@vger.kernel.org X-Gm-Message-State: AOJu0Yzee7n1A3gUn/FK92jqjTMilasMmKOObERpY/tK1UUVrNSo+qVu I0WMFYEbe4yLcpxlWRN8WA03QzhtDay7BPUUeagEUFbS6upP/+icDsWsM2GCbbozsQBHWoK0Q/L G9BiLQ2TC1JynbupleDEDllIcg4CIAyFZLRbgl7gtYEaMY+VWwAou7l8r2orfi9i2VQ== X-Gm-Gg: AY/fxX6ISenY28ctOMKyjJ7aG1tG+w2GCXi3hwr0vvaGiotY1sbm4h2SF/L6tHZkN+F fvU5LNFdsOryggIfWviptPYcJFzVTyIdzuhPGVu/es2qDmKyKlptR+N1SnVYMy145kA1P50yHe5 eAl/rHv1ygdMfObcpXlXlg7L5qJQ+J02TX5SqvBLAN0VrK5eyhO0JpLqLyZU09RTQku/4uWaEgJ F8RjpEwxzrUK4Rr9qHvK8v0mMxTzl3ahplGLcwdozlLF+i26lWKXfWsAKclx5qELHZbqS6Ep+kb SWB8Y1PcEW2aMcORlXagkK4bCkEf6UU9bN6pXDJCp/aeaIp9RGG4XNKcmF8L31xpwyix8WCz9/i YWmIswjZ1 X-Received: by 2002:a05:6122:4309:b0:55f:cae4:250c with SMTP id 71dfb90a1353d-56347fe2117mr6518851e0c.13.1768250511490; Mon, 12 Jan 2026 12:41:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/msJiDuMXiXTu1d5lyXSrw5TlNlZCRnExLgQ5LkAkcKPzJssyw7fe6CUA6J4kH+M+WlVMwg== X-Received: by 2002:a05:6122:4309:b0:55f:cae4:250c with SMTP id 71dfb90a1353d-56347fe2117mr6518846e0c.13.1768250511175; Mon, 12 Jan 2026 12:41:51 -0800 (PST) Received: from redhat.com ([2600:382:771e:5aa5:103f:e4ff:d734:7cd4]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5637f6ce00esm5551865e0c.0.2026.01.12.12.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 12:41:50 -0800 (PST) Date: Mon, 12 Jan 2026 15:41:42 -0500 From: Brian Masney To: Claudiu Beznea Cc: Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/13] MIPS: drop unused pic32.h header Message-ID: References: <20260109-mips-pic32-header-move-v1-0-99859c55783d@redhat.com> <20260109-mips-pic32-header-move-v1-12-99859c55783d@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) Hi Claudiu, On Sat, Jan 10, 2026 at 05:28:32PM +0200, Claudiu Beznea wrote: > On 1/9/26 18:41, Brian Masney wrote: > > All users of the MIPS pic32.h asm header have been migrated to > > linux/platform_data/pic32.h, so let's go ahead and drop the unused asm > > variant. > > > > Signed-off-by: Brian Masney > > > > --- > > To: Thomas Bogendoerfer > > Cc:linux-mips@vger.kernel.org > > Cc:linux-kernel@vger.kernel.org > > --- > > arch/mips/include/asm/mach-pic32/pic32.h | 36 -------------------------------- > > 1 file changed, 36 deletions(-) > > > > diff --git a/arch/mips/include/asm/mach-pic32/pic32.h b/arch/mips/include/asm/mach-pic32/pic32.h > > deleted file mode 100644 > > index 53918a671a4c39dba2a22121187cdd73e1935b24..0000000000000000000000000000000000000000 > > --- a/arch/mips/include/asm/mach-pic32/pic32.h > > +++ /dev/null > > @@ -1,36 +0,0 @@ > > -/* SPDX-License-Identifier: GPL-2.0-only */ > > -/* > > - * Joshua Henderson > > - * Copyright (C) 2015 Microchip Technology Inc. All rights reserved. > > - */ > > -#ifndef _ASM_MACH_PIC32_H > > -#define _ASM_MACH_PIC32_H > > - > > -#include > > - > > There are compilation errors when building pic32mzda_defconfig (see below) > and I presume those are related to the fact that this include was dropped > from include/linux/platform_data/pic32.h: > > ../arch/mips/pic32/common/reset.c: In function 'pic32_machine_restart': > ../arch/mips/pic32/common/reset.c:27:17: error: implicit declaration of > function 'ioremap' [-Wimplicit-function-declaration] > 27 | ioremap(PIC32_BASE_RESET + PIC32_RSWRST, > sizeof(u32)); [snip] I only tried compiling this on arm64, and that compiles fine. I setup a mips cross compiler on a arm64 box and I can reproduce the compiler errors. So linux/io.h is not directly used by this header file. I think the correct thing to do here is to update the files where it's actually needed. There's 3 files that need linux/io.h, and one file needs linux/types.h. I'll send a version two of this series with the cleanups. Thanks, Brian