From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C0B30F54C for ; Tue, 13 Jan 2026 08:41:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768293689; cv=none; b=Qr60ebTVFDqXBxQDxNrYTcftoptftLb3pAiHdYL21GMMQmn5T9jSD7b/ftqH10558QHg2TnHzcCwaiyG8EtYa2O9FKwoT5fTrWxtzETCAN5XjlFWT3JG5p8EVS+YjdkSLSrKG14kzxmJC/6UKYGuR68XtAxfvT4uWlNDXLN467k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768293689; c=relaxed/simple; bh=xZRATluBPZAyTKFAutP3k1OrOSVGqvzN2Vz4PyDzEgo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RtEwdmzxf/pRMx14x8QKdCiu2F9hDj2r16l5tqd6nEuDmiuCu1oOutQCWwg7CXMf7bahQ3irP/jW0Zo8NcuMjgJjQbBGswMY1iAQqQ/WL5wjunWJMZzV27Az89tSbOzBQojmWcOsDBMIjQxLRIrmfqCdyajFropueT+iTY2kl10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Muj6Wn6f; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Muj6Wn6f" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-81ed3e6b8e3so1524526b3a.2 for ; Tue, 13 Jan 2026 00:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768293687; x=1768898487; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v2EyNlK+aZoaRqJlBpndyOFFC/3Kj5uE9k0EdvFI4O4=; b=Muj6Wn6fP4PzRXWsw4hxV4EtuMHlOU/f6o6FVqnLEmRxPmSjDr3jdwc7MoPIsXVYfe wEx2s0X9OwHeGknvtEL8VhoQITO66xkWgeqFkn0aaJPITlcZW9vykjtEcIwPYUjCC7UY WmCkeMnypHkfs3ADU8oGvM6jS6HB1oxYXFkZUtC9f0Fc23OtH4Kr0ARu+FXtKmhTp3xG kWJKrb7JCvGg0yqBeiyr4Et2Ivn0lG1IlnWP9Z2CxD6FQlbRlQ2zKWRI97yjoURw2JeL HL+Zp5pEcrxb4lTCYPdqawrZLY1wqxdIQPKZSWfTPQK6VYqJn3xpXD4PdxmxicB+LrMj +Yig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768293687; x=1768898487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v2EyNlK+aZoaRqJlBpndyOFFC/3Kj5uE9k0EdvFI4O4=; b=aB98tAIHfKUUGO7e7JOJ7fcjU8IfxLa43NvfgM83Ues14G5ZJFSirGNGGSKpMwZyuM bnWkQkRkEL0LioxyeC+9b7yLw6q6nVRE3CtvKC14kQpOYv8uOOCb1iSCIpDg4j/mB5CO WfPXoF3k47Bhojsf1ud44ftIm0Z+tSsTImcW/KM/LMCOqkp+Z8Lh86lSrRSkVeKwUiel v+DFmTvQlCqKugiSbfl3dpE5TkVWywv6YztNoN0yWdIQ4Ntpv6Sn569HgHrG9hRq2P3z vRo6oQW7KbPMi4kRsgRt+UZoE/U10r1FGgj1tQJdvYXnlY72YpPABqAFEonavA87cRIY PyZA== X-Forwarded-Encrypted: i=1; AJvYcCWfYwmXv0VaDBfoTucwFsGel7V+E60eQx49wGfzkRFIop2n6a/z3MwlGVv1KMfSm2sTjkybpdyxR/t4NdM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtcz9XV4RWny9FSPSLX8I1ICU3BjX8hJk8rb1oORtNyNB0ddWZ 8mNppDZcZ+HCcKbpQBrVvlLqzzseZMzHKU7n1yJc0WamIP/DAvZ7zP6S X-Gm-Gg: AY/fxX6OXXKduTZt1KO4FGwSK6olpj+/uJE6YblEO9Ex0NlKkZ9BckxvJ/01wDI+NoW qjYH6vXD1zqYke0vacm1WuwdtFaPcO1I0/IF034ieMdO91iNZwYHxvgwwO6an9zKvdSEQAG7IMm PPEYY0ZJfGOC3qf0M2prcWBPr6IX8tKcojp3KB9p5UzuCSX0eVAmRT97t0vQLuydCzNH2fTEGj6 eco1Hy+082izqZbgmbtbpaDVRWfvrwFEpjeYhqyep3JFoMgaT2N0SAVF3ocSQjSTPzr9vo9UX55 PqtaTEEkPN5irbhH8koPIooJoVWuXW5XJgw4do9YWanAXnZ9lcZosR0qQ1eSekMjOM4lc1CiErv qXbKGJnEKCDGwbNRmb+RsEi5bJvM02dzWUFIPdl83/MIovnQNZ/Kx+EdXVpjiqg7e62CF25rGfq 7H5/20RWO4s9bjXkhZQwT/LRbWWkgMUVZVHFOl X-Google-Smtp-Source: AGHT+IHpLPYkPySrRM8NmbPzP2Q1RxYCl/B4V+N4TTL1wZFw5QCdM1Shg/eqNRNECX7PLEueCT6sLw== X-Received: by 2002:a05:6a21:3286:b0:37e:4319:d7c8 with SMTP id adf61e73a8af0-3898f9abb78mr22198504637.75.1768293687488; Tue, 13 Jan 2026 00:41:27 -0800 (PST) Received: from localhost ([45.142.165.150]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cc95d5c66sm19240653a12.24.2026.01.13.00.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 00:41:26 -0800 (PST) Date: Tue, 13 Jan 2026 16:41:22 +0800 From: Jinchao Wang To: Luca Ceresoli Cc: Andrew Morton , "Matthieu Baerts (NGI0)" , Carlos Llamas , linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/decode_stacktrace.sh update usage to show vmlinux is mandatory Message-ID: References: <20260112091057.2119227-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 13, 2026 at 08:57:03AM +0100, Luca Ceresoli wrote: > Hello Jinchao, > > On Mon Jan 12, 2026 at 10:10 AM CET, Jinchao Wang wrote: > > The script currently errors out if vmlinux is not provided, but the > > usage string implies it is optional. Remove the square brackets to > > correctly indicate that is a required argument. > > > > Signed-off-by: Jinchao Wang > > Thanks for your patch, but it is not correct. > > The vmlinux argument is optional when debuginfod info is found: > > # Can we use debuginfod-find? > if type debuginfod-find >/dev/null 2>&1 ; then > debuginfod=${1-only} > fi > > if [[ $vmlinux == "" && -z $debuginfod ]] ; then > echo "ERROR! vmlinux image must be specified" >&2 > usage > exit 1 > fi > > (https://elixir.bootlin.com/linux/v6.19-rc4/source/scripts/decode_stacktrace.sh#L65-L74) > > However I realize improving the error message might make sense, something > like: > > echo "ERROR! vmlinux image must be specified or debuginfo must be accessible" >&2 Thanks for the feedback. That sounds reasonable to me. > > Best regards, > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com