From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E40F5389453 for ; Tue, 13 Jan 2026 10:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768299361; cv=none; b=b2rUaMisrItdqvQR/TnRjY8m4qMZy1X2rCF+df5SaEOi0kCtPG9T0nPOH6aeEwroAmN4NJlCBWM5bXi7oWiHGlMzA6Za8TxD2ZCrK1S/tCEjxirNnu9SbRphKWPB68coheHvj7FGK7GVGZdgDjzTmIdbrsVWCU03m4DbijiYDq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768299361; c=relaxed/simple; bh=hzsmJm6k/s53Ih1F0K+RHcrgvnz1CoHDn9zS3SiVuO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dHoSlR61MIuqSOxkKQ1o0GFq3N1lMQB6AicNolGKH1wkMsipaC+3mQUWduWwD/A4/OG99mGoY9uapEEThTjL1qhjU3gmCi29QmWksG0o0+uUJaGn+s68oL4wkoI9+W2dm0CwcePsokYDe3qFBQaxy2VHp4vaEb/N+Hqjh01/69U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Kd+BO1aC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cdIl1BYO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Kd+BO1aC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cdIl1BYO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768299356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v41BmWMTW4tZcwktDmX8avT8k5SvIiig6VFNmXgetXc=; b=Kd+BO1aCunnEZCT0zrVCyHle131ZtjJdl23zce4cpxRASuyW+T8WyteHLgsP4U63Hpjfq/ kVlvtG9wgcszUXr7NbjjgvNdEQ0iexYeF5SbVUmbdLsj+s5mAswhIU2oT8j7yIds99HNHY J1v+2jl0SGa0lSlDuOnQGqv732W82L8= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-3EnYbwVMPgSnyGqr0zeyLQ-1; Tue, 13 Jan 2026 05:15:55 -0500 X-MC-Unique: 3EnYbwVMPgSnyGqr0zeyLQ-1 X-Mimecast-MFC-AGG-ID: 3EnYbwVMPgSnyGqr0zeyLQ_1768299354 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c552d1f9eafso6258931a12.0 for ; Tue, 13 Jan 2026 02:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768299354; x=1768904154; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v41BmWMTW4tZcwktDmX8avT8k5SvIiig6VFNmXgetXc=; b=cdIl1BYOAjagu6R3olIkVg4jr3s0/I1YGgNTPxjBrLCjD2b8pyk/N+oiNhdThziLD0 FdazqmnVet9ssXV1uX3BDi+Kr+M34dSnWVQcljy6tyLf8zNL2g2zLkOC8p10KneMPIJw zgBOaxKRHxh8DXnN5L5qcYXp2RVoYGROsrWTuqrn9fy8Fi1Gdv2Jo5f4ZP6cDrCG+YTu IIj6LIOmxOb47ev+QkfQAuwO9n/aFI283ZoXec5QyWs06/arTrAIgKcWCVPp50Ugh7S1 rBELvX6dkL/+Ci3qOIj+ZB6cyMldhyVuR2zaz3OdT/WmBEU6xu8ARGmnUDPA74+J6ySj Mjwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768299354; x=1768904154; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v41BmWMTW4tZcwktDmX8avT8k5SvIiig6VFNmXgetXc=; b=msIrc/l/bXGP/86T13znfOn0mQ7RXtH6B8d5UvcnGc0KNbjik1yx26LDpa9Qt34/1k uQoruBSYwGbSy4jqBRJ2uyc2WslipND+cXR+NL5Cta4u9b7fZc79RbHUIYh2WjCYMFvX 8549u+35OYh2WyIoFKhx9k29wervR/ZW6sBKYYgc5j+3U0XNx7GLvetsS687fJ9USNio yUYrjLmM+gWThOoL0Bj7JiK3gS2rUzwtzCQtO9+wDdzh84zyHZuZ5fXHmAF0xSmSpxBg s8DL/a5nKvrZcmmNcmnzIEmKSyrfIu8v6Eh8WVDpp0rNPcTALSLIZygHXbRHEnqfVD70 qOVA== X-Forwarded-Encrypted: i=1; AJvYcCWZKgsIjcN0mP9i70ETUflUTTmHJWB36OCVGDxlG3bihRhjmrEM+BHODOLw3lzxoQ8DaDkiC5pgt8hzgE0=@vger.kernel.org X-Gm-Message-State: AOJu0YxYdM0wtFedmcB2zvZm+FGazqjGdDoZ++9YL+P+zSxZsQubKPcJ sxbgpPr/l2YoCnT+4XIiof9cd3DmbdiwIAjoc3TgTiGk0SZpH/ah/zOlxvBb8eNhn7ZRxpdxR0Q r2jZc+gwrfbhxeF18vnaSzRD32wmM0Vlt7bo3Ohknepj0u+X9HnndUOhMKGLc6zFiwA== X-Gm-Gg: AY/fxX69jbPwwgLZ7fbqGhO2cBvfJPp6kUQlmNIJUpkj9mAKMLpuDBpOOqBNKyqC0y/ 8MkT6GnFqHtlhPz9YDGGKHVJH/+Ssm9ORw6kHLX9cQTjCuOSJcFsBQEE2heos8Lue98IUQeH/Aj gCKGTOUNJbNQ6hjnwdPhUcqp+3FoZsQtsm7rTOalQJXQtVEdBcQsZX0lCeiuDPdVJKT2JjQ6maT a+3sWQ90OKkbqiWTrp3Ku5CrreA6TH2Z+SJD3pDoOCVv6PYxcw2KfuiL7agSv0mlN/5D6ncCZCf 0YQQ1/+ZuBwceZ/Y95RPkvmMO03v+ZKLhp1nUngXsThHRdlK6wDboW7UAa+QnA5SEMz5HpzecJN 2 X-Received: by 2002:a05:6a20:1590:b0:350:8f99:367c with SMTP id adf61e73a8af0-3898f9c749amr19677845637.58.1768299354390; Tue, 13 Jan 2026 02:15:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGD8bVnhUW9rLwnM9mhHYysQ2ifqzdkq+BFmkuSXqdWfOtq4JZykE3GdXdZeED+1VsDF8ut7A== X-Received: by 2002:a05:6a20:1590:b0:350:8f99:367c with SMTP id adf61e73a8af0-3898f9c749amr19677814637.58.1768299353782; Tue, 13 Jan 2026 02:15:53 -0800 (PST) Received: from localhost ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cc9e7e824sm19776837a12.30.2026.01.13.02.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 02:15:53 -0800 (PST) Date: Tue, 13 Jan 2026 18:14:38 +0800 From: Coiby Xu To: Borislav Petkov Cc: kexec@lists.infradead.org, x86@kernel.org, Andrew Morton , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH 1/2] x86/crash: Use set_memory_p instead of __set_memory_prot Message-ID: References: <20260106095100.656292-1-coxu@redhat.com> <20260109201142.GFaWFg_kR8eW48CpUp@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260109201142.GFaWFg_kR8eW48CpUp@fat_crate.local> On Fri, Jan 09, 2026 at 09:11:42PM +0100, Borislav Petkov wrote: >On Tue, Jan 06, 2026 at 05:50:58PM +0800, Coiby Xu wrote: >> set_memory_p has been introduced since commit 030ad7af9437 ("x86/mm: >> Regularize set_memory_p() parameters and make non-static"). There is no >> need to use __set_memory_prot. >> >> Signed-off-by: Coiby Xu >> --- >> arch/x86/kernel/machine_kexec_64.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) > >Why aren't those a single patch? Hi Borislav, I thought smaller patches are easier to review. But seems it's unnecessary for this case. Thanks for squashing the two commits and also updating the commit message! I notice you also added a Link tag. Does it mean there is no need for me to re-send your new patch as v2? > >--- >From: Coiby Xu >Date: Tue, 6 Jan 2026 17:50:58 +0800 >Subject: [PATCH] x86/crash: Use set_memory_p() instead of __set_memory_prot() > >set_memory_p() is available to use outside of its compilation unit since: > > 030ad7af9437 ("x86/mm: Regularize set_memory_p() parameters and make non-static"). > >There is no use for __set_memory_prot() anymore so drop it too. > > [ bp: Massage commit message. ] > >Signed-off-by: Coiby Xu >Signed-off-by: Borislav Petkov (AMD) >Link: https://patch.msgid.link/20260106095100.656292-1-coxu@redhat.com >--- > arch/x86/include/asm/set_memory.h | 1 - > arch/x86/kernel/machine_kexec_64.c | 5 +---- > arch/x86/mm/pat/set_memory.c | 13 ------------- > 3 files changed, 1 insertion(+), 18 deletions(-) > >diff --git a/arch/x86/include/asm/set_memory.h b/arch/x86/include/asm/set_memory.h >index 61f56cdaccb5..4362c26aa992 100644 >--- a/arch/x86/include/asm/set_memory.h >+++ b/arch/x86/include/asm/set_memory.h >@@ -38,7 +38,6 @@ int set_memory_rox(unsigned long addr, int numpages); > * The caller is required to take care of these. > */ > >-int __set_memory_prot(unsigned long addr, int numpages, pgprot_t prot); > int _set_memory_uc(unsigned long addr, int numpages); > int _set_memory_wc(unsigned long addr, int numpages); > int _set_memory_wt(unsigned long addr, int numpages); >diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c >index 201137b98fb8..0590d399d4f1 100644 >--- a/arch/x86/kernel/machine_kexec_64.c >+++ b/arch/x86/kernel/machine_kexec_64.c >@@ -673,10 +673,7 @@ static void kexec_mark_dm_crypt_keys(bool protect) > if (protect) > set_memory_np((unsigned long)phys_to_virt(start_paddr), nr_pages); > else >- __set_memory_prot( >- (unsigned long)phys_to_virt(start_paddr), >- nr_pages, >- __pgprot(_PAGE_PRESENT | _PAGE_NX | _PAGE_RW)); >+ set_memory_p((unsigned long)phys_to_virt(start_paddr), nr_pages); > } > } > >diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c >index 6c6eb486f7a6..40581a720fe8 100644 >--- a/arch/x86/mm/pat/set_memory.c >+++ b/arch/x86/mm/pat/set_memory.c >@@ -2145,19 +2145,6 @@ static inline int cpa_clear_pages_array(struct page **pages, int numpages, > CPA_PAGES_ARRAY, pages); > } > >-/* >- * __set_memory_prot is an internal helper for callers that have been passed >- * a pgprot_t value from upper layers and a reservation has already been taken. >- * If you want to set the pgprot to a specific page protocol, use the >- * set_memory_xx() functions. >- */ >-int __set_memory_prot(unsigned long addr, int numpages, pgprot_t prot) >-{ >- return change_page_attr_set_clr(&addr, numpages, prot, >- __pgprot(~pgprot_val(prot)), 0, 0, >- NULL); >-} >- > int _set_memory_uc(unsigned long addr, int numpages) > { > /* >-- >2.51.0 > >-- >Regards/Gruss, > Boris. > >https://people.kernel.org/tglx/notes-about-netiquette > -- Best regards, Coiby