From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14F8A277016 for ; Tue, 13 Jan 2026 13:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768311237; cv=none; b=rE52eCTI60F/ldiFsQVHEcD6EFHYTeLV9M3EIvYSZHAgOsgnrVq67mSTOZHz9XzGhClE9VuUzm3waBU4LjpdeI25JS+QhmctxybTd+vycNwyaY+b+C5cbZ9ttZp1tK2F2XpOsHKbMYpT2WCiGpc/GbdJjvle4mhUoyaNL5Ya9oA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768311237; c=relaxed/simple; bh=nJn/IgS2fQ4v0logMt+CBQKLENdUOAdE0tT1/1E7ec4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f/vGI7ZltfwhKjUjbTp34ShusgG/bqTE8hSC1MFOyELTKIuhJtfVyo0iAhlv8WCUu2TVbOKcB8qW5bOpmNDkCHOw1fjxPjo/UarTL6LNyld55JgxW2/Uzhi84zHc885UsOPcwIyrRyLUtoXa3Q4Ckf6P7lzIbtsNXHCL0MQh6/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=Fjm5kLVE; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="Fjm5kLVE" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8b1bfd4b3deso670830785a.2 for ; Tue, 13 Jan 2026 05:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1768311235; x=1768916035; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e+TrcPiNJqx+gnXGDZ6bofmiej5uYIiBxFLYJ07vJ3g=; b=Fjm5kLVEoFp9+qyrA+upskKg7lKiuWxhzeaCrMLPFGi3cSB9KGDALfGU7rMGEE1mpa OWEnDXSq08/wPdk0B9mMXhae3D38TAWmuoOr+3TxQk7zo6sWQbv6MHLW4vq4IZOocEPZ N9JGuEZqxpB90gkPZywLR4K+lER+ipPN92ZpgzwqmTd5khOVb6e4lX1v+qcqL6/w1ugO 5gCiRKWoPvAITK8d57CrEZ1ZxfJmkI6YQCunVZ6es4hvJvzCzYqiT7xguWe+Hebd2BYq NTy9t3Vssnk+q91zzvhygakKA/lg/ndsEy5bQKGYPw288FWG+K9ybNRgapoZnRvOlnGK pWEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768311235; x=1768916035; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e+TrcPiNJqx+gnXGDZ6bofmiej5uYIiBxFLYJ07vJ3g=; b=SciWj+I/ysTjb/cQM/IUQ3fMRkCB1ix7cjBB8IlA8Y/okFjFnvxBf/p/AXod5byiMz xpnSP4O3gA7xCcTbk3WI1ih/S/dqk9tGo5IVR+vM3N9Q1FN5bHrGNGEZZ0GPdYwTWfDF HJjlGsIudZqlr4IPgst0rToqQvlcXD4qK5Hfnh0TpG+9Y/cu7A02m4+8aI/qIn4v19SN NVuNGZV2GI4FJa/4g9O+BG1w3ERF8V5jYC9USUDlYHVyqsYFSyAOKIZlcMozHkCt23ib sAOXS1hk66SlfN/ykHkd/NEIKMVzo80cDoHXk4gyUQd4vXZyTtzfBzXVzIvb8k0r83DI iMZA== X-Forwarded-Encrypted: i=1; AJvYcCV/emXtzkL/NO0zG9/Xme1Q9cdusBL9gHLIP3kRNxH7RJt//927Qp2JKpFk1RcPSPcKoKOMB/sFK6Dfdgo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx22Vlt2rERnovKCQNnuRXijaSK1apkdpWQxr2FtMEy1ffdsnie uiHTY9WuO35lskHa3+XYHyHSBizbZWPjwVdwwjxgziKavLbzRaHwbraPGiOnPdO+L5c= X-Gm-Gg: AY/fxX7Da8856W4FvUS4yvIgGiRCftMu+sCV4rwwDO9+dy4KjjP5uxRg3hngft0Ew0f KB4zKgLi4/OguAnx8+VHOg4ndMwpYmQ3SVoO5pzsnxKSXEyMQNRTfA+PoIKX1ej8ndn6/a6T8Hu wWUb5vwoHS33KDV/BoiuqxlJnx0KjD5siTdBZ7G7jffIXe6ah41HiUDv59GyPAet1Bmwk2Z8aT8 04ttY6XBdczVjO3ctBmtEQ2ro9Zz6Pc31Rym97yYE1muPRWnhlsL1n8OGBkGL+5OMUy4RhScAjr k8LlwiuNFwoa4rkh/gqZIxf2ZQ4LwGjsfNYS3HuGVuRA9f74jzEaVYdIiVozlRr9E5nvaHwk3As xXTpOfE0uW4VDBGgNeR1Wueduapd3UcM17F3YF/0aotqKidTS+Gd8FihMnD0Awh6XG5aMmX7jzx 5i6hCIaaUy42/KRvz/a036ojhL5NvClE0bnJZAEo7OBlkJYv77mVT69OQNPbm08ObJyBi0mg== X-Google-Smtp-Source: AGHT+IG89U0CT8ITbK5rc7fc4hjt8fIdrG81Mm2wdS+7eaGchNv6ND35gsVJ60oW2+UHlaYLTvZRJQ== X-Received: by 2002:ad4:5cca:0:b0:882:3f45:c811 with SMTP id 6a1803df08f44-890842dc572mr316656616d6.61.1768311234825; Tue, 13 Jan 2026 05:33:54 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770cc7b1sm154860746d6.5.2026.01.13.05.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 05:33:54 -0800 (PST) Date: Tue, 13 Jan 2026 08:33:20 -0500 From: Gregory Price To: Neeraj Kumar Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, gost.dev@samsung.com, neeraj.kernel@gmail.com, cpgs@samsung.com Subject: Re: [PATCH 0/6] CXL: Introduce memory controller abstraction and sysram controller Message-ID: References: <20260112163514.2551809-1-gourry@gourry.net> <439928219.101768297204618.JavaMail.epsvc@epcpadp1new> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <439928219.101768297204618.JavaMail.epsvc@epcpadp1new> On Tue, Jan 13, 2026 at 03:07:49PM +0530, Neeraj Kumar wrote: > Hi Gregory, > > I am facing compilation issue with this series using CONFIG_CXL_BUS=m > {{{ > AR drivers/built-in.a > AR built-in.a > AR vmlinux.a > LD vmlinux.o > MODPOST Module.symvers > ERROR: modpost: "device_offline" [drivers/cxl/core/cxl_core.ko] undefined! > ERROR: modpost: "lock_device_hotplug_sysfs" [drivers/cxl/core/cxl_core.ko] undefined! > ERROR: modpost: "unlock_device_hotplug" [drivers/cxl/core/cxl_core.ko] undefined! > ERROR: modpost: "device_online" [drivers/cxl/core/cxl_core.ko] undefined! > ERROR: modpost: "walk_memory_blocks" [drivers/cxl/core/cxl_core.ko] undefined! > make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1 > make[1]: *** [/mnt/ssd1/neeraj/dcd/cxl_env/cxl-linux-mainline/Makefile:2004: modpost] Error 2 > make: *** [Makefile:248: __sub-make] Error 2 > }}} > > Above routines are not EXPORT_SYMBOL_GPL(), thats why with > "CONFIG_CXL_BUS=m" its breaking. > > After adding following EXPORT_SYMBOL_GPL() below their respective > routines. This issue is fixed. > {{{ > EXPORT_SYMBOL_GPL(unlock_device_hotplug); > EXPORT_SYMBOL_GPL(lock_device_hotplug_sysfs); > EXPORT_SYMBOL_GPL(device_offline); > EXPORT_SYMBOL_GPL(device_online); > EXPORT_SYMBOL_GPL(walk_memory_blocks); > }}} > > Can you please have a look? > Much appreciated, will fixup! ~Gregory