From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A0233D6F3 for ; Tue, 13 Jan 2026 16:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768320013; cv=none; b=KwzOsLXSZ1AdUK/5DF3tyjtO0UKsgae3pXbx5+fgJ/E0qXx1vVT0c1+PTEBk7Kf1B8+bEn0BP7rjgagbyIUhSNhAqASQ/PNAj9u3P7dPQIEC2KhiTp6O3i0LlOFRVtxigb93wPo+bQppxY2QgDppNMoUyKTCl3LHyFIHvHDOmNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768320013; c=relaxed/simple; bh=H+TB3d+EiLLhwpp/yIISVZO7gY+AdJjC08uGkemLUJ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qvoaPE/kaX8nfPC2O34nS5VfTrnd6esyxsoZh6+DOYw08H7RvtncZ2KTe5fEalw0V6OtN49GhCe3x663QCsM1tATuT8aWrfBNM1xiDWo2JgoOByczOyz3kL+ezzMRWrO8HCOfo/ZHrnNCMB65cR+6vK/ztOaDQ6/H/CjYp4K25o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=ndaURpbT; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="ndaURpbT" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-450ac3ed719so5065471b6e.0 for ; Tue, 13 Jan 2026 08:00:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1768320010; x=1768924810; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XsuX5yajvw+W6Z78crCjYLRBYcrX2pWpa1tg2qXBFGs=; b=ndaURpbTxuaAgofXOB5aa70U3AbLr9KlIlZm6nLf4cl9xUmuSln65JpLDhPUdQpRN8 FUk3aV3RZHpH4wPikOaMT12e/Rxfz17NWxcNsrj/+BefxDssfbPpAN0z6UpYGegwu6e2 bO+OuekcXv0TY/Js6HkH4DKLTU/gUuWTxNXwh1f06IPet+l9IBRxedJunOWq221Ic1Ul jSuWOGEt15EK0vECW0LhANZBsoYSSarMH7rb1XfpDNXwU1iOnivJduvI5ZxpatxieVGf izMtj2CEqKW2qkBkKjeH97HNvVSxCdyt0KwB8KvYoSCsU42pSUKQydpZyINx2ZVH3E5c DQBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768320010; x=1768924810; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XsuX5yajvw+W6Z78crCjYLRBYcrX2pWpa1tg2qXBFGs=; b=Hxu7h4KZLgbYeWjG/Qv/u6IlEE7p9kmQHgENSB5x9P7mr9/6A/o8og/nvAdw15SWLj vqq2OX14PkHmmBzb/FHVHrxTWxyqr71VSsk249g1hnqMI6FFjebpPBdgaAs4wZGitr3v kJDAeMyxKrPROkVscs8Hp0BveiIWAKc9+Fw6NgZK2HR6KJnfKRnPPz/AjyHFdx1FSe6P P8UTTY4Mx6gASdq5SLUvMCXcYN6dq9YmqM1PJQFlFX2alN0T4mZ5VIsW6GO4MIupFOPS nZJAE64agi1GrO4fHtnaBWappCrt/DPAc909VjaxSixQ+FoPx3Tq23P1j764oqv7/VSV RhSQ== X-Forwarded-Encrypted: i=1; AJvYcCUH1z7Sdms45RrfuDfUotA41v/VNhn1C13y8qY9QvHn96exRRuzBY/G8WZ64NQ/zDBURc3QoIL+8YFaRow=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/m6bDxGGFpu1iKOlP3jsLxSXNPvwYuKAM4HHfqP3CpNv8gJau 88J0LJrFV5ZYJG8WTbHlmyFU0+uYZ2f75Gn09RiePydF66+Ax2PVONdfdgHSbe0JiY8= X-Gm-Gg: AY/fxX6wQFkrDtsI9VKhdeqEZLpUSEJp0Z/cWmePN6zwO7Hd71+6mQyf64k7bV915Gj JEvJ30JjZcrADbz/merVijyRqt+AWC2VmOPXwzakovMuqpDL0yvaeVLe8JDu5m9PRDB/kVBDcu0 9FRDOO4Nz3qX3/tkXKQKZIsJl1KC6hEOFc06fwaN6mtY6utiEpKlMgDSQW/ZFdnnivaAW5RHprC AhFtYXB/e2JmSMVmJhuuxUOqZRFGG4+23X6WW0zQ2DqQFQyq19dYV7MLwoeeo1rKfK4tuSAXk6H i1VHj1GIvcjvctQaCk4AgIpzkHg7DTjXAJQw9hPdZuq8upfqD/HWf/zpszF+Gg5XUjuToxsiu3J sKda1siaAUoF8MKyrgy7vhavxOo+TgAiNid+zxAkXWo+qHQRmoSvMLwTYpVO/DhenML8vxN+qa/ kbBJHUZ9wf7SrR X-Google-Smtp-Source: AGHT+IEExdJDRJEkeBH1kARx4YS5Zq9oUtRgvBa1H5KYRB90PjXpF0Uq/j0UBh/X8e4qVkbh188kGA== X-Received: by 2002:a05:6808:c2cc:b0:450:390e:61da with SMTP id 5614622812f47-45a6bcd9ac6mr10834806b6e.5.1768320009101; Tue, 13 Jan 2026 08:00:09 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:a63f:8616:7723:f65]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45a5e2b74e0sm9601105b6e.16.2026.01.13.08.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 08:00:08 -0800 (PST) Date: Tue, 13 Jan 2026 10:00:02 -0600 From: Corey Minyard To: Matt Johnston Cc: Andrew Manley , Corey Minyard , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: ipmb: initialise event handler read bytes Message-ID: Reply-To: corey@minyard.net References: <20260113-ipmb-read-init-v1-1-a9cbce7b94e3@codeconstruct.com.au> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260113-ipmb-read-init-v1-1-a9cbce7b94e3@codeconstruct.com.au> On Tue, Jan 13, 2026 at 05:41:34PM +0800, Matt Johnston wrote: > IPMB doesn't use i2c reads, but the handler needs to set a value. > Otherwise an i2c read will return an uninitialised value from the bus > driver. This is fine, I suppose. It's probably better to do this. Are you actually using this code? How was it found? -corey > > Fixes: 63c4eb347164 ("ipmi:ipmb: Add initial support for IPMI over IPMB") > Signed-off-by: Matt Johnston > --- > drivers/char/ipmi/ipmi_ipmb.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c > index 3a51e58b24875497699c7af7a4af1c73b47653f3..28818952a7a4bf814b95bdfb7046672ad4526cf2 100644 > --- a/drivers/char/ipmi/ipmi_ipmb.c > +++ b/drivers/char/ipmi/ipmi_ipmb.c > @@ -202,11 +202,16 @@ static int ipmi_ipmb_slave_cb(struct i2c_client *client, > break; > > case I2C_SLAVE_READ_REQUESTED: > + *val = 0xff; > + ipmi_ipmb_check_msg_done(iidev); > + break; > + > case I2C_SLAVE_STOP: > ipmi_ipmb_check_msg_done(iidev); > break; > > case I2C_SLAVE_READ_PROCESSED: > + *val = 0xff; > break; > } > > > --- > base-commit: b71e635feefc852405b14620a7fc58c4c80c0f73 > change-id: 20260113-ipmb-read-init-5b97dfbcd3b9 > > Best regards, > -- > Matt Johnston >