public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, sohil.mehta@intel.com,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Ingo Molnar <mingo@redhat.com>, Jon Kohler <jon@nutanix.com>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Thomas Gleixner <tglx@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	x86@kernel.org
Subject: Re: [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure
Date: Tue, 20 Jan 2026 21:44:07 +0100	[thread overview]
Message-ID: <aW_pF5ulDUplHOy9@black.igk.intel.com> (raw)
In-Reply-To: <cd1c29e3-3575-4f42-8e72-db2514b3b4bb@intel.com>

On Tue, Jan 20, 2026 at 07:06:56AM -0800, Dave Hansen wrote:
> On 1/20/26 00:27, Andy Shevchenko wrote:
> ...
> >> Note: This should not grow the size of 'struct cpuinfo_x86' in
> >> practice since the u8 fits next to another u8 in the structure.
> > 
> > Have you run `pahole` to confirm?
> 
> I have not. If you'd like to contribute to the series by compiling this
> and running pahole on it, I'd very much appreciate it!

Okay, here is the diff:

--- old	2026-01-20 21:40:39.170530703 +0100
+++ new	2026-01-20 21:37:42.717138133 +0100
@@ -19,8 +19,9 @@
 	};
 
 	__u8                       x86_stepping;         /*     4     1 */
+	__u8                       x86_platform_id;      /*     5     1 */
 
-	/* XXX 3 bytes hole, try to pack */
+	/* XXX 2 bytes hole, try to pack */
 
 	int                        x86_tlbsize;          /*     8     4 */
 	__u32                      vmx_capability[5];    /*    12    20 */
@@ -75,8 +76,8 @@
 
 	unsigned int               initialized:1;        /*   332: 8  4 */
 
-	/* size: 336, cachelines: 6, members: 27 */
-	/* sum members: 319, holes: 5, sum holes: 14 */
+	/* size: 336, cachelines: 6, members: 28 */
+	/* sum members: 320, holes: 5, sum holes: 13 */
 	/* sum bitfield members: 1 bits (0 bytes) */
 	/* bit_padding: 23 bits */
 	/* last cacheline: 16 bytes */

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-01-20 20:44 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 19:50 [PATCH 0/6] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-01-19 19:50 ` [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header Dave Hansen
2026-01-20  8:24   ` Andy Shevchenko
2026-01-20 15:03     ` Dave Hansen
2026-01-20 16:22       ` Andy Shevchenko
2026-01-20 16:34         ` Dave Hansen
2026-01-20 20:54           ` Andy Shevchenko
2026-01-20 16:48     ` Luck, Tony
2026-01-20 20:50       ` Shevchenko, Andriy
2026-01-19 19:50 ` [PATCH 2/6] x86/cpu: Add missing #include Dave Hansen
2026-01-20  0:26   ` Dave Hansen
2026-01-20  8:19     ` Andy Shevchenko
2026-01-20 15:35       ` Dave Hansen
2026-01-19 19:50 ` [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper Dave Hansen
2026-01-20  3:07   ` Chao Gao
2026-01-20 16:06     ` Dave Hansen
2026-01-20 20:59       ` Andy Shevchenko
2026-01-22 19:26   ` Sohil Mehta
2026-01-19 19:50 ` [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure Dave Hansen
2026-01-20  3:14   ` Chao Gao
2026-01-20 15:22     ` Dave Hansen
2026-01-21  2:03       ` Chao Gao
2026-01-20  8:27   ` Andy Shevchenko
2026-01-20 15:06     ` Dave Hansen
2026-01-20 20:44       ` Andy Shevchenko [this message]
2026-01-20 20:48         ` Dave Hansen
2026-01-19 19:50 ` [PATCH 5/6] x86/cpu: Add platform ID to CPU matching structure Dave Hansen
2026-01-20  8:30   ` Andy Shevchenko
2026-01-20 15:09     ` Dave Hansen
2026-01-19 19:51 ` [PATCH 6/6] x86/microcode: Add platform mask to Intel microcode "old" list Dave Hansen
2026-01-20 14:33   ` Zhao Liu
2026-01-20 15:10     ` Dave Hansen
2026-01-29 21:23   ` Sohil Mehta
2026-01-20 18:18 ` [PATCH 0/6] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-01-22 13:56 ` Ricardo Neri
  -- strict thread matches above, loose matches on Subject: below --
2026-01-20 14:34 [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure Maciej Wieczor-Retman
2026-01-20 15:13 ` Dave Hansen
2026-01-20 16:03   ` Maciej Wieczor-Retman
2026-01-20 16:12     ` Dave Hansen
2026-02-06 23:14 [PATCH 0/6] [v2] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-02-06 23:14 ` [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure Dave Hansen
2026-02-08 21:37   ` Borislav Petkov
2026-02-11 18:40     ` Dave Hansen
2026-02-12 15:22       ` Borislav Petkov
2026-02-10 23:23   ` Sohil Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW_pF5ulDUplHOy9@black.igk.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jon@nutanix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox