From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DF7132BF43 for ; Tue, 20 Jan 2026 20:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768942759; cv=none; b=U52p57j3fXHSQ77dMa29MyHcEKHBAozlKdg1E9kfUTo/Bm2WP+VQR0hEl5F4H0h5sLoxcbBouw+bW5ihsBuIyF+6kln3MJMcMyhDuNAaxlTehLD8qH1MaAG2HpWwqYiAop3r32bRthyU17KtWW6uDGrMPwBYMlyN8YKVQwWnB38= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768942759; c=relaxed/simple; bh=UOxYg70mSUAKDE8bbe2SpL3+z3QLDnfVEJ3xncvEWpA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tZzczUOBJ/LhmgQqHFA19UB3NpvCXrJx8QahUdwdBc+7aG5gIDDs4NChr6X/4McjUppZDBc1W6JosmEBItfCSzhH3JjU6n6kz8Bf8aYQQ6AttcwUi3x8Fve0zCOM10MxuvhoiOcbc3krCIqPrBh3TGz3hi8E/Cu10OWLE1ly9ng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HKUvICzU; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HKUvICzU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768942757; x=1800478757; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UOxYg70mSUAKDE8bbe2SpL3+z3QLDnfVEJ3xncvEWpA=; b=HKUvICzU1WBSADY+qYTdtiTwYTCCE7C7GarfcM536z4I6dd6MiV0488n Sfe4owxWUvvari+wGjUF9/UQdcNx6z/z66R+sTX5YcqM0hXGlJ5lWjhQu aYf8lqHunpsDvT5YucrLPX66VA7YzZYcTT0TJgr+E646lYNHZWD90TPJ5 5FHLuNFHVLRfhyY+z0JGzsde5cTBNjlVK9vIjx6LnLiQk4biLZe0+yF2Y 3SHJ+lQX3rUXlAqIhAHHoTtq0gUK/xpZosSkGYKnXOqPg8C452gIgrL8J dyh1BZgglxRhqdrsJRjRgHr+cqATMihpvUTX5ZT7i7YpfI2X9IHKH+V/n g==; X-CSE-ConnectionGUID: h07VitZjQBKDG0UXEKKCqw== X-CSE-MsgGUID: I3qzJpOHSeyM8KQqJWb+Sg== X-IronPort-AV: E=McAfee;i="6800,10657,11677"; a="87742426" X-IronPort-AV: E=Sophos;i="6.21,241,1763452800"; d="scan'208";a="87742426" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2026 12:59:17 -0800 X-CSE-ConnectionGUID: QaoMLomSTwqC1rAAdA0kzA== X-CSE-MsgGUID: 9pYAv32cSF+QeJOe7dpv9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,241,1763452800"; d="scan'208";a="229187377" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa002.fm.intel.com with ESMTP; 20 Jan 2026 12:59:14 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id A69AF95; Tue, 20 Jan 2026 21:59:12 +0100 (CET) Date: Tue, 20 Jan 2026 21:59:12 +0100 From: Andy Shevchenko To: Dave Hansen Cc: Chao Gao , Dave Hansen , linux-kernel@vger.kernel.org, sohil.mehta@intel.com, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Jon Kohler , Pawan Gupta , "Peter Zijlstra (Intel)" , Thomas Gleixner , Tony Luck , x86@kernel.org Subject: Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper Message-ID: References: <20260119195047.86E3C696@davehans-spike.ostc.intel.com> <20260119195053.E0850F99@davehans-spike.ostc.intel.com> <415ca474-c2e3-4be0-a178-51041af18cf1@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <415ca474-c2e3-4be0-a178-51041af18cf1@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Jan 20, 2026 at 08:06:41AM -0800, Dave Hansen wrote: > On 1/19/26 19:07, Chao Gao wrote: ... > >> +#include > >> #include > >> +#include > > nit: You may want to sort the header files alphabetically. > > I was probably going for christmas tree here or something. But, > seriously, I don't think we've written down any guidance on header > ordering for tip or in the tree in general. > > It's still kinda the wild west, I think. It was unclear why you put these two new headers in such an order. Because it feels like you wanted something like alphabetical, but something went differently. For the xmas tree I would expect them still go together #include #include #include But personally I'm with Chao Gao, the alphabetical is easier to maintain as it's natural order that many people got for many years starting from kindergarten times. -- With Best Regards, Andy Shevchenko