Re: [PATCH v2 2/2] Input: wdt87xx_i2c - switch to use dev_err_probe()

Andy Shevchenko
2026-01-20T21:09:12Z

On Tue, Jan 20, 2026 at 12:40:25PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 13, 2026 at 09:22:58AM +0100, Andy Shevchenko wrote:

...

> > + struct device *dev = &client->dev;
>
> You introduced a tempo but used it in only one place. I dropped it.

Yes, to avoid churn on converting unrelated places right now. But it may help
in the future.

...

> > - error = devm_request_threaded_irq(&client->dev, client->irq,
> > - NULL, wdt87xx_ts_interrupt,
> > - IRQF_ONESHOT,
> > - client->name, wdt);
> > - if (error) {
> > - dev_err(&client->dev, "request irq failed: %d\n", error);
> > - return error;
> > - }
> > -
> > - return 0;
> > + return devm_request_threaded_irq(dev, client->irq,
> > + NULL, wdt87xx_ts_interrupt,
> > + IRQF_ONESHOT, client->name, wdt);
>
> My preference is to keep "if (error) return error;" even for the last
> call when there are multiple potential points of failure in the
> function, adjusted.

Okay, no problem.

> Applied the updated patch.

Thanks!

--
With Best Regards,
Andy Shevchenko