From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Sandipan Das <sandipan.das@amd.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Kan Liang <kan.liang@linux.intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Stephane Eranian <eranian@google.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Ananth Narayan <ananth.narayan@amd.com>
Subject: Re: [PATCH 2/4] perf vendor events amd: Add Zen 6 uncore events
Date: Tue, 13 Jan 2026 18:19:27 -0300 [thread overview]
Message-ID: <aWa237L98No7Ec2B@x1> (raw)
In-Reply-To: <CAP-5=fX6=wj+xZa4dK=5mjAoDJX7KreK1dMAT-o3aH9BkWZyVg@mail.gmail.com>
On Tue, Jan 13, 2026 at 12:41:42PM -0800, Ian Rogers wrote:
> On Tue, Jan 13, 2026 at 12:27 PM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > On Thu, Jan 08, 2026 at 01:22:15PM +0530, Sandipan Das wrote:
> > > Add uncore events taken from Section 1.6 "L3 Cache Performance Monitor
> > > Counters" and Section 2.2 "UMC Performance Monitor Events" of the
> > > Performance Monitor Counters for AMD Family 1Ah Model 50h-57h Processors
> > > document available at the link below.
> > >
> > > This constitutes events which capture L3 cache and UMC command activity.
> >
> > LD /tmp/build/perf-tools-next/perf-util-in.o
> > AR /tmp/build/perf-tools-next/libperf-util.a
> > CC /tmp/build/perf-tools-next/pmu-events/pmu-events.o
> > /tmp/build/perf-tools-next/pmu-events/pmu-events.c:30902:37: error: ‘pmu_events__amdzen6’ defined but not used [-Werror=unused-const-variable=]
> > 30902 | static const struct pmu_table_entry pmu_events__amdzen6[] = {
> > | ^~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > make[3]: *** [pmu-events/Build:89: /tmp/build/perf-tools-next/pmu-events/pmu-events.o] Error 1
> > make[2]: *** [Makefile.perf:772: /tmp/build/perf-tools-next/pmu-events/pmu-events-in.o] Error 2
> > make[1]: *** [Makefile.perf:288: sub-make] Error 2
> > make: *** [Makefile:119: install-bin] Error 2
> > make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf'
> > ⬢ [acme@toolbx perf-tools-next]$
> >
> > When building at this patch (2/4) it breaks, lemme see if at the end it
> > works, but even then this can't stand this way, as we break bisection...
> >
> > Then, on 3/4 we get:
> >
> > CC /tmp/build/perf-tools-next/pmu-events/pmu-events.o
> > /tmp/build/perf-tools-next/pmu-events/pmu-events.c:30992:37: error: ‘pmu_metrics__amdzen6’ defined but not used [-Werror=unused-const-variable=]
> > 30992 | static const struct pmu_table_entry pmu_metrics__amdzen6[] = {
> > | ^~~~~~~~~~~~~~~~~~~~
> > /tmp/build/perf-tools-next/pmu-events/pmu-events.c:30908:37: error: ‘pmu_events__amdzen6’ defined but not used [-Werror=unused-const-variable=]
> > 30908 | static const struct pmu_table_entry pmu_events__amdzen6[] = {
> > | ^~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > make[3]: *** [pmu-events/Build:89: /tmp/build/perf-tools-next/pmu-events/pmu-events.o] Error 1
> > make[2]: *** [Makefile.perf:772: /tmp/build/perf-tools-next/pmu-events/pmu-events-in.o] Error 2
> > make[1]: *** [Makefile.perf:288: sub-make] Error 2
> > make: *** [Makefile:119: install-bin] Error 2
> > make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf'
> > ⬢ [acme@toolbx perf-tools-next]$
> >
> > Finally, on 4/4 everything builds.
> >
> > Can you please take a look to check how we can keep all bisection happy?
>
> So patch 4 adds the mapfile.csv change and that's the thing that
> creates the references to the zen6 tables that is failing when
> building with the earlier patches. If patch 4 is made patch 1 then the
> series builds at each step (1,2,3,4) for me.
Trying that now... Did the trick, thanks! Applied.
- Arnaldo
next prev parent reply other threads:[~2026-01-13 21:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 7:52 [PATCH 0/4] perf vendor events amd: Add Zen 6 events and metrics Sandipan Das
2026-01-08 7:52 ` [PATCH 1/4] perf vendor events amd: Add Zen 6 core events Sandipan Das
2026-01-08 7:52 ` [PATCH 2/4] perf vendor events amd: Add Zen 6 uncore events Sandipan Das
2026-01-13 20:27 ` Arnaldo Carvalho de Melo
2026-01-13 20:41 ` Ian Rogers
2026-01-13 21:19 ` Arnaldo Carvalho de Melo [this message]
2026-01-08 7:52 ` [PATCH 3/4] perf vendor events amd: Add Zen 6 metrics Sandipan Das
2026-01-08 7:52 ` [PATCH 4/4] perf vendor events amd: Add Zen 6 mapping Sandipan Das
2026-01-08 17:41 ` [PATCH 0/4] perf vendor events amd: Add Zen 6 events and metrics Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWa237L98No7Ec2B@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=caleb.biggers@intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox