From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Guo Ren <guoren@kernel.org>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Ankur Arora <ankur.a.arora@oracle.com>,
Howard Chu <howardchu95@gmail.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
Yujie Liu <yujie.liu@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf: Make more global variables static
Date: Tue, 13 Jan 2026 18:40:52 -0300 [thread overview]
Message-ID: <aWa75MJy7FMyzR9P@x1> (raw)
In-Reply-To: <aWGtNvi9kbBCTNVE@google.com>
On Fri, Jan 09, 2026 at 05:36:54PM -0800, Namhyung Kim wrote:
> On Thu, Dec 04, 2025 at 01:42:35PM -0800, Ian Rogers wrote:
> > `make check` will run sparse on the perf code base. A frequent warning
> > is "warning: symbol '...' was not declared. Should it be static?" Go
> > through and make global definitions without declarations static. In
> > some cases it is deliberate due to dlsym accessing the symbol, this
> > change doesn't clean up the missing declarations for perf test
> > suites. Sometimes things can opportunistically be made const. Making
> > somethings static exposed unused functions warnings, so restructuring
> > of ifdefs was necessary for that. These changes reduce the size of the
> > perf binary by 3,264 bytes.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied to perf-tools-next,
- Arnaldo
next prev parent reply other threads:[~2026-01-13 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 21:42 [PATCH v1] perf: Make more global variables static Ian Rogers
2026-01-08 19:36 ` Ian Rogers
2026-01-10 1:36 ` Namhyung Kim
2026-01-13 21:40 ` Arnaldo Carvalho de Melo [this message]
2026-01-12 6:48 ` Ankur Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWa75MJy7FMyzR9P@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alex@ghiti.fr \
--cc=alexander.shishkin@linux.intel.com \
--cc=ankur.a.arora@oracle.com \
--cc=aou@eecs.berkeley.edu \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=guoren@kernel.org \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox