From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Blake Jones <blakejones@google.com>,
Zhongqiu Han <quic_zhonhan@quicinc.com>,
Chun-Tse Shao <ctshao@google.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Stephen Brennan <stephen.s.brennan@oracle.com>,
Thomas Falcon <thomas.falcon@intel.com>,
Howard Chu <howardchu95@gmail.com>,
Yunseong Kim <ysk@kzalloc.com>, Leo Yan <leo.yan@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Haibo Xu <haibo1.xu@intel.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf: Switch printf("...%s", strerror(errno)) to printf("...%m")
Date: Tue, 13 Jan 2026 18:48:26 -0300 [thread overview]
Message-ID: <aWa9qmZL9BrY2UlJ@x1> (raw)
In-Reply-To: <aWGqdmr7BQPzhq-k@google.com>
On Fri, Jan 09, 2026 at 05:25:10PM -0800, Namhyung Kim wrote:
> On Wed, Nov 19, 2025 at 03:36:21PM -0800, Ian Rogers wrote:
> > strerror has thread safety issues, strerror_r requires stack allocated
> > buffers. Code in perf has already been using the "%m" formatting flag
> > that is a widely support glibc extension to print the current errno's
> > description. Expand the usage of this formatting flag and remove usage
> > of strerror/strerror_r.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2026-01-13 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 23:36 [PATCH v1] perf: Switch printf("...%s", strerror(errno)) to printf("...%m") Ian Rogers
2026-01-08 19:42 ` Ian Rogers
2026-01-10 1:25 ` Namhyung Kim
2026-01-13 21:48 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWa9qmZL9BrY2UlJ@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexghiti@rivosinc.com \
--cc=blakejones@google.com \
--cc=ctshao@google.com \
--cc=dvyukov@google.com \
--cc=haibo1.xu@intel.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=quic_zhonhan@quicinc.com \
--cc=stephen.s.brennan@oracle.com \
--cc=thomas.falcon@intel.com \
--cc=ysk@kzalloc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox