The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Eugene Loh <eugene.loh@oracle.com>
Cc: song@kernel.org, ast@kernel.org, rostedt@goodmis.org,
	linux-kernel@vger.kernel.org,
	Kris Van Hees <kris.van.hees@oracle.com>,
	Will Deacon <will@kernel.org>
Subject: Re: aarch64 missing from Revert "perf/x86: Always store regs->ip in perf_callchain_kernel()"
Date: Tue, 13 Jan 2026 23:18:51 +0100	[thread overview]
Message-ID: <aWbEyxK69lL8N-n8@krava> (raw)
In-Reply-To: <a38fed68-67bc-98ce-8e12-743342121ae3@oracle.com>

On Mon, Jan 12, 2026 at 01:17:53AM -0500, Eugene Loh wrote:
> Thanks for reverting that patch:
> https://lore.kernel.org/r/20251104215405.168643-2-jolsa@kernel.org
> https://github.com/torvalds/linux/commit/6d08340d1e354787d6c65a8c3cdd4d41ffb8a5ed
>     Revert "perf/x86: Always store regs->ip in perf_callchain_kernel()"
>     This reverts commit 83f44ae.

hi,
thanks for the report, I did not check aarch64, just x86_64
and there's even more fun with it:
  https://lore.kernel.org/bpf/20260112214940.1222115-1-jolsa@kernel.org/T/#mac207867799058c9b0cb273b09e9a2aaf552eebf

> 
> But it seems to me that this issue is not specific to x86.  For example,
> here is aarch64, using a 6.18 kernel:
> 
>     # bpftrace -e 'tracepoint:sched:sched_process_exec { print(kstack()); }'
> 
>         perf_trace_sched_process_exec+16
>         perf_trace_sched_process_exec+16
>         __traceiter_sched_process_exec+80
>         exec_binprm+908
>         bprm_execve.part.0+464
>         bprm_execve+68
>         do_execveat_common.isra.0+456
>         __arm64_sys_execve+76
>         invoke_syscall+112
>         el0_svc_common.constprop.0+264
>         do_el0_svc+36
>         el0_svc+56
>         el0t_64_sync_handler+184
>         el0t_64_sync+412
> 
> The leaf IP is repeated.  Are corresponding changes needed for processors
> other than just x86?
> 

probably.. I think it's very arch code that will need investigation
from somebody fluent in aarch64, adding Will ;-)

thanks,
jirka

      reply	other threads:[~2026-01-13 22:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12  6:17 aarch64 missing from Revert "perf/x86: Always store regs->ip in perf_callchain_kernel()" Eugene Loh
2026-01-13 22:18 ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWbEyxK69lL8N-n8@krava \
    --to=olsajiri@gmail.com \
    --cc=ast@kernel.org \
    --cc=eugene.loh@oracle.com \
    --cc=kris.van.hees@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=song@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox