From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,
srini@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
sre@kernel.org, sboyd@kernel.org, krzk@kernel.org,
dmitry.baryshkov@oss.qualcomm.com, quic_wcheng@quicinc.com,
melody.olvera@oss.qualcomm.com, quic_nsekar@quicinc.com,
ivo.ivanov.ivanov1@gmail.com, abelvesa@kernel.org,
luca.weiss@fairphone.com, konrad.dybcio@oss.qualcomm.com,
mitltlatltl@gmail.com, krishna.kurapati@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pm@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v8 00/10] SPMI: Implement sub-devices and migrate drivers
Date: Wed, 14 Jan 2026 11:43:38 +0200 [thread overview]
Message-ID: <aWdlSlI85ro7SbJv@smile.fi.intel.com> (raw)
In-Reply-To: <20260114092742.13231-1-angelogioacchino.delregno@collabora.com>
On Wed, Jan 14, 2026 at 10:27:32AM +0100, AngeloGioacchino Del Regno wrote:
> Changes in v8:
> - Renamed *res to *sub_sdev in devm_spmi_subdevice_remove() (Andy)
> - Changed kerneldoc wording to "error pointer" for function
> spmi_subdevice_alloc_and_add() (Andy)
> - Shuffled around some assignments in spmi_subdevice_alloc_and_add() (Andy)
> - Used device_property_read_u32() instead of of_property_read_u32()
> in all of the migrated drivers (Andy)
> - Changed .max_register field in all of the migrated drivers from
> 0x100 to 0xff (Andy)
> - Kept `sta1` declaration in reversed xmas tree order in function
> iadc_poll_wait_eoc() of qcom-spmi-iadc.c (Andy)
Thanks, in principle I'm okay with this version, but it would be nice to have
clarification on the max_register for sure (it doesn't prevent the series from
being applied).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-14 9:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 9:27 [PATCH v8 00/10] SPMI: Implement sub-devices and migrate drivers AngeloGioacchino Del Regno
2026-01-14 9:27 ` [PATCH v8 01/10] spmi: Remove redundant dev_name() print in spmi_device_add() AngeloGioacchino Del Regno
2026-01-16 2:03 ` Stephen Boyd
2026-01-14 9:27 ` [PATCH v8 02/10] spmi: Print error status with %pe format AngeloGioacchino Del Regno
2026-01-16 2:03 ` Stephen Boyd
2026-01-14 9:27 ` [PATCH v8 03/10] spmi: Remove unneeded goto in spmi_device_add() error path AngeloGioacchino Del Regno
2026-01-16 2:03 ` Stephen Boyd
2026-01-14 9:27 ` [PATCH v8 04/10] spmi: Implement spmi_subdevice_alloc_and_add() and devm variant AngeloGioacchino Del Regno
2026-01-16 2:08 ` Stephen Boyd
2026-01-14 9:27 ` [PATCH v8 05/10] nvmem: qcom-spmi-sdam: Migrate to devm_spmi_subdevice_alloc_and_add() AngeloGioacchino Del Regno
2026-03-11 7:42 ` Srinivas Kandagatla
2026-01-14 9:27 ` [PATCH v8 06/10] power: reset: qcom-pon: " AngeloGioacchino Del Regno
2026-01-14 9:27 ` [PATCH v8 07/10] phy: qualcomm: eusb2-repeater: " AngeloGioacchino Del Regno
2026-01-21 7:39 ` Vinod Koul
2026-01-14 9:27 ` [PATCH v8 08/10] misc: qcom-coincell: " AngeloGioacchino Del Regno
2026-01-14 9:27 ` [PATCH v8 09/10] iio: adc: qcom-spmi-iadc: " AngeloGioacchino Del Regno
2026-01-14 9:27 ` [PATCH v8 10/10] iio: adc: qcom-spmi-iadc: Remove regmap R/W wrapper functions AngeloGioacchino Del Regno
2026-01-14 9:43 ` Andy Shevchenko [this message]
2026-01-14 9:46 ` [PATCH v8 00/10] SPMI: Implement sub-devices and migrate drivers Andy Shevchenko
2026-01-21 11:00 ` AngeloGioacchino Del Regno
2026-03-05 14:32 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWdlSlI85ro7SbJv@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abelvesa@kernel.org \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=dlechner@baylibre.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=melody.olvera@oss.qualcomm.com \
--cc=mitltlatltl@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=srini@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox