From: Sudeep Holla <sudeep.holla@arm.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Saravana Kannan <saravanak@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: platform: Use default match table for /firmware
Date: Wed, 14 Jan 2026 09:50:55 +0000 [thread overview]
Message-ID: <aWdm_xNPEhO_UvzV@bogus> (raw)
In-Reply-To: <20260114015158.692170-2-robh@kernel.org>
On Tue, Jan 13, 2026 at 07:51:58PM -0600, Rob Herring (Arm) wrote:
> Calling of_platform_populate() without a match table will only populate
> the immediate child nodes under /firmware. This is usually fine, but in
> the case of something like a "simple-mfd" node such as
> "raspberrypi,bcm2835-firmware", those child nodes will not be populated.
> And subsequent calls won't work either because the /firmware node is
> marked as processed already.
>
> Switch the call to of_platform_default_populate() to solve this problem.
> It should be a nop for existing cases.
>
Thanks, had not thought of child nodes for sure at that time.
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2026-01-14 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 1:51 [PATCH] of: platform: Use default match table for /firmware Rob Herring (Arm)
2026-01-14 9:50 ` Sudeep Holla [this message]
2026-01-17 1:14 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWdm_xNPEhO_UvzV@bogus \
--to=sudeep.holla@arm.com \
--cc=andersson@kernel.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox