From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andreas Klinger" <ak@it-klinger.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 05/13] iio: pressure: mprls0025pa: fix pressure calculation
Date: Wed, 14 Jan 2026 12:14:59 +0200 [thread overview]
Message-ID: <aWdso0jjRRdEpcAC@smile.fi.intel.com> (raw)
In-Reply-To: <20260114-mprls_cleanup-v2-5-5868b0045316@subdimension.ro>
On Wed, Jan 14, 2026 at 12:05:39PM +0200, Petre Rodan wrote:
> A sign change is needed for proper calculation of the pressure.
>
> This is a minor fix since it only affects users that might have custom
> silicon from Honeywell that has honeywell,pmin-pascal != 0.
>
> Also due to the fact that raw pressure values can not be lower
> than output_min (400k-3.3M) there is no need to calculate a decimal for
> the offset.
...
> int mpr_common_probe(struct device *dev, const struct mpr_ops *ops, int irq)
> struct mpr_data *data;
> struct iio_dev *indio_dev;
> const char *triplet;
> - s64 scale, offset;
> u32 func;
> + s32 tmp;
> + s64 odelta, pdelta;
Please, preserve reversed xmas tree order. And in general try to stick with that one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-14 10:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 10:05 [PATCH v2 00/13] iio: pressure: mprls0025pa: driver code cleanup Petre Rodan
2026-01-14 10:05 ` [PATCH v2 01/13] iio: pressure: mprls0025pa: fix spi_transfer struct initialisation Petre Rodan
2026-01-14 10:05 ` [PATCH v2 02/13] iio: pressure: mprls0025pa: fix SPI CS delay violation Petre Rodan
2026-01-14 10:05 ` [PATCH v2 03/13] iio: pressure: mprls0025pa: fix interrupt flag Petre Rodan
2026-01-14 10:13 ` Andy Shevchenko
2026-01-14 12:14 ` Jonathan Cameron
2026-01-14 10:05 ` [PATCH v2 04/13] iio: pressure: mprls0025pa: fix scan_type struct Petre Rodan
2026-01-14 10:05 ` [PATCH v2 05/13] iio: pressure: mprls0025pa: fix pressure calculation Petre Rodan
2026-01-14 10:14 ` Andy Shevchenko [this message]
2026-01-14 10:05 ` [PATCH v2 06/13] iio: pressure: mprls0025pa: cleanup includes Petre Rodan
2026-01-14 10:05 ` [PATCH v2 07/13] iio: pressure: mprls0025pa: remove redundant declarations Petre Rodan
2026-01-14 10:05 ` [PATCH v2 08/13] iio: pressure: mprls0025pa: rename buffer variable Petre Rodan
2026-01-14 10:05 ` [PATCH v2 09/13] iio: pressure: mprls0025pa: introduce tx buffer Petre Rodan
2026-01-14 10:05 ` [PATCH v2 10/13] iio: pressure: mprls0025pa: move memset to core Petre Rodan
2026-01-14 10:05 ` [PATCH v2 11/13] iio: pressure: mprls0025pa: stricter checks for the status byte Petre Rodan
2026-01-14 10:05 ` [PATCH v2 12/13] iio: pressure: mprls0025pa: change measurement sequence Petre Rodan
2026-01-14 10:20 ` Andy Shevchenko
2026-01-14 10:05 ` [PATCH v2 13/13] iio: pressure: mprls0025pa: add copyright line Petre Rodan
2026-01-14 12:21 ` [PATCH v2 00/13] iio: pressure: mprls0025pa: driver code cleanup Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWdso0jjRRdEpcAC@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox