From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B10F334F24F for ; Wed, 14 Jan 2026 15:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768405770; cv=none; b=Fu0jw6Qhh2eTTdtW7UUFUcvlIMHXjSrwgA1StdxzKdiXhhLWxyBTGAfSaf0Bn9WGReg+ybJFphGzeGNf2f+J+hNhTp47u1UB2ClaNa5knA9nhYzCR/MScIz62siiBaCRcvPYiZCyHzYf4eB+AYIr1Z1P0/sg7mj/CZY7oP0m1Ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768405770; c=relaxed/simple; bh=ObB6mNLZxrOwdkLeI7B4S8nJCj6vaP/E1/Gjfy932w0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HWodmRm/xnt+pyTQ2lW2zr0sFOxkEvyTtGiJlqc8TZwr3Fypf29zpnoXYTos0YOiYRvJfr4mDYWyJRETJza44TqSd2rHtwuDLGaJU4/w5P9pCdV1d6vezxpboDW1IPhxOk9Fmw6Z1DOezLo0r7uIC0puIWptVBjfNAT8/O/R/70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rEHw5awH; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rEHw5awH" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a0d06cfa93so76695ad.1 for ; Wed, 14 Jan 2026 07:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768405768; x=1769010568; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hewq6sKfyqMWuY04fEC1TGPKE79y9zR1LTOJeM3Fj4A=; b=rEHw5awHrtX3ZHsLi1+gjyO5nXPwZOiIrZMJRvLUjVLa+oMQgoASg+aPYIPtNkepwa ssYKr+NH7ZW15tZAKAyR1ZmyPDSFHEAqKlCkO2zCPh7sx344pEWiOQOcfcT1OXLaixlq o19iGno9/VjgkhFV9+q4mUkDbjcG2okjTL0PBqfmR/XNgS+8Bd/G7waNk0sNrdhEQMoV Hdj47I4Zr/XvMT84Ufy1cyfxJCXvK1Np6XPmijDQalmz+EqVaczzhemr9fjNqBTio0/l 1uZQVC1KixZUXQBxJ0q95BBw1cFry628v24FS3iE8XkyVLm8AOew7h/mMzBwwoV8PR9y YEFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768405768; x=1769010568; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hewq6sKfyqMWuY04fEC1TGPKE79y9zR1LTOJeM3Fj4A=; b=rhIkhaGtqiCI+mD+EHsMUpZQyHy3kyPN4WfQ8g9J59TUy9wi6og3h0Ij8pAUc4FrV2 AeIQKndM/mHV9mZ6agG6tgJyv0ti7ZjxHX5o4wCe0J1aAYuDzvvEILlNVs/vnDInQkoY EiaZWPlMWai8Gs7wUx7EoJ+Kopv0FZhcFyhelfsGKMnCJvGTCNaURoZ99plK9zdknpbV rSrx3NRkBb1s3eesqh7DvooJ1VpUtqtZ8Cp0NrG/gxoVCGJXAzHUQr0I6DCS6QgpKxal 4upcGHFx2WQ27QkC2iyVhQu4VhWJRqwrE9Vr6ZOOpg8cCduNBn00tmIjOVTnCbChsy+0 x8jQ== X-Forwarded-Encrypted: i=1; AJvYcCX22IQPGAuPKL5wshvH4FsQZEvhXIaYjXWVN6G//hHMiyW0jq1uM3OwuyfhpL2WyRW2W8Qycn+OSYRGk5s=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi33PBY7WVgkOkXuL+befN23qJtCEaSQFf/XRxu31ypbeupsjy 0cUEWnTa13M7zIcuypOrv4PP3vEurdzG6/x4MQGL8M/LLigIndfnM4okbCfVDKs2ZQ== X-Gm-Gg: AY/fxX6qtr6Wb8NJXwLP8OMlNRfijHO7A0IK9xqYlA+hZWT/s1RUrmOHHAGgXIDVy83 diyTUNfKcJC4HUKit6kYxXHwoHim66XDCQtJ9peIYAlC8bYERgK4IoTnorTb4OVdb6V/gnIqD05 4H+oLXdXH+gttjiZBInzUhUI9w30tBz6imQB9OCkn33exKW85J6XXt94LcAiIjbWvgHVTBXrY6F n2n6InR2EuCT02Wa7BkARs3RdupB3cvRvqR9AyN2KR3btV6Zcg4Pad+QR085SWIYdzlFAN/iDUd RUf/bXAKTgwNJ1bRBWqxQkyagxrscLtnptjl4bM6K8fWottpYJJAkrHl4mso8xGSAj8KhONqu7R tOzQheBlgpeDa/HsSNzUG4n95Kjiknfn26Y1A8JQ5VT85tOIzKLNp6lfQH2PakrRTGSQ5HOAWKC T/HuB6xEnUun5qbrBZK5CJavRULf9acUTksJ/1kiREMLp/n0Hf X-Received: by 2002:a17:902:d583:b0:292:b6a0:80df with SMTP id d9443c01a7336-2a599aec680mr2522025ad.10.1768405767789; Wed, 14 Jan 2026 07:49:27 -0800 (PST) Received: from google.com (222.245.187.35.bc.googleusercontent.com. [35.187.245.222]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c530133csm23442851b3a.31.2026.01.14.07.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:49:26 -0800 (PST) Date: Wed, 14 Jan 2026 15:49:21 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: will@kernel.org, jgg@nvidia.com, robin.murphy@arm.com, joro@8bytes.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, skolothumtho@nvidia.com, xueshuai@linux.alibaba.com, smostafa@google.com Subject: Re: [PATCH rc v6 1/4] iommu/arm-smmu-v3: Add update_safe bits to fix STE update sequence Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 12, 2026 at 12:20:14PM -0800, Nicolin Chen wrote: > From: Jason Gunthorpe > > C_BAD_STE was observed when updating nested STE from an S1-bypass mode to > an S1DSS-bypass mode. As both modes enabled S2, the used bit is slightly > different than the normal S1-bypass and S1DSS-bypass modes. As a result, > fields like MEV and EATS in S2's used list marked the word1 as a critical > word that requested a STE.V=0. This breaks a hitless update. > > However, both MEV and EATS aren't critical in terms of STE update. One > controls the merge of the events and the other controls the ATS that is > managed by the driver at the same time via pci_enable_ats(). > > Add an arm_smmu_get_ste_update_safe() to allow STE update algorithm to > relax those fields, avoiding the STE update breakages. > > After this change, entry_set has no caller checking its return value, so > change it to void. > > Note that this change is required by both MEV and EATS fields, which were > introduced in different kernel versions. So add get_update_safe() first. > MEV and EATS will be added to arm_smmu_get_ste_update_safe() separately. > > Fixes: 1e8be08d1c91 ("iommu/arm-smmu-v3: Support IOMMU_DOMAIN_NESTED") > Cc: stable@vger.kernel.org > Signed-off-by: Jason Gunthorpe > Reviewed-by: Shuai Xue > Reviewed-by: Mostafa Saleh > Signed-off-by: Nicolin Chen Reviewed-by: Pranjal Shrivastava Thanks!