From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Josua Mayer <josua@solid-run.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Peter Rosin <peda@axentia.se>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>, Vignesh R <vigneshr@ti.com>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Andi Shyti <andi.shyti@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Mikhail Anikin <mikhail.anikin@solid-run.com>,
Yazan Shhady <yazan.shhady@solid-run.com>,
Jon Nettleton <jon@solid-run.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-can@vger.kernel.org, linux-phy@lists.infradead.org,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v4 7/7] mmc: host: renesas_sdhi_core: support selecting an optional mux
Date: Wed, 14 Jan 2026 12:49:57 +0100 [thread overview]
Message-ID: <aWeC5brP_KdrCmHz@ninjato> (raw)
In-Reply-To: <20251229-rz-sdio-mux-v4-7-a023e55758fe@solid-run.com>
Hi Josua,
thanks for your work and kudos for striving for a generic solution. It
seems worthwhile to me to add the helpers. I have questions, though:
> + priv->mux_state = devm_mux_state_get_optional_selected(&pdev->dev, NULL);
The minor nit (which may be bike-shedding): Maybe the function name
could be '*_select' instead of '*_selected'. To make more explicit that
this function is actively changing the selection and not passively
retrieving the current state?
The bigger thing is that with devm_* I had the expectation that
deselection is also handled automatically...
> +edselmux:
> + if (priv->mux_state)
> + mux_state_deselect(priv->mux_state);
... so I was a bit surprised to see this manual cleanup. Has it been
discussed if that deselection can also be in the helpers?
Happy hacking,
Wolfram
next prev parent reply other threads:[~2026-01-14 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 14:27 [PATCH v4 0/7] mmc: host: renesas_sdhi_core: support configuring an optional sdio mux Josua Mayer
2025-12-29 14:27 ` [PATCH v4 1/7] phy: can-transceiver: rename temporary helper function to avoid conflict Josua Mayer
2025-12-29 14:27 ` [PATCH v4 2/7] mux: Add helper functions for getting optional and selected mux-state Josua Mayer
2025-12-31 19:18 ` kernel test robot
2026-01-08 7:42 ` Josua Mayer
2026-01-08 7:45 ` Krzysztof Kozlowski
2025-12-29 14:27 ` [PATCH v4 3/7] mux: add help text for MULTIPLEXER config option Josua Mayer
2025-12-29 14:27 ` [PATCH v4 4/7] phy: can-transceiver: drop temporary helper getting optional mux-state Josua Mayer
2025-12-29 14:27 ` [PATCH v4 5/7] i2c: omap: switch to new generic helper for getting selected mux-state Josua Mayer
2026-01-14 11:52 ` Wolfram Sang
2025-12-29 14:27 ` [PATCH v4 6/7] dt-bindings: mmc: renesas,sdhi: Add mux-states property Josua Mayer
2025-12-29 14:27 ` [PATCH v4 7/7] mmc: host: renesas_sdhi_core: support selecting an optional mux Josua Mayer
2026-01-14 11:49 ` Wolfram Sang [this message]
2026-01-18 7:33 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWeC5brP_KdrCmHz@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jmkrzyszt@gmail.com \
--cc=jon@solid-run.com \
--cc=josua@solid-run.com \
--cc=khilman@baylibre.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mailhol@kernel.org \
--cc=mikhail.anikin@solid-run.com \
--cc=mkl@pengutronix.de \
--cc=neil.armstrong@linaro.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox