From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77AFB3A35D0
	for <linux-kernel@vger.kernel.org>; Wed, 14 Jan 2026 16:18:34 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1768407514; cv=none; b=UixqLTH3TfaTj9xlKbtlT0ukaqV3DUly+EmbRVLVeOPz2/rSBD3VK4fV+aPrsmkQmtBvNO+n12rKEzUINgt3nSM1E9hktR03XMPEc/tTQYt2NHt+KQGxhsPvAIU0BeA4Cf0/iTHuywXEykQCzY+OrKaJyKhgqPDIihkXbtae31E=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1768407514; c=relaxed/simple;
	bh=SZ7IavkDNEXvgqXv1XAkTLGYy5HYR5dOiSBl1PLA3Jg=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=jYprz/fUnJXMReaFIS7TVm8CDN0eHGiyCiSNoo/hDqnSiSR2TDEze5HVuJrt1Rt3vD1Z/olWG7ety5/0Qn3LvVPBknNC2U/6ogET3yDYD8nuhISw+nwQyjWm5IvoJya6F7yRjsM+p/QjBbpeOC6vH9fAMbKAK3HTs6uz+4Fy61E=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i0rLl1bN; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i0rLl1bN"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E412C4CEF7;
	Wed, 14 Jan 2026 16:18:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1768407514;
	bh=SZ7IavkDNEXvgqXv1XAkTLGYy5HYR5dOiSBl1PLA3Jg=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=i0rLl1bNOHsWmbR5IQ0pydA3MIBwAALQs8wPwFcN52/TLP2hBxbaP8bn5oU3YGPnZ
	 wR2XBcuhurT3wHsdWCxKSiZb02010ER6GcIFeYFWvVqIQCVCAH25gYgIxOhTA60glF
	 YQkPAGCHFdcdjIY0KH/rh4k+4nhiVgFvw7J8hLvO0nMoYsS+hxbEjiUUrb2nQ7ofMx
	 gasNLxlNoxC/j+AdoCFBZvKDLA/6ZD9XUDzOKM41SI5TeIXm9ncWG3sy29ltgS79nZ
	 PBf76Ufe9qt0qO9k+zDGNiGreJEEQ6rgNgMvKhmRqNSR449UdGI0Z1PQMCz/e6Q/vB
	 Djoycq7hth48g==
Date: Wed, 14 Jan 2026 16:18:29 +0000
From: Daniel Thompson <danielt@kernel.org>
To: Junjie Cao <junjie.cao@intel.com>
Cc: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
	Pengyu Luo <mitltlatltl@gmail.com>, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, caojunjie650@gmail.com,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] backlight: aw99706: Fix build errors caused by wrong
 gpio header
Message-ID: <aWfB1ao4bVyRk97e@aspen.lan>
References: <20260111130117.5041-1-junjie.cao@intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260111130117.5041-1-junjie.cao@intel.com>

On Sun, Jan 11, 2026 at 09:01:17PM +0800, Junjie Cao wrote:
> The driver uses GPIO descriptor API (devm_gpiod_get,
> gpiod_set_value_cansleep, GPIOD_OUT_LOW) but includes the legacy
> <linux/gpio.h> header instead of <linux/gpio/consumer.h>.
>
> When CONFIG_GPIOLIB is not set, <linux/gpio.h> does not include
> <linux/gpio/consumer.h>, causing build errors:
>
>   error: implicit declaration of function 'gpiod_set_value_cansleep'
>   error: implicit declaration of function 'devm_gpiod_get'
>   error: 'GPIOD_OUT_LOW' undeclared
>
> Fix by including the correct header <linux/gpio/consumer.h>.
>
> Fixes: 147b38a5ad06 ("backlight: aw99706: Add support for Awinic AW99706 backlight")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512171631.uKXlYwqu-lkp@intel.com/
> Signed-off-by: Junjie Cao <junjie.cao@intel.com>

Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>


Daniel.