From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C4B32E54DE for ; Wed, 14 Jan 2026 17:09:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768410560; cv=none; b=mdsy2J34i33JH/67/DY3qkWP2ntbZuxPMrPDwJ+cg+/SMVk+cbTeO+jrHWRT7JRLdNFJswSbzWAd598tv6GqIUMXwou36/2bIb72eKQ214F7P05xZ3wPvyrslSdLT/aVDgXU1IbGlbFZ2+7OfSXdu+8nLdf8p8FNC2nSsRaB+Ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768410560; c=relaxed/simple; bh=+3Chiej/V2vv8Lu1RxO+ht/B8amMg1UNl1RJEQiP/P0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RsBTYIZNETrGuRYyGhSELHeWrwwhAIi4+c0NkovY6QTzZu9A6coXMEvZz0BDXLksfG/fgO4nqae/E9k/PX5ku329ppfpnELkSM2X1un2WhXIh1x9ot6mqCsHERK9/hXf4yeZKbcfB/sGf5d4ltSgBSMJkWyhFlj6kRel+xtxA9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cfa/T5Jh; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cfa/T5Jh" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7b22ffa2a88so2399b3a.1 for ; Wed, 14 Jan 2026 09:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768410558; x=1769015358; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=oWw5eeZqFi5AzR5qbLUrsNPCYJAY6GsH21cNOByTI/Y=; b=cfa/T5JhARoiQLLDy/aRENBxl4dHqsBI78SXNckfXgX0145OAQgAyMGw68skeq0jiM stYLXuDUGkggjYbPJfRbxOJZNbs+nKRwqhs32lA4FRIevSUgu9yxS6McKv+5wc56n9jo KBQKWSXS8LGAoxzdk2BGYy6m+nhPpJxDphCpJ6EfL5Elg7frjlJVFlZqDJMFPtwbhPn4 hp+m3IU28fz8eOYk/ZiIUTz9RL6/J8qFSh8K/mqg86ziLz7Pkd0kaTAp9aj3mkgSXcl7 xMmtkiMitMZ9F5W//uquabMZ7f70mt/o2tA2kUBONWbzhqxVJ3T1mVvS8Sa8/qRxCtzt kCQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768410558; x=1769015358; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oWw5eeZqFi5AzR5qbLUrsNPCYJAY6GsH21cNOByTI/Y=; b=leS4jCiX42xwBSgWVgGBTof+o/DFvMwcmQl3Yak2UuSFQRGl64vh/WdxpVQ/KhuOBe zQnP4drQStCkTpKRt8UAqz0etOAM7j3tVOFu0GCKuW1x1uV198xpUT4inz56b5XDpFmV UGTMLNgN5AD1soIq6fxtBXzihrU+TlIN6uWqyddQtv6QkESoz8I5LNbrZVEa0hy2U37i GsyU6sE16fZtncj/Yqc6+A27weplq+n++zYp8bIA96fMF+xwJRtKX8zzumDTiCYmMJtT RC2cgiUmTv4XoHGmQQ+V42BmaypKLlpIArHBCzCKNdh1XL8olnmFkbyYfGDN2vycpJb9 lQVA== X-Forwarded-Encrypted: i=1; AJvYcCUHd+YnJF07cRHUYdNE7jYFnyWt+mcO2nahRPZ7nU8oayg/O7Gl5sEFC6wG1N0/74SR0eZVzCBdBXBaSnc=@vger.kernel.org X-Gm-Message-State: AOJu0YxvfyB76lABc4O8OvhOMrLpPKP12QvYa7r34O7+31bfW3I99wF/ 030hO6BmIq7MJ2jJBx+vqsvQv1PctfEBTeFu9sm5uUgpmwRnk+njq2APZB8+Cp5xlg== X-Gm-Gg: AY/fxX6Fcr17LjVyEfwpxBCuqG6FA2G0FdDD0IeRLApO4blhF/uywAJQqp8Qk6CQ1j2 VHLM4jtr8Mi+SZbjau+HlvZVRRhWsmiKECOR0vrwLunbt6evSX3uP4SRlBlxA5poPrMW9go2u7Y 4/7YyQcvpU6yiT412Nf5Wbcbz7qNvQBwglqIcNo08mjBE9Zqh47uVrCml33gjVouAxnWp4sW89i +tUaBTY9Scixq6c0xyor+9b6dShJ7E6t49z2d9u8ivje7oib4pyLxUaZZgn1WQHQfqcD6RXRJwv KMuOKeC9SHoL7jJKpFWFaWtMSSkGq8SJfkd851uxe/c1K0JcyCUOmz2isIuR2iu8YrP74J1yShY Rpe56BY4Ws+XnqtWLDVQe9sv2ozSB3wuBYvQ7jUVqFz76EqvKox2mkQCYYpJortFoDM3zP/q/Ax iIX4AJU3roMA2sZ+qDwj4LtcDFafWQeZJidONppJ/U2neV X-Received: by 2002:a05:6a00:3926:b0:81f:852b:a931 with SMTP id d2e1a72fcca58-81f852bab64mr2088869b3a.35.1768410558136; Wed, 14 Jan 2026 09:09:18 -0800 (PST) Received: from google.com (76.9.127.34.bc.googleusercontent.com. [34.127.9.76]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f8e6a972dsm105528b3a.61.2026.01.14.09.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 09:09:16 -0800 (PST) Date: Wed, 14 Jan 2026 17:09:12 +0000 From: David Matlack To: Raghavendra Rao Ananta Cc: Alex Williamson , Alex Williamson , Josh Hilke , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/6] vfio: selftests: Add tests to validate SR-IOV UAPI Message-ID: References: <20251210181417.3677674-1-rananta@google.com> <20251210181417.3677674-7-rananta@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-01-09 11:05 AM, Raghavendra Rao Ananta wrote: > On Wed, Jan 7, 2026 at 3:22 PM David Matlack wrote: > > On 2025-12-10 06:14 PM, Raghavendra Rao Ananta wrote: > > > +static struct vfio_pci_device *test_vfio_pci_device_init(const char *bdf, > > > + struct iommu *iommu, > > > + const char *vf_token, > > > + int *out_ret) > > > +{ > > > + struct vfio_pci_device *device; > > > + > > > + device = calloc(1, sizeof(*device)); > > > + VFIO_ASSERT_NOT_NULL(device); > > > + > > > + device->iommu = iommu; > > > + device->bdf = bdf; > > > > Can you put this in a helper exposed by vfio_pci_device.h? e.g. > > vfio_pci_device_alloc() > > > Is that just to wrap the ASSERT() within? Or were you thinking of > initializing the members as well in there? I was thinking it would include all of the above.