From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AEA12EBBB8 for ; Wed, 14 Jan 2026 17:12:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768410757; cv=none; b=HFReFaJb4DthOy3I9/2tX4p+QvEILCil6+LBo28z1jIMtutE4pXiy1CqLke1L6y+nVMqrIBJSyNMlZMz8Zahu48O3JJhzOPkTpDo7bzvTHqhp8mH5+38K7m5czYISLwCazaXpvtUEjwyCn7q4dDXV4qWu/4J8LW/Gvtw7D0Lccc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768410757; c=relaxed/simple; bh=PL79vSldCKtASYKnl7kt5MCW4dDYwKlzHx5ppwlIl0A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oRlxRDQxMpPhnZQ/WuhG/9brkB2xi+2/OEwqFAeh8Z2oA6ReMxPCFVnjRqWk6loke4l/mSu+wj8z9IQAL7Szfdd891T8l4W8J/hsiz5hFLy/yQhCGvkfOmm7XIjpxW6gCI2DeyEZ1abbMwnLC1HCz0GKx87BGaqiHuV0We0dzKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cOMtfzm8; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cOMtfzm8" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-81e7477828bso601486b3a.0 for ; Wed, 14 Jan 2026 09:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768410755; x=1769015555; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JXX4CYzqo8iPchV5iHBX2x1afORDmInP6zpB6RX87OA=; b=cOMtfzm8y7NlmC0UGsv/RhH++X6P8TJ/Wv9DyO50s3TjEx6j7dPVMsV+CrklEh41J+ mLE4cM99VeH0pA1rY4avG8+Ab0lfDTM33YoGASNPVQlZHMACQIfqIQvPEzbHcBLulH59 YvfCYRSP2T8wEe4044aUI7hjAGSDEx2O3ULkqCt2cGHILKyXINcieutS1rVhtotKe24r CXe0/mcNRYykMFF/myH4cQcU3D2BRAo3cS1ITxeU/vkK713uM24hXm60Ly0v19u2yuCI m2MmMqwd90IJVYPNLrkHLQj2gorJ/1fqjY3jdBRkiW6aa24c1nws8zYe07MsvJ7xmxpR CJEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768410755; x=1769015555; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JXX4CYzqo8iPchV5iHBX2x1afORDmInP6zpB6RX87OA=; b=g0FssvpVjaZgFkmCU2jF9tz4+Atxi8itTaXosLWjf935qpooZoZgew3//0udpA/iBl nimeBORq8lJyr720QQQI1vot/vGYgsdp/zLs2Wa/V+fPla3w7FyrvckYgPtUpHCxHBtP /8I9W9pvuIIdi+UhwT7viA4YouJUHpRRpcKIM0UlW3Wbsg7/fd+gFtgZluf1+pPFEGo4 yrpYiM5I4br49yb8PKYy/TvWXpLZWQwlOuGBm9Q3cpwSHSBworPpa1IZcEYfE8Q2cVzQ LUWHknTjm77CNmv3Sf/tGYHNe8qkbyZOF3gqqqpQp0fiLqWt9nyexz5UqhVo63PnZj4m DE4Q== X-Forwarded-Encrypted: i=1; AJvYcCU28LRydE3wzGfDjgzNWG/NlTmGXy/+/JDuz+BsWJ4FxfJdWYjmVl/7mBHTyfCgHhl9nJZRju0pBvB75NM=@vger.kernel.org X-Gm-Message-State: AOJu0YxEzDlr37inJH3Wod493ibCU9jx831/BE6I0rNwEw4sCLsf+Bo+ VhcBkS23Yhki5tFvJxrJp5rQ13ZGYpngFHqHwCv/G7xRYxG6AxfdDpxRNq6Apn3hsazlII12/mU Y9SHF0g== X-Gm-Gg: AY/fxX6P4TTxGJYPN0ojXu2EwwYDLEVP3D/lY0olXeT3Az3DFGd5oxObL7D/FUufdQ6 9BsX+vdhQMtYgtAeoDoQYav8klM0pyWLgJDYMFLKaDHkENIxUdh9thk/lU6zVRgNOv4cZxYlusI bx3km+8i+FuIIuk9pPMLeNIjFG3n03M+oInBA+ncRVSjQ2Z0DQonNrC5I/kjvU361dIxyyQ7cRf MtEucQZ7cE0E4KGjEV4d0XV6Tva2Ar6mdG6Ydn1QZXrkyNLmIrJ1vE84oXFN1G33r7W96wMyDzV +RNhXAyapfeq1WlZzc9KsCKqEy0etrS4BZFWTdT8HCeT5j40LEZT4FPyorSn306jB902wvesUBQ xKhNOwvDMYS9D9EQonqSR29EL/RChC+55XcM93gPxvrofFIIhu0CPX5yZN/wdTLf0QAuzP75Mvy bf6sw1Oc9thy+hzLTKc7xLnTWELfPMYdCSjyTGITxVTm5k X-Received: by 2002:a05:6a00:1818:b0:78a:f6be:74f2 with SMTP id d2e1a72fcca58-81f8f0089damr146513b3a.5.1768410754527; Wed, 14 Jan 2026 09:12:34 -0800 (PST) Received: from google.com (76.9.127.34.bc.googleusercontent.com. [34.127.9.76]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f8e4f5276sm130598b3a.24.2026.01.14.09.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 09:12:33 -0800 (PST) Date: Wed, 14 Jan 2026 17:12:29 +0000 From: David Matlack To: Raghavendra Rao Ananta Cc: Alex Williamson , Alex Williamson , Josh Hilke , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/6] vfio: selftests: Add helper to set/override a vf_token Message-ID: References: <20251210181417.3677674-1-rananta@google.com> <20251210181417.3677674-6-rananta@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-01-08 01:45 PM, Raghavendra Rao Ananta wrote: > On Wed, Jan 7, 2026 at 2:56 PM David Matlack wrote: > > On 2025-12-10 06:14 PM, Raghavendra Rao Ananta wrote: > > > +void vfio_device_set_vf_token(int fd, const char *vf_token) > > > +{ > > > + uuid_t token_uuid = {0}; > > > + > > > + VFIO_ASSERT_NOT_NULL(vf_token, "vf_token is NULL"); nit: Drop the "vf_token is NULL" message. It's unnecessary. > > > + VFIO_ASSERT_EQ(uuid_parse(vf_token, token_uuid), 0); > > > + > > > + vfio_device_feature_set(fd, VFIO_DEVICE_FEATURE_PCI_VF_TOKEN, > > > + token_uuid, sizeof(uuid_t)); > > > +} > > > > Would it be useful to have a variant that returns an int for negative > > testing? > > > I couldn't see any interesting cases where the ioctl could fail that > would warrant a negative test. > The 'incorrect vf token set' is validated later during device init. > I've implemented a negative test for this. > > However, please let me know if you can think of anything. I didn't have anything in mind, I was just curious.