From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B99CD3358D9 for ; Wed, 14 Jan 2026 18:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768415190; cv=none; b=CqusRDwzWrpLDL1hpKIwX+xEZ4y0XAMjxd3mPWsy8pJJMyxCPlmjiYAhRaJogRKD8pqTjsFhUE/aPCHG63+TYSKSQx5aMToEykAKSzY8/e92goc7yvh+zNsIXe8JU0iWNVpbfQ9M072HxP+FV6aIf198mGmdu+nUXopU32IzKWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768415190; c=relaxed/simple; bh=8JKnIWiSHKRzraEBPrxRkZcNRxuxDmfdvDxrPIQVs3o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MziW9jGinc3AXbjexLs4kZo0Aqy9kOJ7Vlu4geJg5u+cUo8sDZgXN9J+Gwh0eRENxenDT6JOF1LCwOU1n45b1eMhnHbqhyx1qoCqsdTIZp5ufachqhde2qq1dNvYOt/VLOhT772HjLSxc3rIRix1vJa/78knWUVzpzSORbwCL2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=i2PTWsod; arc=none smtp.client-ip=209.85.222.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="i2PTWsod" Received: by mail-qk1-f196.google.com with SMTP id af79cd13be357-8c0f13e4424so11782385a.1 for ; Wed, 14 Jan 2026 10:26:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1768415187; x=1769019987; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hqHt2KcHE/zmeJJbObiaCl9QyK/oJJfhNmS1tWGwenk=; b=i2PTWsodxR6zZ4fOyIn8i9GamIUiq1m3R1cVD6h/Rs91iQjJMRBonqle6HcimSW1iI y235U0qruvH2tGemMWHcjCwaWqUUAZ+lwUGLgY5i9MHnyPYdVxdPV4b+zNzkcTLaQHnX MqDAe6VWiHO2ouDxPv3NkTHiz9EYOYtUeAg2ha4hbOZsunAqArZPtCny6d9vt+doORKe 3MGJyrvGKnkXsHDGJv3CbBFvMBV6Q26cl7HV0EzpEf886juqP1IWeavDjGdIkRKNVlCR x6sAJ7UgfaqIPfWODxe4was4Ujn8hLzhjyn6jzveZSQbhvgetBbMCzl0n6/xuvnN7aPN 6V8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768415187; x=1769019987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hqHt2KcHE/zmeJJbObiaCl9QyK/oJJfhNmS1tWGwenk=; b=vjwoVk+JjAQDjLfewb/qEQXDzojFLGsjcor1oA4bSZRLzkcaRRmIbEWN4Om3OzDxuc 6pNKhI0ULhWJZp7hBk0t/SRztCgOQBOHFLgKy62vq3ojLXQx8cO9W3gHRAGwkDJtlkQz 8D2lGK6HMV1YJnka1A3vkTvlyaRI8Usd8mg8pgng/Ax4w67d38NIr3/btr0ac11UIlOL LYRAHzqWX1rzfL5MpRRKJYxPRfW+ABkWkja1i6VUjyZclLAyPPRZFmdEQILCOJf+1XqJ fAOXisyFSXxzPJxlTrgMS2pN7ZUIyw5cNETdqAbnXp+gqsV97jjwpDyyvpgF76+W6jZb q8fg== X-Forwarded-Encrypted: i=1; AJvYcCWSoeIulEjo6dFaAKozzqJJVBRlUBGL3VXRkof53r0TORMtmbt3kSWDln40GekjrgYhk+wTB97vsLcM3bk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy13PnQdmNk4zqpRkG0drZ3eRG/Mk7fC4WMzGQoUFpnJmyiliQ3 h28r6Zj2LeVuJBO9f6uFM5cK1GS8o0wbrkrdMpU6MPKYmJ67pkuKAsCwWpIxNlqWrZc= X-Gm-Gg: AY/fxX5Ks1Va6T9AkvONIgm4rKo4kWe5gL14L8RBSkIqyk6CWyqDe5AhzK1rHtAfeO2 /bo9QIOE6Fq/vc23I3KpN+7ha/+RQ9JIH/sU5GfGA/0m8UR7AWAYcrF80K5dA9LFFBIsfOmDuC9 yX09EjktBQhY7oeqQYn1irkOPeZQyseqfSfP+ivcKlYOwjKFZfv8+Qmnp4ZwiW/rbCLPKcLc0qH a5/kRvjV4oHJti/98KVYJSSQuah08xuHQwjpdcVbBGKSsHK8ocogVteBr/hOY5f8kZUOo929mcE J2X7aRE4o1TSdo0MymTK1icngg/EuRbvNMrMw/hcYsZ+qddWQj+UlnveEzpa0Vmu+nRmWryNOnb jHGx4hp5vaqjIblfBFe47nypSmKhJ/WMXBB7pWUt4YDxULl/+TkQrHKEf0fFDMVrgMyphZm/m/5 mi+k/kIL4kQjqvO3KofbGX2ifoEFDOO1yssEP0bQAsJM8DwID7bikvnXWF+3YDvS92/L5piw== X-Received: by 2002:a05:620a:45a6:b0:8b3:e4c:1bd3 with SMTP id af79cd13be357-8c53148d95fmr413670685a.12.1768415186611; Wed, 14 Jan 2026 10:26:26 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c530be5446sm204964985a.54.2026.01.14.10.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 10:26:26 -0800 (PST) Date: Wed, 14 Jan 2026 13:25:53 -0500 From: Gregory Price To: Jonathan Cameron Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Subject: Re: [PATCH 1/6] drivers/cxl: add cxl_memctrl_mode and region->memctrl Message-ID: References: <20260112163514.2551809-1-gourry@gourry.net> <20260112163514.2551809-2-gourry@gourry.net> <20260114171808.000067e2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260114171808.000067e2@huawei.com> On Wed, Jan 14, 2026 at 05:18:08PM +0000, Jonathan Cameron wrote: > On Mon, 12 Jan 2026 11:35:09 -0500 > Gregory Price wrote: > > > The CXL driver presently hands policy management over to DAX subsystem > > for sysram regions, which makes building policy around the entire region > > clunky and at time difficult (e.g. multiple actions to offline and > > hot-unplug memory reliably). > > > > To support multiple backend controllers for memory regions (for example > > dax vs direct hotplug), implement a memctrl field in cxl_region allows > > switching uncomitted regions between different "memory controllers". > > > > CXL_CONTROL_NONE: No selected controller, probe will fail. > > CXL_CONTROL_AUTO: If memory is already online as SysRAM, no controller > > otherwise register a dax_region > > CXL_CONTROL_DAX : register a dax_region > > > > Auto regions will either be static sysram (BIOS-onlined) and has no > > region controller associated with it - or if the SP bit was set a > > DAX device will be created. > > > > Rather than default all regions to the auto-controller, only default > > auto-regions to the auto controller. > > > > Non-auto regions will be defaulted to CXL_CONTROL_NONE, which will cause > > a failure to probe unless a controller is selected. > > > > Signed-off-by: Gregory Price > Trivial comments whilst I try to get my head around the series. > > ... > Recommend piviting to v2 which simplifies and addresses some of your notes here already: https://lore.kernel.org/linux-cxl/aWfe-r7uEV-ajfhX@gourry-fedora-PF4VCD3F/T/#m791301178876f9b1ab55ed4091c674d4f4ceb07c Still need to add some docs. ~Gregory