From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6392E3D76 for ; Thu, 15 Jan 2026 00:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768437720; cv=none; b=nQ1tq5MDJDbU4twQoKbCqPEJyF8hlYupWS3oZWcWRPmvqUCNfx0jKalLTgywfqCj/LqGIfzWXyiS05n8kBVPHUWXwOnddhd0P/C+dVJN3M0ivvyyO6fPcrHXJBPqISXQgdSvjNtR7fiHtrGFO/Vr+WHd7RGC6AhXhgZt1fkSzK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768437720; c=relaxed/simple; bh=y4e4xuGoQqKP3BmW+PApsUpdlOaPMih9cFoFw7GhlH4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EhYV/MgXhwSdxzDG/XmyRLIlkod5jr28K6k3WAohkyt53Fx6B7I2wxZl5SsHcfkbZcu5h05R+4HoWE8FY5yEIffghsaNPqddqegVbGnzjppYrknXltksnhIoOJfNxCWVUZ7P+SUBnxOXMTHSzwmlu/0DLP5V+bxDCKb6ANmedr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gGEwlxcV; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KB5Hu+4c; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gGEwlxcV"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KB5Hu+4c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768437714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Iz8Jm8YOl06MASb/gCMt5lvamGotRmUJlirY757kvWQ=; b=gGEwlxcVui7hLWgWmlPKzSnFAGXDRBnJi6g6SLhh1saKaU4CUHQalr9m8APMqTeD6yr8ki I59uGUnWyteQP03r2FyMccF0pKCtDHesUkWSjQUrWWjXvqQE3pdhCQxtWCOB0/AOHbBncS voyqTc1NLcksMsTsXRRv5AE81HUl+QA= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-v_hTHrQ3ORqdBdu5qVgDRQ-1; Wed, 14 Jan 2026 19:41:53 -0500 X-MC-Unique: v_hTHrQ3ORqdBdu5qVgDRQ-1 X-Mimecast-MFC-AGG-ID: v_hTHrQ3ORqdBdu5qVgDRQ_1768437712 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b234bae2a7so112345085a.3 for ; Wed, 14 Jan 2026 16:41:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768437712; x=1769042512; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Iz8Jm8YOl06MASb/gCMt5lvamGotRmUJlirY757kvWQ=; b=KB5Hu+4crgcIcahtJqVqtczKS4xq3EUA3Y+HjskYTclmU42RmJ8ZSraSXB/rZrGpRY kFg9bpZoi5DzUlmY8uSzmIcW78f6ha6h21daxnXQO9RuBBsnz8MnQ0dBkPG5ULuoDy5M PyDyTUmLLxWvukBqyRT+8Ax3E8y4x85SvgPWVHQXHWgbuL2oJroICXI97Ixtb1DFeTY/ SLG+e2TocZrPIqbyaj5LGBhRL2Pm4SaCoVmWEDH4Lwm1ZOHCqIBpbem7sA3zjE5gKFgy oSCfK+PEzhkPZnSqCjXEACBKK5OeO/bYxL9dfplhzkpQpjgwlWhZN1LaW1efaXg9znjW nccg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768437712; x=1769042512; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Iz8Jm8YOl06MASb/gCMt5lvamGotRmUJlirY757kvWQ=; b=jlbqghbPB0UtbKZ8ti14lPIqN8gkBrb7/IK5YP3J0UCVrVK4D7FZhQHtsd3oh7pN6y nIZwd5ypgFciTQw6aXIMTbAGNIeFSykV6PSSmpCwS+utV9BRVLW+R6f2S93iAnDIs6uu 0HbN5m7poMzZ7kQ/ZfN9tdI/N+PZlU+hwgfBuEg46Hj5acXqMd7Z5whzqAhw1qJ8J5kI Gg5Jqz88Ftd/+UCvqA/exP1u4pLTatJAK6uJG0HqQUPc2VR5AsgGsGCc73pBlbg//xrN +d9z/Cnuueugl0Yg3Zi171uX3x5zBDLcjqq684m+SUCjtD+ukf+CxVORR9hejcmjXgAy FkwA== X-Forwarded-Encrypted: i=1; AJvYcCX6poqLr3c1Mir7WwO3AGq+3jg0A7bQl5iggXBZV1aCoECDHOPd7mz3tkVPXGzUZnZ6YwIwCQNTcyGjt0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyeOxMizm48YEUQhnI9KQLrWdlWSyX3EtluQOVjXlgrUZwVa3ER t4Hv9cxXFf2ub6FagjQ8g1NhpMbNAG7dueriLli4BTOdibuS48BDXXhBp4AeEKFNgk6stqRN0cj Va2ZPOBs+biG87+1fsLz461MmCVvQlwZ7Ybd+/bK9QtDEWBtUmrRbODSzuvsxgf2G88DA+JvNnQ == X-Gm-Gg: AY/fxX57F0tml6w4GJcPl0uRX42rewWal56gfh4P+ZwDuI1pXwgYHkBOg8AEQsapGTX hcLr0Hwq6wyTdpJvSRHAfCcOsWSH5SID5MXpUQNyT0mFX/7f4cAhdOmCZ47Aqup6QG6T2U/smLu 2HfOIa7yA4AGmcJ6chxY/I4eKpUyR2LR1my/jqrEHth0I3GAQqkffLG6uGJ95QTL8zzq2i55fLg QF0b20yymJnW6vs5g18EiWwhlCy4N86YHLVzf7iSNCOHKcQRPJlZUdPD8v/0GxxFgmR6x4zvSAw q4yNx0ARXb9apw7S6S1HqrFnnTS6xIUJ75Dw+9T3cBa/9ge1IJH2v6OeqvEj+dRdbA2w3887WL6 THnvIFdOZeNywf7RtjzTJtCGe2yMqwcCciFJgN/xTEAqB X-Received: by 2002:a05:620a:4445:b0:8c5:2ce6:dbf with SMTP id af79cd13be357-8c52fb2ed87mr747772785a.17.1768437712515; Wed, 14 Jan 2026 16:41:52 -0800 (PST) X-Received: by 2002:a05:620a:4445:b0:8c5:2ce6:dbf with SMTP id af79cd13be357-8c52fb2ed87mr747771285a.17.1768437712079; Wed, 14 Jan 2026 16:41:52 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770ce985sm184304896d6.11.2026.01.14.16.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 16:41:51 -0800 (PST) Date: Wed, 14 Jan 2026 19:41:50 -0500 From: Brian Masney To: Haoxiang Li Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: st: clkgen-pll: Add a cleaup in clkgen_c32_pll_setup() Message-ID: References: <20260107092250.3423379-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260107092250.3423379-1-lihaoxiang@isrc.iscas.ac.cn> User-Agent: Mutt/2.2.14 (2025-02-20) Hi Haoxiang, The subject has a typo: 'cleaup' should be 'cleanup'. Several notes below. On Wed, Jan 07, 2026 at 05:22:50PM +0800, Haoxiang Li wrote: > Add a iounmap() to release the memory allocated by > clkgen_get_register_base(). > > Signed-off-by: Haoxiang Li > --- > drivers/clk/st/clkgen-pll.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c > index c258ff87a171..cc1dd9523fb2 100644 > --- a/drivers/clk/st/clkgen-pll.c > +++ b/drivers/clk/st/clkgen-pll.c > @@ -777,7 +777,7 @@ static void __init clkgen_c32_pll_setup(struct device_node *np, > clk = clkgen_pll_register(parent_name, datac->data, pll_base, pll_flags, > np->name, datac->data->lock); > if (IS_ERR(clk)) > - return; > + goto err_unmap; > > pll_name = __clk_get_name(clk); > > @@ -785,7 +785,7 @@ static void __init clkgen_c32_pll_setup(struct device_node *np, > > clk_data = kzalloc(sizeof(*clk_data), GFP_KERNEL); > if (!clk_data) > - return; > + goto err_unmap; These look fine, along with the err_unmap below. It looks like there's several other leaks in this code though. > clk_data->clk_num = num_odfs; > clk_data->clks = kcalloc(clk_data->clk_num, sizeof(struct clk *), > @@ -827,6 +827,9 @@ static void __init clkgen_c32_pll_setup(struct device_node *np, > kfree(pll_name); ^^^^^^^^^ I know this isn't part of your patch, however pll_name is actually the return value from __clk_get_name(), which is name member from struct device_node. Is that correct to free here in the case of an error? Additionaly, clkgen_pll_register() calls kzalloc() for struct clkgen_pll, and it won't be freed on the error case. In clkgen_c32_pll_setup(): > clk = clkgen_pll_register(parent_name, datac->data, pll_base, pll_flags, > np->name, datac->data->lock); > if (IS_ERR(clk)) > return; > > pll_name = __clk_get_name(clk); > > num_odfs = datac->data->num_odfs; > > clk_data = kzalloc(sizeof(*clk_data), GFP_KERNEL); > if (!clk_data) > return; ^^^ clk is not freed here, along with pll_base does not have iounmap called on it. Brian