From: Sudeep Holla <sudeep.holla@arm.com>
To: Feng Tang <feng.tang@linux.alibaba.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
James Morse <james.morse@arm.com>,
Joanthan Cameron <Jonathan.Cameron@huawei.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ACPI: PPTT: Dump PPTT table when error detected
Date: Thu, 15 Jan 2026 10:02:06 +0000 [thread overview]
Message-ID: <aWi7HjGDAGdRYjS6@bogus> (raw)
In-Reply-To: <aWit6bbjwfTzDRQw@U-2FWC9VHC-2323.local>
On Thu, Jan 15, 2026 at 05:05:45PM +0800, Feng Tang wrote:
> Hi Sudeep,
>
> On Wed, Jan 14, 2026 at 03:06:09PM +0000, Sudeep Holla wrote:
> > On Wed, Jan 14, 2026 at 10:28:19PM +0800, Feng Tang wrote:
> > >
> > > As for the original issue where kernel printed the error message
> > > " ACPI PPTT: PPTT table found, but unable to locate core 1 (1)",
> > > can we just printed out all the CPU entries of the PPTT table?
> > > which is much cleaner and smaller, and have the enough information
> > > for quickly identifying the root cause. As the number of cache
> > > items is usually 3X of number of CPUs.
> >
> > I am still not sure what additional value is gained by listing all those CPU
> > entries. On a 512-CPU system, for example, if an issue is identified with the
> > entry for CPU 256, what extra information is obtained by listing all the other
> > CPUs, such as those sharing the same L3 cache or entire list of CPUs on this
> > system?
>
> My bad that I didn't make it clear. As for the original issue, the
> platform has 8 CPUs, but the PPTT table only has 4 CPUs, while the MADT
> and other tables are correct about the CPU numbers, and kernel does
> successfully bringup all 8 CPUs. The PPTT message
> " ACPI PPTT: PPTT table found, but unable to locate core 1 (1)" is kind
> of modest and didn't caught our much attention as all 8 CPUS were onlined
> fine. So with the "print only necessary info" suggestion from Rafael,
> it will print out only 4 CPUS, which should immediately show the PPTT
> table itself is wrong, and worth deeper check.
>
To be clear, listing CPUs is annoying on large systems. In your case, it may
be only 4 CPUs and that seems fine, but imagine if one CPU entry is missing on
a 512 CPU system - dumping a list of 511 CPUs is not only irritating, but also
largely useless for diagnosing the issue.
In my view, for the scenario above, the error should say something along the
lines of: the PPTT CPU entry count does not match the system CPU count.
--
Regards,
Sudeep
next prev parent reply other threads:[~2026-01-15 10:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 10:49 [PATCH v2] ACPI: PPTT: Dump PPTT table when error detected Feng Tang
2026-01-10 4:29 ` Hanjun Guo
2026-01-10 15:04 ` Feng Tang
2026-01-12 11:19 ` Hanjun Guo
2026-01-12 17:02 ` Sudeep Holla
2026-01-13 8:25 ` Feng Tang
2026-01-13 14:40 ` Sudeep Holla
2026-01-14 7:06 ` Feng Tang
2026-01-14 11:36 ` Rafael J. Wysocki
2026-01-14 14:28 ` Feng Tang
2026-01-14 14:55 ` Rafael J. Wysocki
2026-01-14 15:06 ` Sudeep Holla
2026-01-14 15:07 ` Rafael J. Wysocki
2026-01-15 9:05 ` Feng Tang
2026-01-15 10:02 ` Sudeep Holla [this message]
2026-01-15 10:52 ` Feng Tang
2026-01-13 16:21 ` Rafael J. Wysocki
2026-01-14 7:47 ` Feng Tang
2026-01-14 11:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWi7HjGDAGdRYjS6@bogus \
--to=sudeep.holla@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=feng.tang@linux.alibaba.com \
--cc=guohanjun@huawei.com \
--cc=james.morse@arm.com \
--cc=jeremy.linton@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox